[lazarus] Patch for reading LRE encoded BMP files

2008-02-01 Thread Sebastian Günther
Hi *, attached is a small patch which enables the LCL to read RLE encoded BMP files (successfully tested with some hundreds of small 8 bpp bitmaps, 4 bpp should work as well). Maybe somebody wants to commit this small patch :) Diff is against Lazarus 0.9.24 Regards, Sebastian 426a427

Re: [lazarus] Patch for reading LRE encoded BMP files

2008-02-01 Thread Sebastian Günther
Giuliano Colla schrieb: Maybe there's some inconsistency hanging around: in intgraphics.pas - TLazReaderBMP.InternalReadBody, when attempting to read RLE Bitmap: raise FPImageException.Create('4 bit RLE Bitmaps not supported'); raise FPImageException.Create('8 bit RLE

Re: [lazarus] Patch for reading LRE encoded BMP files

2008-02-01 Thread Michael Van Canneyt
On Fri, 1 Feb 2008, Sebastian Günther wrote: Hi *, attached is a small patch which enables the LCL to read RLE encoded BMP files (successfully tested with some hundreds of small 8 bpp bitmaps, 4 bpp should work as well). I don't understand why this is needed, RLE bitmaps have been

Re: [lazarus] Patch for reading LRE encoded BMP files

2008-02-01 Thread Sebastian Günther
Michael Van Canneyt schrieb: I think the reason is historical: TFPBMPReader allows to override some methods, and lazarus did this to improve on performance. Meanwhile the TFPBMPReader also improved, but lazarus never 'sees' the improvements, since the methods are overridden. Okay, so what is

Re: [lazarus] Patch for reading LRE encoded BMP files

2008-02-01 Thread Sebastian Günther
Michael Van Canneyt schrieb: On Fri, 1 Feb 2008, Sebastian Günther wrote: Hi *, attached is a small patch which enables the LCL to read RLE encoded BMP files (successfully tested with some hundreds of small 8 bpp bitmaps, 4 bpp should work as well). I don't understand why this is needed,

Re: [lazarus] Patch for reading LRE encoded BMP files

2008-02-01 Thread Giuliano Colla
Michael Van Canneyt ha scritto: On Fri, 1 Feb 2008, Sebastian Günther wrote: Hi *, attached is a small patch which enables the LCL to read RLE encoded BMP files (successfully tested with some hundreds of small 8 bpp bitmaps, 4 bpp should work as well). I don't understand why this is

Re: [lazarus] Patch for reading LRE encoded BMP files

2008-02-01 Thread Michael Van Canneyt
On Fri, 1 Feb 2008, Sebastian Günther wrote: Michael Van Canneyt schrieb: I think the reason is historical: TFPBMPReader allows to override some methods, and lazarus did this to improve on performance. Meanwhile the TFPBMPReader also improved, but lazarus never 'sees' the

Re: [lazarus] Patch for reading LRE encoded BMP files

2008-02-01 Thread Horacio Jamilis
Sorry to ask before searching on the code base but... is there code to ENCODE RLE BMP files? I am building a support aplication (something like VNC with some aditional things we need)... Thanks. Horacio Sebastian Günther escribió: Hi *, attached is a small patch which enables the LCL to