Re: [LEDE-DEV] [PATCH usbmode] fix indices of messages

2017-05-18 Thread Bastian Bittorf
* Julian Labus [19.05.2017 07:29]: > to me it looks like LEDE has its own implementation of usb-modeswitch > and only uses usb-modeswitch-data from the upstream project or is this > just a mirror? > > https://git.lede-project.org/?p=project/usbmode.git You are totally

[LEDE-DEV] [netifd][PATCH] Remove redundant check for strtoul() return value

2017-05-18 Thread Khem Raj
Fixes system-linux.c:1998:33: error: comparison of unsigned expression >= 0 is always true [-Werror,-Wtautological-compare] Signed-off-by: Khem Raj --- system-linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system-linux.c b/system-linux.c

[LEDE-DEV] [PATCH 2/3] brcm47xx: resolve GPIO conflict for WRT54GSv1

2017-05-18 Thread Mirko Parthey
On the Linksys WRT54GSv1, the adm6996 switch driver and the gpio_button_hotplug module both claim GPIO 6, which is connected to the Reset button. When the switch driver's request wins, the Reset button cannot work. This makes it impossible to enter failsafe mode without a serial console. Stop

[LEDE-DEV] [PATCH 1/3] brcm47xx: use DMZ LED as status indicator

2017-05-18 Thread Mirko Parthey
On the Linksys WRT54GSv1, the Power LED flickers in the "off" state. Indicate status using the DMZ LED if available, since it has solid "on" and "off" states. This change was tested on the WRT54GSv1, but may also affect other brcm47xx devices. Fixes FS#793. Signed-off-by: Mirko Parthey

Re: [LEDE-DEV] [PATCH] imx6: add gw560x support

2017-05-18 Thread Tim Harvey
On Sat, May 6, 2017 at 1:07 AM, Mathias Kresin wrote: > 05.05.2017 22:15, Tim Harvey: >> >> Signed-off-by: Tim Harvey > > > Hey Tim, > > would you please include a short description about the hardware and how to > install LEDE on the board in your commit

Re: [LEDE-DEV] [PATCH usbmode] fix indices of messages

2017-05-18 Thread Piotr Dymacz
Hello Julian, Bastian, On 18.05.2017 21:02, Julian Labus wrote: Hi Bastian, to me it looks like LEDE has its own implementation of usb-modeswitch and only uses usb-modeswitch-data from the upstream project or is this just a mirror? Yes, that is correct. I was going to send something similar

Re: [LEDE-DEV] [PATCH usbmode] fix indices of messages

2017-05-18 Thread Bastian Bittorf
* Julian Labus [18.05.2017 20:16]: > the way how the script checked if a key already exists in a hash > leads to wrong indices for %messages. > > Signed-off-by: Julian Labus > --- > convert-modeswitch.pl | 9 + thanks for your patch. it

Re: [LEDE-DEV] [PATCH v5] dnsmasq: also write /tmp/resolv.conf when UCI dhcp.dnsmasq.noresolv is '1'

2017-05-18 Thread Hans Dedecker
On Sun, May 14, 2017 at 8:22 PM, Paul Oranje wrote: > > fixes FS#785 > Hi, Thanks for the patch but be more verbose in the comment description what problem you're trying to solve; the commit subject should be limited to 50 characters. See also

[LEDE-DEV] [PATCH usbmode] fix indices of messages

2017-05-18 Thread Julian Labus
the way how the script checked if a key already exists in a hash leads to wrong indices for %messages. Signed-off-by: Julian Labus --- convert-modeswitch.pl | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/convert-modeswitch.pl

Re: [LEDE-DEV] [PATCH V2] Support specifying instance name in JSON file

2017-05-18 Thread John Crispin
On 12/05/17 11:08, Rafał Miłecki wrote: From: Rafał Miłecki So far we were using host label as the instance name for every service. This change allows specifying it manually and fallbacks to the label for backward compatibility. Signed-off-by: Rafał Miłecki

Re: [LEDE-DEV] [PATCH v2 2/3] base-files: put board_name into separate file

2017-05-18 Thread Roman Yeryomin
On 18 May 2017 at 01:05, Mathias Kresin wrote: > 17.05.2017 21:08, Roman Yeryomin: >> >> On 17 May 2017 at 21:39, Roman Yeryomin wrote: >>> >>> On 17 May 2017 at 16:19, Mathias Kresin wrote: Hey Roman., independent of

Re: [LEDE-DEV] [PATCH libubox] json_script: enable custom expr handler callback

2017-05-18 Thread Denis Osvald
On 2017-05-18 09:39, Denis Osvald wrote: > This wires in custom expression handler functionality, which was > present in json script since the original version, but never used. To add a bit of context: Experimenting with procd service triggers, it was noticed that when adding triggers for a

[LEDE-DEV] [PATCH libubox] json_script: enable custom expr handler callback

2017-05-18 Thread Denis Osvald
This wires in custom expression handler functionality, which was present in json script since the original version, but never used. Signed-off-by: Denis Osvald --- json_script.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/json_script.c