[LEDE-DEV] [PATCH mdns 1/2] Don't use _services._dns-sd._tcp.local

2017-02-10 Thread Rafał Miłecki
From: Rafał Miłecki It seems mdns(d) was trying to support queries for two records with following names: 1) _services._dns-sd._udp.local 2) _services._dns-sd._tcp.local According to the RFC 6763 Section 9 only the first one should be used and response PTR records should include services of both

[LEDE-DEV] [PATCH mdns 2/2] Drop one-liner service_announce function

2017-02-10 Thread Rafał Miłecki
From: Rafał Miłecki Now we have service_announce simplified so much there is no reason to keep it as a helper. Signed-off-by: Rafał Miłecki --- announce.c | 2 +- interface.c | 2 +- service.c | 6 -- service.h | 1 - 4 files changed, 2 insertions(+), 9 deletions(-) diff --git a

[LEDE-DEV] [PATCH mdns] Rename cache scanning to updating

2017-02-10 Thread Rafał Miłecki
From: Rafał Miłecki What we were do is querying over all interfaces for all cached entries. This isn't real scanning but rather updating (the cache). Signed-off-by: Rafał Miłecki --- cache.c | 2 +- cache.h | 2 +- ubus.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-)

[LEDE-DEV] [PATCH mdns] Check correct attributes when loading service from blob

2017-02-10 Thread Rafał Miłecki
From: Rafał Miłecki We access SERVICE_TXT so we should check for this entry. Checking SERVICE_SERVICE doesn't make sense anyway as it's verified few lines above (in the same funcion). Signed-off-by: Rafał Miłecki --- service.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[LEDE-DEV] [PATCH mdns] Avoid duplicated iteration over services when announcing

2017-02-10 Thread Rafał Miłecki
From: Rafał Miłecki In function service_announce_services we iterate over services and handle every single one so calling service_reply which also iterates doesn't make sense. In simple cases it was just wasting CPU cycles. We got service, we were passing its name and we were looking f

[LEDE-DEV] [PATCH mdns] Send reverse DNS lookup entry for IPv4 address

2017-02-10 Thread Rafał Miłecki
From: Rafał Miłecki Whenever we send A(AAA) records, let's also include reverse lookup ones. This should be extended in the future by adding IPv6. Signed-off-by: Rafał Miłecki --- announce.c | 2 +- dns.c | 38 +++--- dns.h | 2 +- interf

Re: [LEDE-DEV] [PATCH v2] ramips: add support for RATOC REX-WIFISD2

2017-02-09 Thread Rafał Miłecki
On 9 February 2017 at 15:13, John Crispin wrote: > On 28/01/2017 17:03, FUKAUMI Naoki wrote: >> diff --git a/target/linux/ramips/dts/REX-WIFISD2.dts >> b/target/linux/ramips/dts/REX-WIFISD2.dts >> new file mode 100644 >> index 000..4d8819a >> --- /dev/null >> +++ b/target/linux/ramips/dts/REX

Re: [LEDE-DEV] License for DTS files

2017-02-09 Thread Rafał Miłecki
On 3 February 2017 at 12:29, Rafał Miłecki wrote: > In LEDE we have quite a lot of DTS files that hasn't been upstreamed. > They often contain no licensing info. > > Upstream Linux maintainers prefer/require clear BSD-compatible > license, see e.g.: > https://lkml.org/lkm

[LEDE-DEV] [PATCH mdns] Send A(AAA) records when announcing

2017-02-09 Thread Rafał Miłecki
From: Rafał Miłecki This allows device to be discovered by its local hostname. Signed-off-by: Rafał Miłecki --- announce.c | 1 + 1 file changed, 1 insertion(+) diff --git a/announce.c b/announce.c index 03c7b8f..ad129c0 100644 --- a/announce.c +++ b/announce.c @@ -66,6 +66,7

[LEDE-DEV] [PATCH mdns] Don't call dns_reply_a from service_reply

2017-02-08 Thread Rafał Miłecki
From: Rafał Miłecki This simplifies code without changing any behavior. Having this call in service_reply required checking two conditions and was making code flow harder to follow. There are 2 more service_reply calls in the project: 1) In service_announce_services where we iterate over

[LEDE-DEV] [PATCH mdns] Rename service_reply_a to dns_reply_a and move it to proper file

2017-02-08 Thread Rafał Miłecki
From: Rafał Miłecki This function doesn't really do anything service specify, it just sends an A(AAA) records. It could probably be used even without any services registered. Signed-off-by: Rafał Miłecki --- dns.c | 32 +++- dns.h | 1 + interf

[LEDE-DEV] [PATCH mdns] Add simple "Fall through" comment to the announce_timer function switch

2017-02-08 Thread Rafał Miłecki
From: Rafał Miłecki It's a common practice to add such comments to make it clear break instruction was skipped on purpose. Signed-off-by: Rafał Miłecki --- announce.c | 1 + 1 file changed, 1 insertion(+) diff --git a/announce.c b/announce.c index d1aca5b..03c7b8f 100644 --- a/annou

[LEDE-DEV] [PATCH mdns] Change dns_send_question function arg from unicast to multicast

2017-02-08 Thread Rafał Miłecki
From: Rafał Miłecki This trivial patch just reverses argument logic to make it a bit more consistent with struct interface which contains "multicast" field. This hopefully will make typos less likely and code easier to follow. Signed-off-by: Rafał Miłecki --- announce.c | 2 +

[LEDE-DEV] Ethernet support: built-in or as modules?

2017-02-07 Thread Rafał Miłecki
I think various targets handle it in different ways. E.g. brcm47xx has modules for b44, tg3 and bgmac while bcm53xx has bgmac built-in. Is there any preference for this? I was thinking about supporting more Ethernet-related stuff like switchdev, DSA, b53. It would be nice to have a clear guidance

[LEDE-DEV] [PATCH] kernel: add option to enable bridge VLAN filtering

2017-02-07 Thread Rafał Miłecki
From: Rafał Miłecki It's needed to get proper bridging support with DSA drivers. Signed-off-by: Rafał Miłecki --- package/kernel/linux/modules/netsupport.mk | 14 ++ 1 file changed, 14 insertions(+) diff --git a/package/kernel/linux/modules/netsupport.mk b/package/kernel/

Re: [LEDE-DEV] Backporting stuff to lede-17.01

2017-02-05 Thread Rafał Miłecki
On 6 February 2017 at 00:39, Rafał Miłecki wrote: > On 2 February 2017 at 12:32, Rafał Miłecki wrote: >> There are few changes that recently went into master and I'd like to >> see in lede-17.01. Let me what do you think, if backporting any of >> these is a bad idea.

Re: [LEDE-DEV] Backporting stuff to lede-17.01

2017-02-05 Thread Rafał Miłecki
On 2 February 2017 at 12:32, Rafał Miłecki wrote: > There are few changes that recently went into master and I'd like to > see in lede-17.01. Let me what do you think, if backporting any of > these is a bad idea. > > 1) bgmac support for external PHYs > 6a853776a502 (

Re: [LEDE-DEV] [PATCH] Kernel: bump LEDE 17.01 kernel to 4.4.47

2017-02-05 Thread Rafał Miłecki
On 5 February 2017 at 22:44, Rafał Miłecki wrote: > On 5 February 2017 at 22:30, Stijn Tintel wrote: >> On 05-02-17 17:49, Stijn Segers wrote: >>> Bumps kernel from .46 to .47. >>> >> This has to be done in master first, then cherry-picked into lede-17.01. > &

Re: [LEDE-DEV] [PATCH] Kernel: bump LEDE 17.01 kernel to 4.4.47

2017-02-05 Thread Rafał Miłecki
On 5 February 2017 at 22:30, Stijn Tintel wrote: > On 05-02-17 17:49, Stijn Segers wrote: >> Bumps kernel from .46 to .47. >> > This has to be done in master first, then cherry-picked into lede-17.01. Good point, this patch is confusing. Is this based on top of master with a wrong title? Or is it

Re: [LEDE-DEV] [PATCH v4] ramips: Add support for Sanlinking D240

2017-02-05 Thread Rafał Miłecki
tr Dymacz). > > v2->v3: > * Rename Sanlinking-D240 to D240 in order to follow convention that board name > should not contain manufacturer name (thanks Piotr Dymacz). > * Add BSD license to DTS file (thanks Rafał Miłecki). > * Add details on how to install LEDE on the router (th

[LEDE-DEV] License for DTS files

2017-02-03 Thread Rafał Miłecki
In LEDE we have quite a lot of DTS files that hasn't been upstreamed. They often contain no licensing info. Upstream Linux maintainers prefer/require clear BSD-compatible license, see e.g.: https://lkml.org/lkml/2016/5/4/707 Some people may not agree such files are copyrightable at all, but most

Re: [LEDE-DEV] [PATCH v2] ramips: Add support for Sanlinking D240

2017-02-03 Thread Rafał Miłecki
On 3 February 2017 at 09:54, Kristian Evensen wrote: > diff --git a/target/linux/ramips/dts/SANLINKING-D240.dts > b/target/linux/ramips/dts/SANLINKING-D240.dts > new file mode 100644 > index 000..888f5aa > --- /dev/null > +++ b/target/linux/ramips/dts/SANLINKING-D240.dts > @@ -0,0 +1,120 @@ >

[LEDE-DEV] Backporting stuff to lede-17.01

2017-02-02 Thread Rafał Miłecki
Hi, There are few changes that recently went into master and I'd like to see in lede-17.01. Let me what do you think, if backporting any of these is a bad idea. 1) bgmac support for external PHYs 6a853776a502 ("kernel: backport bgmac support for external PHYs") This adds support for some AP devic

Re: [LEDE-DEV] [PATCH] Add Friendly Interactive Shell

2017-02-01 Thread Rafał Miłecki
On 1 February 2017 at 23:36, Shane Peelar wrote: > Signed-off-by: Shane Peelar Please use something like [PATCH packages] > --- > utils/fish/Makefile | 71 > + > utils/fish/patches/0001-configure.patch | 11 + > 2 files changed, 82 inse

Re: [LEDE-DEV] [PATCH 2/2] target/generic: update settings of mx25u3235f

2017-02-01 Thread Rafał Miłecki
On 1 February 2017 at 22:08, André Valentin wrote: > This patch enabled 4K, dual and quad read. Settings have been verified with > a real device. Please send it to linux-mtd for upstream inclusion first. ___ Lede-dev mailing list Lede-dev@lists.infrade

[LEDE-DEV] [PATCH] bcm53xx: set WAN MAC address to don't share one with LAN interface

2017-02-01 Thread Rafał Miłecki
From: Rafał Miłecki After analyzing numerous NVRAMs and vendor firmwares it seems the base MAC address is used for LAN interface. WAN interface has different one which sometimes is set directly in NVRAM and sometines needs to be calculated. Signed-off-by: Rafał Miłecki --- target/linux

Re: [LEDE-DEV] [PATCH] bcm53xx: fix LAN MAC address for devices that use eth2 originally

2017-02-01 Thread Rafał Miłecki
On 1 February 2017 at 10:43, Felix Fietkau wrote: > On 2017-01-31 13:53, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> We override default Ethernet interface with eth0 which often uses random >> MAC due to missing proper NVRAM entry. Fix this by manually ass

[LEDE-DEV] [PATCH] bcm53xx: fix LAN MAC address for devices that use eth2 originally

2017-01-31 Thread Rafał Miłecki
From: Rafał Miłecki We override default Ethernet interface with eth0 which often uses random MAC due to missing proper NVRAM entry. Fix this by manually assigning MAC in the config. Signed-off-by: Rafał Miłecki --- target/linux/bcm53xx/base-files/etc/board.d/02_network | 6 ++ 1 file

[LEDE-DEV] [PATCH] mac80211: enable brcm80211 debugging by default on bcm53xx

2017-01-30 Thread Rafał Miłecki
From: Rafał Miłecki This has increased rootfs size for Netgear R8000 (sample device using brcmfmac) by 16124 B. Most of devices with brcmfmac supported chipsets have quite big flash memories and debugging may be useful noting that we got some stability problems and still report them. Signed-off

[LEDE-DEV] [PATCH 2/2] mac80211: start hostapd with logging wpa_printf messages to syslog

2017-01-29 Thread Rafał Miłecki
From: Rafał Miłecki Some debugging/error messages are printed using wpa_printf and this change allows finally reading them out of the syslog. Signed-off-by: Rafał Miłecki --- package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[LEDE-DEV] [PATCH 1/2] hostapd: enable support for logging wpa_printf messages to syslog

2017-01-29 Thread Rafał Miłecki
From: Rafał Miłecki This will allow starting hostapd with the new -s parameter and finally read all (error) messages from the syslog. Signed-off-by: Rafał Miłecki --- package/network/services/hostapd/files/hostapd-full.config | 3 +++ package/network/services/hostapd/files/hostapd-mini.config

Re: [LEDE-DEV] [PATCH] openvpn: ssl-enabled variants also provide a virtual openvpn-x509 package

2017-01-22 Thread Rafał Miłecki
On 22 January 2017 at 00:48, Sven Roederer wrote: > When relying on x.509 certs for auth don't use package openvpn-nossl. Just > have your package depend on openvpn-x509 to have SSL enabled in OpenVPN. > If x.509 is not a must, use virtual packge openvpn, which is provided by > all OpenVPN-variant

Re: [LEDE-DEV] [PATCH] mac80211: backport calculate-min-channel-width fix

2017-01-20 Thread Rafał Miłecki
On 20 January 2017 at 11:33, Felix Fietkau wrote: > On 2017-01-20 11:26, Koen Vandeputte wrote: >> Signed-off-by: Koen Vandeputte > To get the filenames right, please use import-backports.sh from > package/kernel/mac80211/scripts: > > - export the commit from a git tree with git-format-patch -o

Re: [LEDE-DEV] [PATCH] This patch adds support for the Netgear WN3000RPv3 N300 repeater.

2017-01-17 Thread Rafał Miłecki
On 17 January 2017 at 23:12, wrote: > From: Thibaut VARENE > > It uses the same trick as for the EX2700 to pass the Second Part > Magic Check from the bootloader (as described here > https://forum.openwrt.org/viewtopic.php?pid=312577#p312577 ) > > Specifications: > - SoC: MediaTek MT7620A (580MH

[LEDE-DEV] procd & custom reload support

2017-01-12 Thread Rafał Miłecki
Hi, I've app that reads config from /etc/foo.conf and I use init.d script to generate that file based on /etc/config/foo. A nice feature my app has is runtime config reload triggered by kill -SIGUSR1 $PID I guess I need something like this: start_service() { local port config_loa

Re: [LEDE-DEV] [PATCH] brcm47xx: legacy: specify DEVICE_PACKAGES for all devices

2017-01-04 Thread Rafał Miłecki
On 29 December 2016 at 08:06, Rafał Miłecki wrote: > From: Rafał Miłecki > > This allows more feature complete images. Of course it affect the size, > e.g. enabling b43 bumped rootfs from 1569618 to 2029122 for me. > > Signed-off-by: Rafał Miłecki For devices with BCM4306 it&

[LEDE-DEV] [PATCH luci] luci-mod-admin-full: allow unset txpower value

2017-01-03 Thread Rafał Miłecki
From: Rafał Miłecki Sometimes txpower is not set so we should have an option with empty value to let it stay unset. Signed-off-by: Rafał Miłecki --- .../luci-mod-admin-full/luasrc/model/cbi/admin_network/wifi.lua| 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a

Re: [LEDE-DEV] brcm47xx legacy image building issues

2017-01-02 Thread Rafał Miłecki
On 01/02/2017 04:50 PM, Eric Masson wrote: I get the following error while trying to generate an image for a WGT634U : emss@vmwdebems:~/lede-imagebuilder-brcm47xx-legacy.Linux-x86_64$ make image PACKAGES="aiccu fwknopd luci luci-app-firewall luci-app-fwknopd luci-app-sqm luci-proto-ipv6 luci-pr

[LEDE-DEV] [PATCH] brcm47xx: mips74k: specify DEVICE_PACKAGES for all devices

2016-12-29 Thread Rafał Miłecki
From: Rafał Miłecki Signed-off-by: Rafał Miłecki --- target/linux/brcm47xx/image/Makefile | 39 1 file changed, 39 insertions(+) diff --git a/target/linux/brcm47xx/image/Makefile b/target/linux/brcm47xx/image/Makefile index 597b031..5040818 100644 --- a

[LEDE-DEV] [PATCH] brcm47xx: legacy: specify DEVICE_PACKAGES for all devices

2016-12-28 Thread Rafał Miłecki
From: Rafał Miłecki This allows more feature complete images. Of course it affect the size, e.g. enabling b43 bumped rootfs from 1569618 to 2029122 for me. Signed-off-by: Rafał Miłecki --- target/linux/brcm47xx/image/Makefile | 30 +- 1 file changed, 29 insertions

[LEDE-DEV] [PATCH 2/2] brcm47xx: drop standalong Netgear WGT634U profile

2016-12-28 Thread Rafał Miłecki
From: Rafał Miłecki We have profile for this device thanks to DEVICE_PACKAGES. Signed-off-by: Rafał Miłecki Cc: Russell Senior --- target/linux/brcm47xx/legacy/profiles/WGT634U.mk | 17 - 1 file changed, 17 deletions(-) delete mode 100644 target/linux/brcm47xx/legacy

[LEDE-DEV] [PATCH 1/2] brcm47xx: specify DEVICE_PACKAGES for Netgear WGT634U

2016-12-28 Thread Rafał Miłecki
From: Rafał Miłecki This allows using it nicely with PER_DEVICE_ROOTFS. Signed-off-by: Rafał Miłecki Cc: Russell Senior --- target/linux/brcm47xx/image/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/linux/brcm47xx/image/Makefile b/target/linux/brcm47xx/image/Makefile

Re: [LEDE-DEV] ramips: Fixed NixCore profile TARGET_DEVICE

2016-12-28 Thread Rafał Miłecki
On 28 December 2016 at 23:14, Drew from NixCore wrote: > From 23b73de3aef72963c1f7989d5d49a4ec7553ee47 Mon Sep 17 00:00:00 2001 > From: Drew Gaylo > Date: Wed, 28 Dec 2016 15:09:24 -0700 > Subject: [PATCH] Fixed define/ and TARGET_DEVICE issue for NixCore > > Signed-off-by: Drew Gaylo Already f

Re: [LEDE-DEV] Release planning

2016-12-28 Thread Rafał Miłecki
On 22 December 2016 at 13:42, Rafał Miłecki wrote: > On 21 December 2016 at 20:13, Jo-Philipp Wich wrote: >> - Are there any outstanding changes? >> >> Is there important changes we should wait for before branching the >> release? Is there pending stuff in the

Re: [LEDE-DEV] Release planning

2016-12-22 Thread Rafał Miłecki
On 21 December 2016 at 20:13, Jo-Philipp Wich wrote: > - Are there any outstanding changes? > > Is there important changes we should wait for before branching the > release? Is there pending stuff in the staging trees which should > absolutely go into the first release? 1) Possible brcmfmac

Re: [LEDE-DEV] [PATCH] kernel: bump to 4.4.39

2016-12-16 Thread Rafał Miłecki
On 12/16/2016 11:12 AM, Koen Vandeputte wrote: @@ -4,11 +4,11 @@ LINUX_RELEASE?=1 LINUX_VERSION-3.18 = .43 LINUX_VERSION-4.1 = .34 -LINUX_VERSION-4.4 = .38 +LINUX_VERSION-4.4 = .39 LINUX_KERNEL_MD5SUM-3.18.43 = b1faeb4a2e1e70ffe061bdbb3452840a LINUX_KERNEL_MD5SUM-4.1.34 = fba99f0f4765ebf010

Re: [LEDE-DEV] [PATCH] libubox: Fix cppcheck warnings

2016-12-14 Thread Rafał Miłecki
On 14 December 2016 at 06:47, Rosen Penev wrote: > @@ -44,7 +44,10 @@ void *__calloc_a(size_t len, ...) > > ptr = calloc(1, alloc_len); > if (!ptr) > + { > + va_end(ap); > return NULL; > + } Please following coding style used across the wh

[LEDE-DEV] [PATCH] bcm53xx: disable CONFIG_FW_LOADER_USER_HELPER_FALLBACK

2016-12-11 Thread Rafał Miłecki
From: Rafał Miłecki There are many targets using user space scripts to generate firmware but bcm53xx doesn't need this, so let's disable that kernel option. This lets us avoid some scary-looking kernel warnings like: brcmfmac 0001:04:00.0: Falling back to user helper firmware brcm!brc

Re: [LEDE-DEV] What's the purpose / gain from using VARIANT?

2016-12-08 Thread Rafał Miłecki
On 8 December 2016 at 02:00, Florian Fainelli wrote: > On 12/07/2016 11:52 AM, Rafał Miłecki wrote: >> On 12/07/2016 08:36 PM, Sergey Ryazanov wrote: >>> On Wed, Dec 7, 2016 at 10:10 PM, Rafał Miłecki wrote: >>>> I'm aware some packages (e.g. upstream-ssl,

Re: [LEDE-DEV] [PATCH] kernel: add TI tmp102 and tmp103 temperature sensors

2016-12-07 Thread Rafał Miłecki
On 7 December 2016 at 22:45, Hauke Mehrtens wrote: > This just adds the kmods for these kernel modules. > This is found on some Lantiq / Intel reference boards. > > Signed-off-by: Hauke Mehrtens > --- > package/kernel/linux/modules/hwmon.mk | 30 ++ > 1 file changed,

Re: [LEDE-DEV] What's the purpose / gain from using VARIANT?

2016-12-07 Thread Rafał Miłecki
On 12/07/2016 08:36 PM, Sergey Ryazanov wrote: On Wed, Dec 7, 2016 at 10:10 PM, Rafał Miłecki wrote: I'm aware some packages (e.g. upstream-ssl, hostapd, dnsmasq) use VARIANT. I don't really understand the gain of this. How does it differ from specifying separated packages? I&#x

[LEDE-DEV] What's the purpose / gain from using VARIANT?

2016-12-07 Thread Rafał Miłecki
I'm aware some packages (e.g. upstream-ssl, hostapd, dnsmasq) use VARIANT. I don't really understand the gain of this. How does it differ from specifying separated packages? I'm looking at package/libs/ustream-ssl/Makefile and I don't see much code saving from using this VARIANT variable/feature.

Re: [LEDE-DEV] [PATCH 1/1] add support for overlaying rootfs content

2016-12-07 Thread Rafał Miłecki
On 7 December 2016 at 16:44, Karl Palsson wrote: > How is this different from just reverting the commit that stopped > this from working? I'm all for this, don't get me wrong, but if a > package can just explicitly define a file as "this overwrites > whatever" how is that any different from before

[LEDE-DEV] [EXAMPLE 2/1] custom-banner: package customizing LEDE banner

2016-12-07 Thread Rafał Miłecki
From: Rafał Miłecki Signed-off-by: Rafał Miłecki --- package/custom-banner/Makefile | 28 package/custom-banner/banner | 10 ++ 2 files changed, 38 insertions(+) create mode 100644 package/custom-banner/Makefile create mode 100644 package/custom-banner

[LEDE-DEV] [PATCH 1/1] add support for overlaying rootfs content

2016-12-07 Thread Rafał Miłecki
From: Rafał Miłecki This adds support for install-overlay define. When used in package it allows installing files to a special directory that gets copied to the root when installing it. It allows overwriting files provided by other packages. Signed-off-by: Rafał Miłecki --- include/package

Re: [LEDE-DEV] replacing files in base system from a package?

2016-12-01 Thread Rafał Miłecki
On 1 December 2016 at 12:48, Zefir Kurtisi wrote: > On 12/01/2016 08:28 AM, Rafał Miłecki wrote: >> So you still may end up with base-files installed and /etc/banner >> being different. If you re-install that package, e.g. >> opkg install base-files*.ipk >> you'll

Re: [LEDE-DEV] replacing files in base system from a package?

2016-11-30 Thread Rafał Miłecki
On 28 November 2016 at 09:33, Zefir Kurtisi wrote: > We had the approach you describe for a long time (company-basefiles adding to > and > overwriting files in base-files package), but this does not work any more. > With > recent build-system changes you can't have the same rootfs file in two >

Re: [LEDE-DEV] make -j 4: race between Image/Prepare and device images?

2016-11-29 Thread Rafał Miłecki
On 25 October 2016 at 10:31, Rafał Miłecki wrote: > I just discovered why I was getting some crazy results during my various > kernel > tests. It seems that LEDE doesn't rebuild images as expected with make -j N. > > I think that some/all images may be generated before Image/

Re: [LEDE-DEV] replacing files in base system from a package?

2016-11-24 Thread Rafał Miłecki
On 25 November 2016 at 08:14, Rafał Miłecki wrote: > I think a perfect model for organization/company that wants to be LEDE > friendly would be to: > 1) Ask them for complete LEDE-upstream support for their device > 2) Handle all modifications using an own feed with their packages &

Re: [LEDE-DEV] replacing files in base system from a package?

2016-11-24 Thread Rafał Miłecki
On 16 October 2016 at 01:04, Jo-Philipp Wich wrote: > let me introduce a not strictly new way but another heavily under > documented buildroot feature which you can use to implement custom > modifications to packages which do not require source code edits. > > For every processed package Makefile,

Re: [LEDE-DEV] [RFC] brcm47xx: bump kernel to 4.4

2016-11-23 Thread Rafał Miłecki
On 22 November 2016 at 18:36, wrote: >> On 25 October 2016 at 9:41, Rafał Miłecki wrote: >> Anyway I finally debugged this local vs. buildbot difference to the >> CONFIG_KERNEL_KALLSYMS. Images from buildbot have this symbol enabled >> which slightly increases kernel

[LEDE-DEV] [PATCH] firmware-utils: tplink-safeloader: keep per-device info on trailing char

2016-11-19 Thread Rafał Miłecki
From: Rafał Miłecki Recent refactoring introduced a regression. It ignored second argument of make_support_list function which was originally true for C2600. The new generic build_image function always passes false. This patch allows specifying trailing char in a device specific info. It also

[LEDE-DEV] [PATCH] firmware-utils: replace md5 code with Alexander Peslyak's implementation

2016-11-19 Thread Rafał Miłecki
From: Rafał Miłecki Our current implementation is pretty old and uses some pre-standard/old ANSI C style that triggers warnings like: warning: call to function 'MD5_Init' without a real prototype [-Wunprototyped-calls] This is caused by declarations specified in a following way: src/

Re: [LEDE-DEV] Some Broadcom wifi chipset datasheets released by Cypress

2016-11-17 Thread Rafał Miłecki
On 17 November 2016 at 21:41, Alberto Bursi wrote: > Some broadcom wifi chipsets datasheets are being released free of NDA by > a company called Cypress that acquired the IoT division of Broadcom. > > (...) > > datasheets here > http://www.cypress.com/search/all?f[0]=meta_type%3Atechnical_document

Re: [LEDE-DEV] [PATCH] scripts/getver.sh: use --count for git rev-list to count commits

2016-11-17 Thread Rafał Miłecki
On 17 November 2016 at 10:56, Jonas Gorski wrote: > On 17 November 2016 at 10:10, Rafał Miłecki wrote: >> On 17 November 2016 at 10:05, Rafał Miłecki wrote: >>> On 17 November 2016 at 09:57, Jo-Philipp Wich wrote: >>>> do you happen to know whether rev-list -

Re: [LEDE-DEV] [PATCH] scripts/getver.sh: use --count for git rev-list to count commits

2016-11-17 Thread Rafał Miłecki
On 17 November 2016 at 10:05, Rafał Miłecki wrote: > On 17 November 2016 at 09:57, Jo-Philipp Wich wrote: >> do you happen to know whether rev-list --count is available in all Git >> versions? > > I found it mentioned in various posts from 2012 so it should be well settled.

Re: [LEDE-DEV] [PATCH] scripts/getver.sh: use --count for git rev-list to count commits

2016-11-17 Thread Rafał Miłecki
On 17 November 2016 at 09:57, Jo-Philipp Wich wrote: > do you happen to know whether rev-list --count is available in all Git > versions? I found it mentioned in various posts from 2012 so it should be well settled. -- Rafał ___ Lede-dev mailing list

[LEDE-DEV] [PATCH] scripts/getver.sh: treat all commits as local if can't find upstream

2016-11-16 Thread Rafał Miłecki
From: Rafał Miłecki If something goes wrong and script can't find upstream revision it will return something like: r2220 which looks like a valid upstream revision 2220. We cant' distinguish it from e.g. 2200 upstream commits and 20 local ones. The new format still provides revision

[LEDE-DEV] [PATCH] scripts/getver.sh: use --count for git rev-list to count commits

2016-11-16 Thread Rafał Miłecki
From: Rafał Miłecki It should be faster than printing them and piping to the wc. Signed-off-by: Rafał Miłecki --- scripts/getver.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/getver.sh b/scripts/getver.sh index e718485..9b84602 100755 --- a/scripts

Re: [LEDE-DEV] [PATCH] kernel: update kernel 4.4 to version 4.4.32

2016-11-16 Thread Rafał Miłecki
On 16 November 2016 at 22:50, wrote: > apm821xx/patches-4.4/804-usb-dwc2-add-amcc-usb-otg-405ex.patch: > Here, you add more context around the actual patch, which I completely > missed > since it applies fine. That patch was /wrong/ in the first place, a proper refresh should fix that c

Re: [LEDE-DEV] [PATCH] ar71xx: fix drivers/mtd/nand/ar934x_nfc.c

2016-11-16 Thread Rafał Miłecki
On 16 November 2016 at 12:41, wrote: >> patch fails to apply to current HEAD. could you check/resend it please > > Just checked again on a new git clone - everything is fine here. I can confirm it applies cleanly $ curl https://patchwork.ozlabs.org/patch/695452/mbox/ | git am Applying: ar71xx: f

[LEDE-DEV] [PATCH RFC] scripts/getver: append '+' char if there are local modifications

2016-11-15 Thread Rafał Miłecki
From: Rafał Miłecki We already count amount of local git commits. This allows realizing if user did any local changes based on his boot log or openwrt_release. Signed-off-by: Rafał Miłecki --- scripts/getver.sh | 4 1 file changed, 4 insertions(+) diff --git a/scripts/getver.sh b

Re: [LEDE-DEV] How LEDE knows when to "reinstall" base-files (after revision change)?

2016-11-15 Thread Rafał Miłecki
On 3 November 2016 at 17:51, Rafał Miłecki wrote: > I'm trying to understand how REVISION variable and getver.sh work. There is > this > nice feature: whenever a new git commit appears, getver.sh is used to > calculate > new revision and it's used for /etc/openwrt_vers

Re: [LEDE-DEV] failed interentconnectitity detection - auto reboot device ?

2016-11-14 Thread Rafał Miłecki
On 14 November 2016 at 12:20, Dennis Schneck wrote: > Have the issue that often the WAN Interface > lost connection / IP Address. (down and up of interface did not work) > If i reboot the Device it runs. What exact commands did you execute? Have you tried restarting network or dnsmasq instead of

Re: [LEDE-DEV] adding LEDE support for board DLINK DWR-512-B

2016-11-13 Thread Rafał Miłecki
On 13 November 2016 at 23:44, Giuseppe Lippolis wrote: > I add it in: > https://github.com/lede-project/source/pulls > "ramips: Add device DLINK DWR-512-B " Hey Giuseppe, it looks nice! Thanks! I don't know if it was ever pointed before, but this would be nice to have DTS files clearly licensed.

[LEDE-DEV] [PATCH RFC] osafeloader: new util for extracting partitions from SafeLoader

2016-11-13 Thread Rafał Miłecki
From: Rafał Miłecki SafeLoader is image format used by some TP-LINK devices. This tool allows extracting selected partitions out of it. It can be used for sysupgrade. Signed-off-by: Rafał Miłecki --- package/utils/osafeloader/Makefile | 38 package/utils/osafeloader/src

Re: [LEDE-DEV] patch for dwr-512 support

2016-11-13 Thread Rafał Miłecki
On 13 November 2016 at 17:59, Giuseppe Lippolis wrote: > Dear all, > I’m sending to the community the following patch to support the dlink > dwr-512. Please use a proper commit message (with target as a prefix) & description. Your singed-off-by is required. I also noticed your patch is white spac

[LEDE-DEV] [PATCH 1/2] firmware-utils: tplink-safeloader: add struct device_info

2016-11-13 Thread Rafał Miłecki
From: Rafał Miłecki This struct stores all device specific info which allows making do_eap function more generic. Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/tplink-safeloader.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/tools

[LEDE-DEV] [PATCH 2/2] firmware-utils: tplink-safeloader: use one function for generating images

2016-11-13 Thread Rafał Miłecki
From: Rafał Miłecki Thanks to the struct device_info we can now use one unified function. Signed-off-by: Rafał Miłecki --- tools/firmware-utils/src/tplink-safeloader.c | 108 +++ 1 file changed, 29 insertions(+), 79 deletions(-) diff --git a/tools/firmware-utils/src

Re: [LEDE-DEV] [PATCH] kernel/mtd: Add support for Macronix mx25u25635f, used in Archer C2600 v1.1

2016-11-07 Thread Rafał Miłecki
On 31 May 2016 at 10:04, A. Benz wrote: > On 05/31/16 04:56, Rafał Miłecki wrote: >> >> On 30 May 2016 at 11:52, Ash Benz wrote: >>> >>> Signed-off-by: Ash Benz >>> --- >>> .../475-mtd-spi-nor-add-macronix-mx25u25635f.patch | 1

Re: [LEDE-DEV] How do you develop (compile) LEDE efficiently?

2016-11-07 Thread Rafał Miłecki
On 7 November 2016 at 10:58, Russell Senior wrote: >>>>>> "Rafał" == Rafał Miłecki writes: > > Rafał> On 7 November 2016 at 00:40, Russell Senior > wrote: >>> I have a 16-core build box which I connect to over ssh. I use scp to >>&g

Re: [LEDE-DEV] How do you develop (compile) LEDE efficiently?

2016-11-07 Thread Rafał Miłecki
On 7 November 2016 at 09:46, Baptiste Jonglez wrote: > On Mon, Nov 07, 2016 at 06:23:49AM +0100, Rafał Miłecki wrote: >> On 7 November 2016 at 00:40, Russell Senior >> wrote: >> > I have a 16-core build box which I connect to over ssh. I use scp to >> >

Re: [LEDE-DEV] How do you develop (compile) LEDE efficiently?

2016-11-06 Thread Rafał Miłecki
On 7 November 2016 at 02:18, Alberto Bursi wrote: > On 11/06/2016 09:24 PM, Rafał Miłecki wrote: >> So far I was always using my notebook for the development. My >> requirements were Intel i7 quad core + AMD GPU. I was using some >> Samsung but it's GPU has died and

Re: [LEDE-DEV] How do you develop (compile) LEDE efficiently?

2016-11-06 Thread Rafał Miłecki
On 7 November 2016 at 00:40, Russell Senior wrote: > I have a 16-core build box which I connect to over ssh. I use scp to > move images to devices. I have a testbed with ethernet connections to > the build box and serial consoles on most if not all of them. But what about development with modif

[LEDE-DEV] How do you develop (compile) LEDE efficiently?

2016-11-06 Thread Rafał Miłecki
Hey, So far I was always using my notebook for the development. My requirements were Intel i7 quad core + AMD GPU. I was using some Samsung but it's GPU has died and I can't replace it (stupid 216-0811000 chipset). I'm looking for a new notebook, but I can't find anything with i7 quad core + AMD

Re: [LEDE-DEV] New CT ath10k firmware is available

2016-11-04 Thread Rafał Miłecki
On 4 November 2016 at 10:14, liudengf...@kunteng.org wrote: > Hi, Rafal > I am confused by "please don't drop mailing list when replying", which > means I should cc LEDE Development List or > not? 1) Yes, you should Cc mailing list 2) You *shouldn't* send HTML e-mails, we don't like that __

Re: [LEDE-DEV] New CT ath10k firmware is available

2016-11-04 Thread Rafał Miłecki
On 4 November 2016 at 03:51, Ben Greear wrote: > I don't really have time to work specifically on LEDE much. > > But, if someone else takes care of the rest, then my firmware > can hopefully work well on its radio. liudengfeng please don't drop mailing list when replying -- Rafał _

Re: [LEDE-DEV] How LEDE knows when to "reinstall" base-files (after revision change)?

2016-11-03 Thread Rafał Miłecki
On 11/03/2016 06:44 PM, Jo-Philipp Wich wrote: I think its not actually noticing all git commits but rather most of them. The base-files package registers some explicit file depends using: PKG_FILE_DEPENDS:=$(PLATFORM_DIR)/ $(GENERIC_PLATFORM_DIR)/base-files/ which means that its stamp files

[LEDE-DEV] How LEDE knows when to "reinstall" base-files (after revision change)?

2016-11-03 Thread Rafał Miłecki
From: Rafał Miłecki I'm trying to understand how REVISION variable and getver.sh work. There is this nice feature: whenever a new git commit appears, getver.sh is used to calculate new revision and it's used for /etc/openwrt_version. LEDE never misses an update of git commit. Also

[LEDE-DEV] [PATCH] scripts/feeds: use 10 chars for feed name column width

2016-11-02 Thread Rafał Miłecki
From: Rafał Miłecki It's always hard to find a reasonable width that will make everyone happy. This one at least makes "telephony" (one of default feeds) name fit the column and hopefully isn't too big. Signed-off-by: Rafał Miłecki --- scripts/feeds | 2 +- 1 file change

[LEDE-DEV] [PATCH] scripts/feeds: use git rev-parse for getting revision

2016-11-02 Thread Rafał Miłecki
From: Rafał Miłecki It provides simpler output so we don't need extra head and cut commands. Signed-off-by: Rafał Miłecki --- scripts/feeds | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/feeds b/scripts/feeds index 481eb9b..81cf1f0 100755 --- a/scripts/

Re: [LEDE-DEV] [PATCH] kernel: update kernel 4.4 to version 4.4.30

2016-11-02 Thread Rafał Miłecki
On 2 November 2016 at 11:12, wrote: > If so, wouldn't it be clearer (for people like me :) ) if there were two > seperate patches (i.e. one for kernel update+refreshes itself and one for the > internal > refreshes (or refreshes that have been missed in previous updates) )? It could be nice to h

[LEDE-DEV] [PATCH] scripts/feeds: display "X" as revision of uninitialized feeds

2016-11-02 Thread Rafał Miłecki
From: Rafał Miłecki So far we were displaying "local" which could be misinterpreted. It wasn't possible e.g. to say if src-link feed was initialized or not. Hopefully "X" makes (a bit) more sense. Signed-off-by: Rafał Miłecki --- scripts/feeds | 2 +- 1 file c

Re: [LEDE-DEV] [PATCH] TPLINK MR3420v3 support

2016-11-01 Thread Rafał Miłecki
On 1 November 2016 at 11:17, Jacek Trzcinski wrote: > The patch adds support for TPLINK MR3420v3 with the extra kernel module > for non gpio controlled LEDs. > > The USB modem functionality has not been tested yet but seems to be ok > since core of the code was taken from TL-MR3420v2 and TL-WR841N

Re: [LEDE-DEV] [PATCH V2] apm821xx: fix USB LED trigger for WNDR4700

2016-10-28 Thread Rafał Miłecki
On 28 October 2016 at 12:46, Christian Lamparter wrote: > On Friday, October 28, 2016 12:40:01 PM CEST Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> The old usbdev trigger never supported assigning more than 1 USB port. >> This code we got was never working as ex

[LEDE-DEV] [PATCH V2] apm821xx: fix USB LED trigger for WNDR4700

2016-10-28 Thread Rafał Miłecki
From: Rafał Miłecki The old usbdev trigger never supported assigning more than 1 USB port. This code we got was never working as expected and it was missing 2 more ports. Switch to usbport to have LED working with all ports. Signed-off-by: Rafał Miłecki --- V2: Add 2 extra ports that were

Re: [LEDE-DEV] [PATCH] apm821xx: fix USB LED trigger for WNDR4700

2016-10-28 Thread Rafał Miłecki
On 22 October 2016 at 18:10, Christian Lamparter wrote: > On Saturday, October 22, 2016 11:22:35 AM CEST Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> The old usbdev trigger never supported assigning more than 1 USB port. >> This code we got was never working as

Re: [LEDE-DEV] [PATCH V2 0/7] add support for D-Link DAP-2695 rev. A1

2016-10-26 Thread Rafał Miłecki
On 21 October 2016 at 17:40, Stijn Tintel wrote: > On 21-10-16 18:34, Stijn Tintel wrote: >> This patch series adds support for D-Link DAP-2695 rev. A1. >> >> > FYI, this series is also available in my staging tree at > https://git.lede-project.org/?p=lede/stintel/staging.git;a=shortlog;h=refs/hea

[LEDE-DEV] [PATCH packages] lighttpd: update to 1.4.42

2016-10-25 Thread Rafał Miłecki
From: Rafał Miłecki This release fixes bugs introduced in 1.4.40 and 1.4.41. Signed-off-by: Rafał Miłecki --- Hi Michael, Since we use the same version in for-15.05 branch, could you backport this patch there as well, please? --- net/lighttpd/Makefile | 4 ++-- 1 file changed, 2 insertions

Re: [LEDE-DEV] [RFC] brcm47xx: bump kernel to 4.4

2016-10-25 Thread Rafał Miłecki
On 25 October 2016 at 10:00, Jo-Philipp Wich wrote: > did you ever test local builds with all additional kmods (including all > kmods from feeds) enabled as ? I guess this will bump the kernel > size somewhat due to additional subsystems which are getting enabled. No, I never expected extra kmod

<    1   2   3   4   5   >