Re: [LEDE-DEV] [PATCH] kernel: Enable fadvise on older kernels.

On Fri, 2017-11-17 at 09:30 +0100, John Crispin wrote: > > On 12/11/17 01:50, Rosen Penev wrote: > > Any chance of this being backported to LEDE stable? > > should be ok, send a patch please > Not quite sure what you mean. The patch applies cleanly. I'll resend one based on the lede-17.01

Re: [LEDE-DEV] [PATCH 4/4] otrx: fix memory leak in otrx_create_append_zeros

On Thu, 2017-11-16 at 10:15 +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > A "free" call was missing after allocating a buffer. > > Signed-off-by: Rafał Miłecki > --- > package/utils/otrx/src/otrx.c | 3 +++ > 1 file changed, 3 insertions(+) > >

Re: [LEDE-DEV] [PATCH 3/4] otrx: print and return errno if fopen fails

On Thu, 2017-11-16 at 10:15 +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > Signed-off-by: Rafał Miłecki > --- > package/utils/otrx/src/otrx.c | 22 -- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git

Re: [LEDE-DEV] [PATCH] procd: Remove unnecessary memset calls.

Tested compile size difference. Saves 32 bytes. ¯\_(ツ)_/¯ On Tue, 2017-11-07 at 12:05 -0800, Rosen Penev wrote: > Changes allocation to calloc and {} as needed. > > Signed-off-by: Rosen Penev > --- > inittab.c | 6 ++ > plug/hotplug.c | 7 ++- > 2 files changed,

Re: [LEDE-DEV] [PATCH] ubox: Remove unnecessary memset calls.

Just retested. This patch lowers size on x86 from 52144 to 52072 On Tue, 2017-11-07 at 12:22 -0800, Rosen Penev wrote: > Change to calloc instead. Less verbose. > > Signed-off-by: Rosen Penev > --- > log/syslog.c | 4 +--- > lsbloader.c | 3 +-- > 2 files changed, 2

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

On Wed, 2017-11-08 at 21:17 +0100, Arjen de Korte wrote: > Citeren Rosen Penev : > > > Less verbose. > > And uses a GCC extension which makes it less portable. ISO C > forbids > empty initializer braces [1]. See for yourself by adding the > -pedantic > flag to your CFLAGS.

Re: [LEDE-DEV] [PATCH] kernel: Switch to No-op for the default scheduler.

On Wed, 2017-11-08 at 10:27 +0100, Felix Fietkau wrote: > On 2017-11-08 07:18, John Crispin wrote: > > j > > > > > > On 07/11/17 19:41, Rosen Penev wrote: > > > most users don't have multithreaded workloads though. > > > > > > On Mon, Nov 6, 2017 at 4:43 PM, Dave Taht wrote: > >

Re: [LEDE-DEV] [PATCH] procd: Remove unnecessary memset calls.

On Wed, 2017-11-08 at 11:57 +0100, Paul Oranje wrote: > Both memset() and calloc() have highly optimised implementations, so > the expected gains with this patch for the allocation of zeroed > memory will be small at best. As this patch does not fix a bug: why > is the change "needed" ? > Style

Re: [LEDE-DEV] [PATCH] kernel: Switch to No-op for the default scheduler.

I haven't made any benchmarks, no. The router that I use is the Turris Omnia which has pretty fast eMMC instead of NOR, so they probably wouldn't be useful to compare to the NOR based stuff. LEDE tends not to write to flash but does write to RAM, which I think is still impacted by the choice of

Re: [LEDE-DEV] [PATCH] ag71xx: Add back napi_complete_done.

Well that's embarasing :). Forgot to add _done. Not enough coffee. On Tue, 2017-10-17 at 22:16 +0100, Kevin Darbyshire-Bryant wrote: > > On 17/10/17 21:52, ros...@gmail.com wrote: > > I'll take your word for it since I have no hardware to test on. > > I'd say it has a huge impact on performance

Re: [LEDE-DEV] [PATCH] ag71xx: Add back napi_complete_done.

I'll take your word for it since I have no hardware to test on. On Tue, 2017-10-17 at 21:44 +0200, Felix Fietkau wrote: > On 2017-10-17 18:51, Rosen Penev wrote: > > This should have no impact on the recently discovered performance > > regression. > > > > Signed-off-by: Rosen Penev

Re: [LEDE-DEV] [PATCH] kernel: enable CONFIG_ADVISE_SYSCALLS

I don't see a change. I still get 6479872 for vmlinux. On Sat, 2017-10-14 at 18:05 -0700, Florian Fainelli wrote: > Le 10/14/17 à 17:07, Rosen Penev a écrit : > > Without this, posix_[fm]advise does not work. This causes issues > > with btrfs-progs, which uses fadvise to drop caches. > > What's

[LEDE-DEV] ramips: Error in RXCSUM setting? Or, performance improvement.

I received my new mt7621 toy today and noticed something interesting when playing with ethtool. I use ethtool to remove most offloads in the driver as offloads increase latency. But something caught my eye. If I run "ethtool -K eth0 rx off", iperf performance improves from ~350 to ~450. I ran

Re: [LEDE-DEV] [PATCH] ar71xx: Add GRO support to ag71xx

After a bit more research, it turns out this change is really boring. Eric Dumazet did this for many ethernet drivers early this year. As far as TSO goes, no idea how to even go about that. As an interesting side note, TSO support broke mv643xx_eth for a while. On Sun, 2017-09-03 at 19:10 -0700,

Re: [LEDE-DEV] [PATCH] ar71xx: Add GRO support to ag71xx

That's...way better than I expected given how minimal my changes are. For some context, the ag71xx driver is special in that it does not seem to do any hardware offloading to the NIC. As far as I understand this change, GRO takes 1500 MTU packets and packs then into 64Kb blocks which the kernel

Re: [LEDE-DEV] b43 support for AC chipsets like BCM4360 and BCM4352?

Based on kernel activity, this driver is not under active development. And yes, avoid. On Tue, 2017-08-01 at 00:42 +0200, Baptiste Jonglez wrote: > Hi, > > As far as I can tell, the b43 driver does not support AC chipsets > like > BCM4352, BCM4360, BCM4366. Support for these is marked BROKEN >

Re: [LEDE-DEV] Generic way to disable Generic Receive Offload (GRO)

Hmm how about driver side? looking at the source code, register_netdevice enables GSO and GRO by default. Any way to explicitly disable it? On Mon, 2017-05-29 at 14:34 -0700, Florian Fainelli wrote: > Le 05/29/17 à 13:55, ros...@gmail.com a écrit : > > So LEDE is using fq_codel by default. On the

Re: [LEDE-DEV] LEDE/OpenWrt and Open Compute Project (OCP)

On Wed, 2017-05-03 at 10:37 -0400, Abylay Ospan wrote: > Hello All, > > I'm working on Facebook's Open Compute CBW (Campus, Branch, and > Wireless) project [1]. OCP CBW mission is: > "Closed wireless and branch networking equipment have served well in > the past but now is the time to democratize

Re: [LEDE-DEV] MT7621 support Jumbo frames

Probably was not in the interest of the driver writers. Based on the copyrights though, it's mostly LEDE/OpenWRT developers. Try modifying the code to test if jumbo frames work. On Sun, 2017-04-09 at 21:20 +0200, Jaap Buurman wrote: > Hello all, > > I found the message below in a conversation