Re: [LEDE-DEV] [PATCH] dnsmasq: write atomic config file

2016-06-13 Thread Kevin Darbyshire-Bryant
On 13/06/16 14:50, Felix Fietkau wrote: On 2016-06-13 15:40, Jo-Philipp Wich wrote: Hi Ulrich, wouldn't some protection with "flock" or similar be better in this case in order to serialize config generation and restart tasks? I don't think we should be using flock. We should find a way to

Re: [LEDE-DEV] [PATCH] dnsmasq: write atomic config file

2016-06-13 Thread Jo-Philipp Wich
Hi Ulrich, wouldn't some protection with "flock" or similar be better in this case in order to serialize config generation and restart tasks? ~ Jo ___ Lede-dev mailing list Lede-dev@lists.infradead.org

[LEDE-DEV] [PATCH] dnsmasq: write atomic config file

2016-06-13 Thread Ulrich Weber
multiple invocation of dnsmasq script (e.g. by procd and hotplugd) might cause procd to restart dnsmasq with an incomplete config file. Config file generation might take quite a long time on larger configs due ubus calls for each listening interface... Signed-off-by: Ulrich Weber