Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread Bastian Bittorf
* Bastian Bittorf [22.11.2016 23:47]: > answer myself: CONFIG_TARGET_ROOTFS_PARTSIZE is unset? > > see 'Image/Build/squashfs' in 'uml/Image/Makefile' indeed, it works when i set it manually and i can boot into UML: root@uml:/ df -h FilesystemSize Used

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread Bastian Bittorf
* Bastian Bittorf [22.11.2016 23:01]: > * Felix Fietkau [22.11.2016 22:42]: > > > here the build-error with "inodes full". > > > (the same images works, if i just raise the inodes to 2048) > > Try disabling the ext4 image via make menuconfig. > > sorry, does not

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread Felix Fietkau
On 2016-11-22 18:04, Felix Fietkau wrote: > On 2016-11-22 17:57, David Lang wrote: >> On Tue, 22 Nov 2016, Felix Fietkau wrote: >> >>> On 2016-11-22 17:48, David Lang wrote: On Tue, 22 Nov 2016, Felix Fietkau wrote: > On 2016-11-22 17:43, David Lang wrote: >> On Tue, 22 Nov

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread Felix Fietkau
On 2016-11-22 17:57, David Lang wrote: > On Tue, 22 Nov 2016, Felix Fietkau wrote: > >> On 2016-11-22 17:48, David Lang wrote: >>> On Tue, 22 Nov 2016, Felix Fietkau wrote: >>> On 2016-11-22 17:43, David Lang wrote: > On Tue, 22 Nov 2016, Felix Fietkau wrote: > >>> On a 16M

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread David Lang
On Tue, 22 Nov 2016, Felix Fietkau wrote: On 2016-11-22 17:48, David Lang wrote: On Tue, 22 Nov 2016, Felix Fietkau wrote: On 2016-11-22 17:43, David Lang wrote: On Tue, 22 Nov 2016, Felix Fietkau wrote: On a 16M filesystem, we probably want to use a 1K block size and have an inode for

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread Felix Fietkau
On 2016-11-22 17:43, David Lang wrote: > On Tue, 22 Nov 2016, Felix Fietkau wrote: > >>> On a 16M filesystem, we probably want to use a 1K block size and have an >>> inode >>> for every couple of blocks. >> I'd say on a 16M filesystem we probably want to use squashfs+ext4 >> instead of plain

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread Felix Fietkau
On 2016-11-22 17:48, David Lang wrote: > On Tue, 22 Nov 2016, Felix Fietkau wrote: > >> On 2016-11-22 17:43, David Lang wrote: >>> On Tue, 22 Nov 2016, Felix Fietkau wrote: >>> > On a 16M filesystem, we probably want to use a 1K block size and have an > inode > for every couple of

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread David Lang
On Tue, 22 Nov 2016, Felix Fietkau wrote: On 2016-11-22 17:43, David Lang wrote: On Tue, 22 Nov 2016, Felix Fietkau wrote: On a 16M filesystem, we probably want to use a 1K block size and have an inode for every couple of blocks. I'd say on a 16M filesystem we probably want to use

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread David Lang
On Tue, 22 Nov 2016, Felix Fietkau wrote: On a 16M filesystem, we probably want to use a 1K block size and have an inode for every couple of blocks. I'd say on a 16M filesystem we probably want to use squashfs+ext4 instead of plain ext4 and avoid the inode issue altogether. I'm not sure I

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread Felix Fietkau
On 2016-11-22 15:41, David Lang wrote: > changing the blocksize doesn't really address the problem of too few inodes, > except indirectly in that the default number of inodes is calculated from the > number of blocks on the filesystem. > > In the case of LEDE, we tend to have fewer large files

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread David Lang
On Tue, 22 Nov 2016, Jo-Philipp Wich wrote: 1) detect via makefile if PARTITION is small and autoadjust BLOCKSIZE (if not given) iirc the blocksize setting is a choice menu, so it is always defined. 2) set BLOCKSIZE default to 1K via x86/UML-Makefile It was explicitly raised to 4k for x86

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread Jo-Philipp Wich
Hi, > 1) > detect via makefile if PARTITION is small and autoadjust BLOCKSIZE > (if not given) iirc the blocksize setting is a choice menu, so it is always defined. > 2) > set BLOCKSIZE default to 1K via x86/UML-Makefile It was explicitly raised to 4k for x86 to reduce wear on MMC storage

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread Bastian Bittorf
* Jo-Philipp Wich [22.11.2016 10:08]: > a huge block size on small partition simply makes no sense. If you > already configure 16MB partitions then you can as well change block size > from 4K to 1K or 512B as well since you're deviating from the defaults > anyway. > > Having

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-22 Thread Jo-Philipp Wich
Hi, a huge block size on small partition simply makes no sense. If you already configure 16MB partitions then you can as well change block size from 4K to 1K or 512B as well since you're deviating from the defaults anyway. Having different code paths for small and huge partitions is annoying and

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-21 Thread John Crispin
On 21/11/2016 13:56, John Crispin wrote: > NAK, please dont fiddle with inode counts. change the blocksize or the > default mkfs_ext4 uses. > > John https://git.lede-project.org/?p=project/make_ext4fs.git;a=blob;f=make_ext4fs.c#l281 > > On 12/11/2016 09:26, Bastian Bittorf wrote: >> A

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-21 Thread John Crispin
NAK, please dont fiddle with inode counts. change the blocksize or the default mkfs_ext4 uses. John On 12/11/2016 09:26, Bastian Bittorf wrote: > A rootfs typically has lots of small files, so the default > counter with 1024 inodes for 16 megabytes partition size can > be too restrictive

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-12 Thread Bastian Bittorf
* Bastian Bittorf [12.11.2016 09:54]: > +# doubles the default inode amount > +INODES=$(shell echo $$(($(CONFIG_TARGET_ROOTFS_PARTSIZE)*64*2))) > E2SIZE=$(shell echo $$(($(CONFIG_TARGET_ROOTFS_PARTSIZE)*1024*1024))) bye the way: i mimic'ed the existing style, but is'nt this too

[LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

2016-11-12 Thread Bastian Bittorf
A rootfs typically has lots of small files, so the default counter with 1024 inodes for 16 megabytes partition size can be too restrictive and leads to e.g. root@box:/ touch /etc/config/test touch: /etc/config/test: No space left on device the solution is to just double the amount of inodes