Re: [LEDE-DEV] [PATCH] uci: decrement package's section counter when free'ing sections

2016-09-13 Thread Reiner Herrmann
On Tue, Sep 13, 2016 at 10:52:43PM +0200, Felix Fietkau wrote: > On 2016-09-13 16:25, Reiner Herrmann wrote: > > The counter is incremented during section allocation, but never > > decremented. > NACK. n_section is used for hashing only, decrementing it here probably > makes collisions for anonymou

Re: [LEDE-DEV] [PATCH] uci: decrement package's section counter when free'ing sections

2016-09-13 Thread Felix Fietkau
On 2016-09-13 16:25, Reiner Herrmann wrote: > The counter is incremented during section allocation, but never > decremented. > > Signed-off-by: Reiner Herrmann > --- > list.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/list.c b/list.c > index 321861c..a2be150 100644 > --- a/list.c

[LEDE-DEV] [PATCH] uci: decrement package's section counter when free'ing sections

2016-09-13 Thread Reiner Herrmann
The counter is incremented during section allocation, but never decremented. Signed-off-by: Reiner Herrmann --- list.c | 1 + 1 file changed, 1 insertion(+) diff --git a/list.c b/list.c index 321861c..a2be150 100644 --- a/list.c +++ b/list.c @@ -213,6 +213,7 @@ uci_free_section(struct uci_secti