Re: [LEDE-DEV] [PATCH mountd] filesystem mount options in uci config

2016-06-13 Thread John Crispin
On 13/06/2016 09:47, Olivier Hardouin wrote: > Hi John, > > Thanks for your comment. > You're right, I need to add some check before getting uci options. > > Regarding the fs name, I propose to use per default the same driver name > as defined in fs_names (and not have the fstype parameter in u

Re: [LEDE-DEV] [PATCH mountd] filesystem mount options in uci config

2016-06-12 Thread John Crispin
Hi, comment inline. On 10/06/2016 11:18, olivier.hardo...@gmail.com wrote: > Move (previously hardcoded) mount option to UCI to allow different > configuration > like charset (utf-8 or iso) and filesystem driver (if alternative ones are > used). > The fs names are changed in lowercase to compl

[LEDE-DEV] [PATCH mountd] filesystem mount options in uci config

2016-06-10 Thread olivier . hardouin
Move (previously hardcoded) mount option to UCI to allow different configuration like charset (utf-8 or iso) and filesystem driver (if alternative ones are used). The fs names are changed in lowercase to comply with UCI general naming. Signed-off-by: Olivier Hardouin --- mount.c | 69