Re: [LEDE-DEV] [PATCH v2] dnsmasq: also write /tmp/resolv.conf when UCI dhcp.dnsmasq.noresolv is '1'

2017-05-15 Thread Bastian Bittorf
* Bastian Bittorf [15.05.2017 09:27]: > > + [ "$noreolv" -eq '1' -o "$resolvfile" = "/tmp/resolv.conf.auto" ] && { > > thanks for the patch! > > please test for 'bool_true' not for 1 sorry for the noise, this is already normalized by config_get_bool() - so testing for 0 or 1 is fine. bye, ba

Re: [LEDE-DEV] [PATCH v2] dnsmasq: also write /tmp/resolv.conf when UCI dhcp.dnsmasq.noresolv is '1'

2017-05-15 Thread Bastian Bittorf
* Paul Oranje [15.05.2017 09:08]: > fixes FS#785 > v1: write /tmp/resolv.conf also when nosolv is true > v2: also change guard in dnsmasq_stop() routine > > Signed-off-by: Paul Oranje > --- > package/network/services/dnsmasq/files/dnsmasq.init | 4 ++-- > 1 file changed, 2 insertions(+), 2 dele

Re: [LEDE-DEV] [PATCH v2] dnsmasq: also write /tmp/resolv.conf when UCI dhcp.dnsmasq.noresolv is '1'

2017-05-14 Thread Paul Oranje
Please ignore, contains a syntax error. new version will follow, sorry, Paul > Op 14 mei 2017, om 13:14 heeft Paul Oranje het volgende > geschreven: > > fixes FS#785 > v1: write /tmp/resolv.conf also when nosolv is true > v2: also change guard in dnsmasq_stop() routine > > Signed-off-by: Pau

[LEDE-DEV] [PATCH v2] dnsmasq: also write /tmp/resolv.conf when UCI dhcp.dnsmasq.noresolv is '1'

2017-05-14 Thread Paul Oranje
fixes FS#785 v1: write /tmp/resolv.conf also when nosolv is true v2: also change guard in dnsmasq_stop() routine Signed-off-by: Paul Oranje --- package/network/services/dnsmasq/files/dnsmasq.init | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/network/services/dns