Re: [LEDE-DEV] [PATCH v2] ramips: Add support for Sanlinking D240

2017-02-03 Thread Kristian Evensen
On Fri, Feb 3, 2017 at 12:52 PM, Piotr Dymacz wrote: > As this is a general problem and I'm sure it's going to grow in time, > maybe we should start thinking about different approach for naming > boards in system, dts files and image filenames? Including there also > the manufacturer name would be

Re: [LEDE-DEV] [PATCH v2] ramips: Add support for Sanlinking D240

2017-02-03 Thread Piotr Dymacz
Hi Mathias, 2017-02-03 12:13 GMT+01:00 Mathias Kresin : > 2017-02-03 11:49 GMT+01:00 Kristian Evensen : >> Hi >> >> On Fri, Feb 3, 2017 at 11:02 AM, Piotr Dymacz wrote: >>> Hi Kristian, >>> >>> My two cents: the general convention for board name is to not include >>> the manufacturer name (Sanlin

Re: [LEDE-DEV] [PATCH v2] ramips: Add support for Sanlinking D240

2017-02-03 Thread Rafał Miłecki
On 3 February 2017 at 09:54, Kristian Evensen wrote: > diff --git a/target/linux/ramips/dts/SANLINKING-D240.dts > b/target/linux/ramips/dts/SANLINKING-D240.dts > new file mode 100644 > index 000..888f5aa > --- /dev/null > +++ b/target/linux/ramips/dts/SANLINKING-D240.dts > @@ -0,0 +1,120 @@ >

Re: [LEDE-DEV] [PATCH v2] ramips: Add support for Sanlinking D240

2017-02-03 Thread Mathias Kresin
2017-02-03 11:49 GMT+01:00 Kristian Evensen : > Hi > > On Fri, Feb 3, 2017 at 11:02 AM, Piotr Dymacz wrote: >> Hi Kristian, >> >> My two cents: the general convention for board name is to not include >> the manufacturer name (Sanlinking here). >> As you can see, (almost) all other boards follow th

Re: [LEDE-DEV] [PATCH v2] ramips: Add support for Sanlinking D240

2017-02-03 Thread Kristian Evensen
Hi On Fri, Feb 3, 2017 at 11:02 AM, Piotr Dymacz wrote: > Hi Kristian, > > My two cents: the general convention for board name is to not include > the manufacturer name (Sanlinking here). > As you can see, (almost) all other boards follow this rule, so please > use "d240" instead of "sanlinking-d

Re: [LEDE-DEV] [PATCH v2] ramips: Add support for Sanlinking D240

2017-02-03 Thread Piotr Dymacz
Hi Kristian, My two cents: the general convention for board name is to not include the manufacturer name (Sanlinking here). As you can see, (almost) all other boards follow this rule, so please use "d240" instead of "sanlinking-d240" (also for dts filename). Cheers, Piotr 2017-02-03 9:54 GMT+01:

[LEDE-DEV] [PATCH v2] ramips: Add support for Sanlinking D240

2017-02-03 Thread Kristian Evensen
The Sanlinking Technologies D240 (http://www.sanlinking.com/en/29-dual-4g-wifi-router.html) is basically the same device as the ZBT WE826, so adding support for it in LEDE is straight forward. The differences is that the D240 has two mini-PCIe slots (instead of one), blue LEDs and supports PoE. Wi