Re: [LEDE-DEV] [PATCH v2 1/3] base-files: add/convert generic board detection scripts

2017-05-10 Thread Piotr Dymacz
Hello Roman, On 09.05.2017 22:24, Roman Yeryomin wrote: On 9 May 2017 at 12:51, Piotr Dymacz wrote: Hello Roman, Hi Your mail addresses in from header and in SoB line don't match. is that a problem? AFAIK, not a big one but in general, yes. Someone would need to fix

Re: [LEDE-DEV] [PATCH v2 1/3] base-files: add/convert generic board detection scripts

2017-05-09 Thread Roman Yeryomin
On 9 May 2017 at 12:51, Piotr Dymacz wrote: > Hello Roman, Hi > Your mail addresses in from header and in SoB line don't match. is that a problem? > Also, some questions inline, below. > > > On 09.05.2017 11:16, Roman Yeryomin wrote: >> >> Signed-off-by: Roman Yeryomin

Re: [LEDE-DEV] [PATCH v2 1/3] base-files: add/convert generic board detection scripts

2017-05-09 Thread Piotr Dymacz
Hello Roman, Your mail addresses in from header and in SoB line don't match. Also, some questions inline, below. On 09.05.2017 11:16, Roman Yeryomin wrote: Signed-off-by: Roman Yeryomin --- package/base-files/files/lib/board_detect.sh | 9 +

[LEDE-DEV] [PATCH v2 1/3] base-files: add/convert generic board detection scripts

2017-05-09 Thread Roman Yeryomin
Signed-off-by: Roman Yeryomin --- package/base-files/files/lib/board_detect.sh | 9 + package/base-files/files/lib/preinit/03_preinit_board_detect | 11 +++ package/base-files/files/lib/preinit/10_sysinfo | 10 -- 3 files