Re: [LEDE-DEV] [PATCH v4] base-files: Ensure reset only works if an overlay exists

2016-10-24 Thread Bastian Bittorf
* Chris Blake [24.10.2016 07:47]: > Alexis is correct, it's to ensure any chance of a random error is > suppressed. 2> /dev/null was just added as a protection. i will explain why this makes no sense: grep will complain if e.g. the file '/proc/mounts' does not exist,

Re: [LEDE-DEV] [PATCH v4] base-files: Ensure reset only works if an overlay exists

2016-10-23 Thread Chris Blake
Hello, Alexis is correct, it's to ensure any chance of a random error is suppressed. 2> /dev/null was just added as a protection. Regards, Chris Blake On Sun, Oct 23, 2016 at 4:46 PM, Alexis Green wrote: > I’m guessing it’s because there might some random error message from

Re: [LEDE-DEV] [PATCH v4] base-files: Ensure reset only works if an overlay exists

2016-10-23 Thread Alexis Green
I’m guessing it’s because there might some random error message from grep? Maybe use -s option for grep instead to suppress error messages? > On Oct 23, 2016, at 12:30 PM, Bastian Bittorf wrote: > > * Chris Blake [23.10.2016 21:10]: >> +OVERLAY="$( grep '

Re: [LEDE-DEV] [PATCH v4] base-files: Ensure reset only works if an overlay exists

2016-10-23 Thread edgar . soldin
On 23.10.2016 23:42, edgar.sol...@web.de wrote: > On 23.10.2016 21:30, Bastian Bittorf wrote: >> * Chris Blake [23.10.2016 21:10]: >>> +OVERLAY="$( grep ' /overlay ' /proc/mounts 2>/dev/null )" >> >> whats the reason for the 2>...? >> > > for the corner case that the

Re: [LEDE-DEV] [PATCH v4] base-files: Ensure reset only works if an overlay exists

2016-10-23 Thread edgar . soldin
On 23.10.2016 21:30, Bastian Bittorf wrote: > * Chris Blake [23.10.2016 21:10]: >> +OVERLAY="$( grep ' /overlay ' /proc/mounts 2>/dev/null )" > > whats the reason for the 2>...? > for the corner case that the error message might contain ' /overlay' ? just a guess..

Re: [LEDE-DEV] [PATCH v4] base-files: Ensure reset only works if an overlay exists

2016-10-23 Thread Bastian Bittorf
* Chris Blake [23.10.2016 21:10]: > +OVERLAY="$( grep ' /overlay ' /proc/mounts 2>/dev/null )" whats the reason for the 2>...? bye, bastian ___ Lede-dev mailing list Lede-dev@lists.infradead.org

[LEDE-DEV] [PATCH v4] base-files: Ensure reset only works if an overlay exists

2016-10-23 Thread Chris Blake
Currently the reset script will try to run jffs2reset on boards that are running a rw rootfs, such as ext4. This will cause jffs2reset to fail and the board to never reboot while the LED blinks until a manual reboot. This commit does two different things: 1. Disables reset on boards that do not