> Fetching the entire port stats only to look up two fields seems rather
> excessive. Please make a function instead that will look up the register
> number and fetch only the relevant registers.
> The lookup can be further simplified by adding an enum for the mib_stats
> array index.
>
> - Felix
On 2017-02-25 22:51, Daniel Gonzalez Cabanelas wrote:
> Currently the switch LED trigger only shows link status, but not traffic
> activity by blinking
> the LEDs on the AR8316/AR8327 switch. It turns out that the get_port_stats is
> missing.
>
> I've made this patch, which works ok. But I'm
Currently the switch LED trigger only shows link status, but not traffic
activity by blinking
the LEDs on the AR8316/AR8327 switch. It turns out that the get_port_stats is
missing.
I've made this patch, which works ok. But I'm not sure if there is any reason
to not implement this
function.
