On Fri, 2016-10-14 at 12:19 -0500, Chris Blake wrote:
>
> target/linux/x86/64/config-default | 12 +
> target/linux/x86/64/profiles/001-PCEngines.mk | 20 +
> target/linux/x86/base-files/etc/board.d/01_leds | 22 ++
> target/linux/x86/base-files/etc/board.d/02_network |
Hey Stijn,
Thanks for the feedback, will get this fixed up for the next RFC as well.
Please keep the feedback coming. :)
- Chris B
On Sat, Oct 15, 2016 at 9:41 AM, Stijn Tintel wrote:
> On 14-10-16 20:19, Chris Blake wrote:
>> The following patch adds support for the PC Engines APU2 Embedded B
On 14-10-16 20:19, Chris Blake wrote:
> The following patch adds support for the PC Engines APU2 Embedded Board
> as a profile under the X86_64 target. More information on this board can
> be found at www.pcengines.ch/apu2c4.htm
>
> Note that this patch is a part of an RFC, and should not be merged
Hi,
did not see the cover letter until just now.
regarding the new image building code ... just ignore that comment,
looks like x86 was not converted yet to the new code pattern
John
On 15/10/2016 10:16, Chris Blake wrote:
> Hello Jon,
>
> My comments can be found below:
>
> On Sat, O
Hello Jon,
My comments can be found below:
On Sat, Oct 15, 2016 at 2:27 AM, John Crispin wrote:
> Hi Chris,
>
> i had quick read of the patch and it looks good at first glance. i
> would suggest you split he patch up as follows.
>
> 1) add the 2 new drivers
> 2) add the support for the new boar
Hi Chris,
i had quick read of the patch and it looks good at first glance. i
would suggest you split he patch up as follows.
1) add the 2 new drivers
2) add the support for the new board
3) the patches that add board.d, led, diag ... and all the other parts
adding the rootfs board support to x86
The following patch adds support for the PC Engines APU2 Embedded Board
as a profile under the X86_64 target. More information on this board can
be found at www.pcengines.ch/apu2c4.htm
Note that this patch is a part of an RFC, and should not be merged yet.
Signed-off-by: Chris Blake
---
target/
