Re: [LEDE-DEV] [PATCH] firewall3: Enable TCP_ECN by default.

2017-12-12 Thread Rosen Penev
resent since gmail sucks. On Tue, Dec 12, 2017 at 10:34 AM, Rosen Penev wrote: > On Tue, Dec 12, 2017 at 6:07 AM, John Crispin wrote: >> >> >> On 03/10/17 09:16, Rosen Penev wrote: >>> >>> ECN is used by fq_codel and other AQMs. Kernel 4.2 added a fallback in

Re: [LEDE-DEV] [PATCH] firewall3: Enable TCP_ECN by default.

2017-12-12 Thread Rosen Penev
On Tue, Dec 12, 2017 at 6:07 AM, John Crispin wrote: > > > On 03/10/17 09:16, Rosen Penev wrote: >> >> ECN is used by fq_codel and other AQMs. Kernel 4.2 added a fallback in >> case of failure, so adjust to kernel default. >> >> Signed-off-by: Rosen Penev >>

Re: [LEDE-DEV] [PATCH] firewall3: Enable TCP_ECN by default.

2017-12-12 Thread John Crispin
On 03/10/17 09:16, Rosen Penev wrote: ECN is used by fq_codel and other AQMs. Kernel 4.2 added a fallback in case of failure, so adjust to kernel default. Signed-off-by: Rosen Penev --- defaults.c | 1 + 1 file changed, 1 insertion(+) diff --git a/defaults.c

Re: [LEDE-DEV] [PATCH] firewall3: Enable TCP_ECN by default.

2017-10-05 Thread Kevin Darbyshire-Bryant
On 03/10/17 18:22, David Lang wrote: On Tue, 3 Oct 2017, Kevin Darbyshire-Bryant wrote: It's tempting to set it to 1 (like I have for the past year+) and be damned :-) So what is the failure mode and how will people who experience failures know what they need to change? David Lang I'd

Re: [LEDE-DEV] [PATCH] firewall3: Enable TCP_ECN by default.

2017-10-03 Thread David Lang
On Tue, 3 Oct 2017, Kevin Darbyshire-Bryant wrote: It's tempting to set it to 1 (like I have for the past year+) and be damned :-) So what is the failure mode and how will people who experience failures know what they need to change? David Lang

Re: [LEDE-DEV] [PATCH] firewall3: Enable TCP_ECN by default.

2017-10-03 Thread Kevin Darbyshire-Bryant
On 03/10/17 08:16, Rosen Penev wrote: ECN is used by fq_codel and other AQMs. Kernel 4.2 added a fallback in case of failure, so adjust to kernel default. The kernel default is 2, which is what you've set the firewall3 default to be now as well. 2 accepts ECN on incoming connections but