[LEDE-DEV] Switches between LTS kernels and removal of previous LTSes

2018-01-08 Thread Stijn Segers
Sorry, now the non-HTML version... Hi guys, I remember there was quite a bit of gnashing of teeth, when targets in master dropped 4.4 support so quickly after 17.01 had been released (which made it very cumbersome to backport 4.4 kernel bumps from master to the stable branch). Wouldn't it be

[LEDE-DEV] [PATCH 3/3] ar71xx/mikrotik: disable TP-Link TL-WR810N v2 board support

2018-01-08 Thread Gabor Juhos
It does not belongs to the MikroTik boards. Signed-off-by: Gabor Juhos --- target/linux/ar71xx/mikrotik/config-default | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/ar71xx/mikrotik/config-default b/target/linux/ar71xx/mikrotik/config-default index

[LEDE-DEV] Merged: ar71xx: sort kernel configurations

2018-01-08 Thread Jo-Philipp Wich
Merged into my staging tree with http://git.openwrt.org/?p=openwrt/staging/jow.git;a=commitdiff;h=f9ae253c3e. Thank you! ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] Merged: ar71xx: fix Kconfig dependency of the 88E6063 switch DSAdriver

2018-01-08 Thread Jo-Philipp Wich
Merged into my staging tree with http://git.openwrt.org/?p=openwrt/staging/jow.git;a=commitdiff;h=b21a7e5349. Thank you! ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] Merged: ar71xx/mikrotik: disable unused MTD partitioning and splitdrivers

2018-01-08 Thread Jo-Philipp Wich
Merged into my staging tree with http://git.openwrt.org/?p=openwrt/staging/jow.git;a=commitdiff;h=e7d9da323f. Thank you! ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] Merged: ar71xx/mikrotik: disable unused ethernet switch and phy drivers

2018-01-08 Thread Jo-Philipp Wich
Merged into my staging tree with http://git.openwrt.org/?p=openwrt/staging/jow.git;a=commitdiff;h=eed9614af2. Thank you! ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] Merged: ar71xx/mikrotik: disable TP-Link TL-WR810N v2 board support

2018-01-08 Thread Jo-Philipp Wich
Merged into my staging tree with http://git.openwrt.org/?p=openwrt/staging/jow.git;a=commitdiff;h=bb22c988ce. Thank you! ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] [PATCH 2/3] ar71xx/mikrotik: disable unused MTD partitioning and split drivers

2018-01-08 Thread Gabor Juhos
Reduces the compressed kernel size by ~2.5KB. Signed-off-by: Gabor Juhos --- target/linux/ar71xx/mikrotik/config-default | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/linux/ar71xx/mikrotik/config-default b/target/linux/ar71xx/mikrotik/config-default index

[LEDE-DEV] [PATCH 1/3] ar71xx/mikrotik: disable unused ethernet switch and phy drivers

2018-01-08 Thread Gabor Juhos
Disable the drivers for the following ethernet switches: Realtek RTL8306 Realtek RTL8366/8367 Marvell 88E6060 (DSA) Marvell 88E6063 (DSA) Also disable the phy driver for Marvell PHYs. None of the supported RouterBOARDs are using any device which needs these drivers. Disable the DSA

[LEDE-DEV] [PATCH 0/3] ar71xx/mikrotik: disable unused kernel options

2018-01-08 Thread Gabor Juhos
The kernel configuration of the mikrotik subtarget enables several kernel options that are not required by the supported MikroTik boards. The patches in this series are disabling some of them to get rid of the unused code and to reduce the size of the compiled kernel. The size of the

Re: [LEDE-DEV] Espressobin mvebu64

2018-01-08 Thread Tomasz Maciej Nowak
Hi, 2018-01-06 12:12 GMT+01:00, Nishant Sharma : > Hi Hauke, > > On Friday 05 January 2018 11:33 PM, Hauke Mehrtens wrote: >> I have never looked at the OpenWrt fork provided by Marvell, but I got >> OpenWrt master working on the espressobin with kernel 4.14. It only has

[LEDE-DEV] [PATCH 07/15] metadata: replace %subdir hash with a path field in source packages

2018-01-08 Thread Matthias Schiffer
Every single reference to subdir was concatenated with the source package name, so it makes sense to store the concatenated value instead. Signed-off-by: Matthias Schiffer --- scripts/metadata.pm | 12 +++- scripts/package-metadata.pl | 25

[LEDE-DEV] [PATCH 08/15] metadata: remove redundant fields from package hash

2018-01-08 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- scripts/metadata.pm | 3 --- scripts/package-metadata.pl | 8 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/scripts/metadata.pm b/scripts/metadata.pm index e636a45a33..50f91407d6 100644 ---

[LEDE-DEV] [PATCH 03/15] metadata: move 'buildtypes' from binary to source packages

2018-01-08 Thread Matthias Schiffer
Build types are a property of source rather than binary packages. This is a preparation for followup cleanup. Signed-off-by: Matthias Schiffer --- scripts/metadata.pm | 4 ++-- scripts/package-metadata.pl | 13 +++-- 2 files changed, 9

[LEDE-DEV] [PATCH 06/15] metadata: change pkg->{src} field to hold a reference

2018-01-08 Thread Matthias Schiffer
We often want to access fields of a source packages through pkg->{src}. Allow accessing them directly instead of resolving the source hash through srcpackages. Signed-off-by: Matthias Schiffer --- scripts/feeds | 4 ++-- scripts/metadata.pm

[LEDE-DEV] [PATCH 15/15] include/package-dumpinfo.mk: don't duplicate source package information for every binary package

2018-01-08 Thread Matthias Schiffer
Eventually the BUILDONLY package flag could be replaced by simply creating a package Makefile without any BuildPackage calls. This will fail for now, as BuildPackage also causes the Makefile's compile target etc. to do something useful at all. Signed-off-by: Matthias Schiffer

[LEDE-DEV] [PATCH 05/15] metadata: interate over source packages when generating Makefile

2018-01-08 Thread Matthias Schiffer
All build dependencies are between source packages. Interating over source rather than binary packages simplifies parts of the code and prepares further improvement. As a side effect, this changes the implicit default variant of a few packages (the first defined is used now instead of the

[LEDE-DEV] [PATCH 01/15] metadata: remove 'base-files' special case

2018-01-08 Thread Matthias Schiffer
Nothing explicitly depends on base-files, and even if it would, it would not cause any problems. Remove the unused special case. Signed-off-by: Matthias Schiffer --- scripts/package-metadata.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[LEDE-DEV] [PATCH 00/15] Metadata generator refactoring, cleanup and PROVIDES improvements

2018-01-08 Thread Matthias Schiffer
When attempting to fix FS#837, I decided to treat our metadata generator to a greater refactoring, which resulted in this patchset. FS#837 is fixed in patch 13. I also removed two seemingly obsolete features, "preconfig" and "package features", which are not used by any package in the

[LEDE-DEV] [PATCH 02/15] metadata: make srcpackage extensible

2018-01-08 Thread Matthias Schiffer
Turn the srcpackage values into hashes to allow storing more information than just binary package names. Signed-off-by: Matthias Schiffer --- scripts/feeds | 2 +- scripts/metadata.pm | 6 -- scripts/package-metadata.pl | 2 +- 3 files

[LEDE-DEV] [PATCH 10/15] treewide: fix build depends to refer to source package names

2018-01-08 Thread Matthias Schiffer
Build depends must refer to source packages rather than binary package names. Signed-off-by: Matthias Schiffer --- include/autotools.mk | 4 ++-- include/nls.mk | 2 +-

[LEDE-DEV] [PATCH 12/15] metadata: simplify generation of build depends from runtime depends

2018-01-08 Thread Matthias Schiffer
Runtime depends cannot have a buildtype suffix, and they never refer to source package names. In addition, this adds warnings about unsatisfiable dependencies. Furthermore, this change fixes the generation of conditional build dependencies for virtual packages provided by different source

[LEDE-DEV] [PATCH 11/15] metadata: handle target build depends together with host build depends

2018-01-08 Thread Matthias Schiffer
Target build depends are similar to host build depends in that they refer to source packages rather than binary packages. Therefore, it makes sense to handle them together, rather than putting them in a list together with runtime depends and trying to figure out if the entries refer to source or

[LEDE-DEV] [PATCH 09/15] build: remove package preconfig feature

2018-01-08 Thread Matthias Schiffer
This feature has been unused for years, and its scope is too limited to be actually useful. Signed-off-by: Matthias Schiffer --- include/package-dumpinfo.mk | 16 +--- package/Makefile| 3 --- scripts/metadata.pm | 20

[LEDE-DEV] [PATCH 14/15] build: remove obsolete "package feature" feature

2018-01-08 Thread Matthias Schiffer
Package "features" seem to be unused for some time. In any case, custom Config.in snippets and package PROVIDES are a much more flexible way to express similar options. Signed-off-by: Matthias Schiffer --- include/package-dumpinfo.mk | 25

[LEDE-DEV] [PATCH 13/15] metadata: always resolve dependencies through provides list

2018-01-08 Thread Matthias Schiffer
Instead of adding virtual packages to the normal package list, keep a separate list for provides, make each package provide itself, and resolve all dependencies through this list. This allows to use PROVIDES to replace existing packages. Fixes FS#837. Signed-off-by: Matthias Schiffer

[LEDE-DEV] [PATCH 04/15] metadata: move 'builddepends' from binary to source packages

2018-01-08 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- scripts/feeds | 20 +++- scripts/metadata.pm | 6 +++--- scripts/package-metadata.pl | 16 +++- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/scripts/feeds

[LEDE-DEV] Bug? Routes of disabled interfaces appear in routing table

2018-01-08 Thread yanosz
Hello, I discovered an issue with disabled interfaces propagating routes to sepcified tables. Given: config interface 'internet_share' option ifname '@wan' option proto 'dhcp' option ip4table '65' config interface 'internet_share6' option ifname '@wan'

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Kus
Thank you. I think we ought to demand a product recall for everything Intel. signature.asc Description: PGP signature ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH 00/15] Metadata generator refactoring, cleanup and PROVIDES improvements

2018-01-08 Thread Matthias Schiffer
On 01/08/2018 03:52 PM, Matthias Schiffer wrote: > When attempting to fix FS#837, I decided to treat our metadata generator to > a greater refactoring, which resulted in this patchset. FS#837 is fixed in > patch 13. > > I also removed two seemingly obsolete features, "preconfig" and "package >

Re: [LEDE-DEV] Bug? Routes of disabled interfaces appear in routing table

2018-01-08 Thread yanosz
Hallo, Am 2018-01-08 um 16:41 schrieb Jo-Philipp Wich: > Hi yanosz, > > "option enabled" is not defined for /etc/config/network, config > interface as far as I know. Maybe you meant "option auto 0" instead? Interesting. Looking at the docs it is supported:

[LEDE-DEV] [PATCH 1/1] at91: update kernel 4.9.73 to 4.14.11

2018-01-08 Thread Sandeep Sheriker Mallikarjun
update at91 kernel 4.9.73 to 4.14.11 Signed-off-by: Sandeep Sheriker Mallikarjun --- target/linux/at91/Makefile | 2 +- target/linux/at91/{config-4.9 => config-4.14} | 6 ++

Re: [LEDE-DEV] Bug? Routes of disabled interfaces appear in routing table

2018-01-08 Thread Paul Oranje
The common option on an interface that disables/enables it is named "disabled". Just corrected wiki entry accordingly. Regards, Paul > Op 8 jan. 2018, om 20:06 heeft yanosz het volgende > geschreven: > > Hallo, > > > Am 2018-01-08 um 16:41 schrieb Jo-Philipp Wich: >> Hi

[LEDE-DEV] [PATCH 1/6] at91bootstrap: fix name of sama5d4_xplainednf_uboot

2018-01-08 Thread Hauke Mehrtens
The default configuration file for sama5d4_xplainednf_uboot does not exist, but a default configuration file for sama5d4_xplainednf_uboot_secure exists, fix the name. Fixes: 670448a002 ("at91bootstrap: New package at91bootstrap") Signed-off-by: Hauke Mehrtens ---

[LEDE-DEV] [PATCH 6/6] at91: create device specific sdcard images

2018-01-08 Thread Hauke Mehrtens
Without this patch one sdcard image with the following name is created for all devices: openwrt-at91-sama5--sdcard.img.gz This makes the build system create device specific versions like: openwrt-at91-sama5-at91-sama5d2_xplained-sdcard.img.gz Signed-off-by: Hauke Mehrtens ---

[LEDE-DEV] [PATCH 4/6] at91bootstrap: make packages hidden

2018-01-08 Thread Hauke Mehrtens
These packages are needed to generate the image, better mark them hidden so we will activate them based on which boards gets build and they will be activated always when the board which needs then gets build. Signed-off-by: Hauke Mehrtens ---

[LEDE-DEV] [PATCH 3/6] at91bootstrap: remove redundant definition of BUILD_SUBTARGET

2018-01-08 Thread Hauke Mehrtens
It is sufficient to define this in AT91Bootstrap/Default as this is not used for all. Signed-off-by: Hauke Mehrtens --- package/boot/at91bootstrap/Makefile | 8 1 file changed, 8 deletions(-) diff --git a/package/boot/at91bootstrap/Makefile

[LEDE-DEV] [PATCH 2/6] at91bootstrap: fix name of packages

2018-01-08 Thread Hauke Mehrtens
The packages should start with AT91Bootstrap and not at91bootstrap to use the default definition. Without this patch the packages are not getting selected automatically when the board gets selected, but this is needed to successfully create the image. Fixes: 670448a002 ("at91bootstrap: New

[LEDE-DEV] [PATCH 5/6] uboot-at91: make packages hidden

2018-01-08 Thread Hauke Mehrtens
These packages are needed to generate the image, better mark them hidden so we will activate them based on which boards gets build and they will be activated always when the board which needs then gets build. Signed-off-by: Hauke Mehrtens --- package/boot/uboot-at91/Makefile |

Re: [LEDE-DEV] [PATCH 4/6] at91bootstrap: make packages hidden

2018-01-08 Thread Sandeep Sheriker
Hi Hauke,     I have already fixed this and submitted this patch. below is the patch link for references. https://patchwork.ozlabs.org/patch/855788/ Regards, Sandeep Sheriker M On 01/08/2018 03:58 PM, Hauke Mehrtens wrote: These packages are needed to generate the image, better mark them

[LEDE-DEV] [PATCH 1/3] at91:Add SAMA5D27 SOM1 EK device

2018-01-08 Thread Sandeep Sheriker Mallikarjun
Add support for SAMA5D27 with target device as at91-sama5d27_som1_ek in SAMA5 subtarget and build images for SAMA5D27 SOM1 EK board. Signed-off-by: Sandeep Sheriker Mallikarjun --- target/linux/at91/base-files/lib/at91.sh | 3 +++

[LEDE-DEV] [PATCH 3/3] uboot-at91: Add support for SAMA5D27 SOM1 EK board

2018-01-08 Thread Sandeep Sheriker Mallikarjun
Add support for SAMA5D27 SOM1 EK board. Signed-off-by: Sandeep Sheriker Mallikarjun --- package/boot/uboot-at91/Makefile | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/package/boot/uboot-at91/Makefile

[LEDE-DEV] [PATCH 0/3] Add AT91 SAMA5D27 SOM1 EK board

2018-01-08 Thread Sandeep Sheriker Mallikarjun
This patch series includes adding support of SAMA5D27 SOM1 Ek board Sandeep Sheriker Mallikarjun (3): at91:Add SAMA5D27 SOM1 EK device at91bootstrap: Add support for SAMA5D27 SOM1 EK board uboot-at91: Add support for SAMA5D27 SOM1 EK board package/boot/at91bootstrap/Makefile | 20

[LEDE-DEV] [PATCH 2/3] at91bootstrap: Add support for SAMA5D27 SOM1 EK board

2018-01-08 Thread Sandeep Sheriker Mallikarjun
1. Add support for SAMA5D27 SOM1 EK board 2. version update to v3.8.9 Signed-off-by: Sandeep Sheriker Mallikarjun --- package/boot/at91bootstrap/Makefile | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git

[LEDE-DEV] [PATCH v1] kmod-sched-cake: bump to latest cake bake for 17.01

2018-01-08 Thread Kevin Darbyshire-Bryant
More important bug fix: 402f05c Use full-rate mtu_time in all tins. Fixes an issue where some cake tins experienced excessive latency since 49776da (dynamically adjust target) Minor bug fixes: 31277c2 Avoid unsigned comparison against zero. Fix compiler warning, no known impact. 8cf5278

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Nick Lowe
Hi, Where in 4.9.75 does it avoid the page table isolation mitigation for AMD? Committed to the 4.14 and 4.15 branch is: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.15-rc7=694d99d40972f12e59a3696effee8a376b79d7c8 X86_BUG_CPU_INSECURE becomes

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Nick Lowe
Agreed. So this will seemingly regress something like an APU2 and therefore probably should not be merged to LEDE as-is? Nick On Mon, Jan 8, 2018 at 11:08 AM, Kevin Darbyshire-Bryant wrote: > > >> On 8 Jan 2018, at 11:04, Nick Lowe wrote: >>

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Arjen de Korte
Citeren Kevin Darbyshire-Bryant : On 8 Jan 2018, at 11:04, Nick Lowe wrote: Hi, Where in 4.9.75 does it avoid the page table isolation mitigation for AMD? Committed to the 4.14 and 4.15 branch is:

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Kevin Darbyshire-Bryant
> On 8 Jan 2018, at 11:12, Nick Lowe wrote: > > Agreed. So this will seemingly regress something like an APU2 and > therefore probably should not be merged to LEDE as-is? I’ll let an adult decide the performance/security tradeoff. signature.asc Description: Message

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Nick Lowe
It looks like PCID and INVPCID support is likely to be back ported to the 4.9.76 Linux Kernel: https://patchwork.kernel.org/patch/10143225/ ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Nick Lowe
Sorry, it was back ported to 4.9.75 :-) On Mon, Jan 8, 2018 at 12:34 PM, Nick Lowe wrote: > It looks like PCID and INVPCID support is likely to be back ported to > the 4.9.76 Linux Kernel: https://patchwork.kernel.org/patch/10143225/

[LEDE-DEV] [PATCH v1] kmod-sched-cake: bump to latest cake bake

2018-01-08 Thread Kevin Darbyshire-Bryant
More important bug fix: 402f05c Use full-rate mtu_time in all tins. Fixes an issue where some cake tins experienced excessive latency since 49776da (dynamically adjust target) Minor bug fixes: 31277c2 Avoid unsigned comparison against zero. Fix compiler warning, no known impact. 8cf5278

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Kevin Darbyshire-Bryant
> On 8 Jan 2018, at 11:04, Nick Lowe wrote: > > Hi, > > Where in 4.9.75 does it avoid the page table isolation mitigation for AMD? > > Committed to the 4.14 and 4.15 branch is: > >

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Nick Lowe
Hi all, I am a moron, I missed: +skip: + if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) + goto disable; It uses a different path... Regards, NIck On Mon, Jan 8, 2018 at 11:27 AM, Nick Lowe wrote: > Hi Kevin, > > I am not following :-) For AMD, there should not be a

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Alberto Bursi
AFAIK AMD processors that don't need that are from Zen onwards. Older ones are impacted. -Alberto On 08/01/2018 12:27, Nick Lowe wrote: Hi Kevin, I am not following :-) For AMD, there should not be a tradeoff as there is no need for the page table isolation. Regards, Nick On Mon, Jan 8,

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Koen Vandeputte
Tested-by: Koen Vandeputte Targets: cns3xxx, imx6 ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH v1] kernel: bump 4.9 to 4.9.75

2018-01-08 Thread Nick Lowe
Hi Kevin, I am not following :-) For AMD, there should not be a tradeoff as there is no need for the page table isolation. Regards, Nick On Mon, Jan 8, 2018 at 11:21 AM, Kevin Darbyshire-Bryant wrote: > > >> On 8 Jan 2018, at 11:12, Nick Lowe

[LEDE-DEV] [PATCH] ar71xx: sort kernel configurations

2018-01-08 Thread Gabor Juhos
The symbols in some kernel configurations of the target are in wrong order. Sort them with kconfig.pl. Signed-off-by: Gabor Juhos --- target/linux/ar71xx/config-4.4 | 4 ++-- target/linux/ar71xx/config-4.9 | 4 ++--

[LEDE-DEV] [PATCH] ar71xx: fix Kconfig dependency of the 88E6063 switch DSA driver

2018-01-08 Thread Gabor Juhos
The Marvell 88E6063 ethernet switch driver depends on the DSA framework. Add a 'depends on NET_DSA' statement to its Kconfig entry to state that explicitly. Fixes the following Kconfig warning: warning: (NET_DSA_MV88E6060 && NET_DSA_MV88E6063) selects NET_DSA_TAG_TRAILER which has unmet

Re: [LEDE-DEV] Bug? Routes of disabled interfaces appear in routing table

2018-01-08 Thread Jo-Philipp Wich
Hi yanosz, "option enabled" is not defined for /etc/config/network, config interface as far as I know. Maybe you meant "option auto 0" instead? Regards, Jo ___ Lede-dev mailing list Lede-dev@lists.infradead.org

Re: [LEDE-DEV] [PATCH 13/15] metadata: always resolve dependencies through provides list

2018-01-08 Thread Jo-Philipp Wich
Hi, [...] > diff --git a/scripts/package-metadata.pl b/scripts/package-metadata.pl > index 980ad24dc0..41e7108322 100755 > --- a/scripts/package-metadata.pl > +++ b/scripts/package-metadata.pl > @@ -101,14 +101,16 @@ my %dep_check; > sub __find_package_dep($$) { > my $pkg = shift; >