Re: [LEDE-DEV] fstools: ext4 overlay support - rootfs mounted twice bug

2016-06-28 Thread John Crispin
Hi, the patch is an attachement making inline commenting impossible. please send patches inline > mount_root: Don't mount ext4 rootfs twice the patch is incorrect, it breaks the vase where there is an overlay setup + extroot. after your patch the extroot codepath wont ever run if there is a root

Re: [LEDE-DEV] [PATCH v5] base-files: seed /dev/urandom

2016-06-28 Thread Etienne Champetier
Hi Arjen, 2016-06-28 11:52 GMT+02:00 Arjen de Korte : > Citeren John Crispin : > >> On 28/06/2016 10:28, Jo-Philipp Wich wrote: >>> >>> Hi Etienne, >>> >>> I like this approach, fine with me now. >>> >> >> same here, we could not also consider adding a uci-defaults script that >> check if rootfs i

Re: [LEDE-DEV] [PATCH v5] base-files: seed /dev/urandom

2016-06-28 Thread Arjen de Korte
Citeren John Crispin : On 28/06/2016 10:28, Jo-Philipp Wich wrote: Hi Etienne, I like this approach, fine with me now. same here, we could not also consider adding a uci-defaults script that check if rootfs is on a mtd or real lbock device and change the default during firstboot, but i gues

Re: [LEDE-DEV] [PATCH v5] base-files: seed /dev/urandom

2016-06-28 Thread John Crispin
On 28/06/2016 10:28, Jo-Philipp Wich wrote: > Hi Etienne, > > I like this approach, fine with me now. > same here, we could not also consider adding a uci-defaults script that check if rootfs is on a mtd or real lbock device and change the default during firstboot, but i guess that would be a

Re: [LEDE-DEV] [PATCH v5] base-files: seed /dev/urandom

2016-06-28 Thread Jo-Philipp Wich
Hi Etienne, I like this approach, fine with me now. On 06/27/2016 05:53 PM, Etienne CHAMPETIER wrote: > This commit: > 1) seed /dev/urandom with the saved seeds as early as possible >(see /lib/preinit/81_urandom_seed) > 2) save a seed at /etc/urandom.seed if it doesn't exists > 3) save a new