Re: [LEDE-DEV] Automated shell code debugging

2016-10-04 Thread Bastian Bittorf
* Jan-Tarek Butt [05.10.2016 07:47]: > > also we must "mute" some "errors", e.g. the usage of > > 'local' in functions, which is not POSIX (but is in the > > process of inclusion) > > shellcheck is able to do that. > > for mutin just add the comment > > # shellcheck disable= is is not that ea

Re: [LEDE-DEV] Automated shell code debugging

2016-10-04 Thread Jan-Tarek Butt
On 10/02/16 18:10, Bastian Bittorf wrote: > * Jan-Tarek Butt [02.10.2016 17:48]: >> As a part of code quallity enhancemend and prevenition. We can do an >> ondemand daemon as engine to >> check all shell scrips. We can use the opensource Project shellcheck [0]. >> >> My idea is to do an insatnc

Re: [LEDE-DEV] [PATCH v2 2/2] ar71xx: add support for the Airtight C-60

2016-10-04 Thread Piotr Dymacz
Hello Christian, Small comments below, inline. 2016-10-04 22:55 GMT+02:00 Christian Lamparter : [snip] > diff --git a/target/linux/ar71xx/base-files/etc/diag.sh > b/target/linux/ar71xx/base-files/etc/diag.sh > index d6e257d..5f2056e 100644 > --- a/target/linux/ar71xx/base-files/etc/diag.sh > +

[LEDE-DEV] [LEDE DEV][wiki] Template switcher / mobile version added

2016-10-04 Thread Thomas Endt
I added a template switcher which allows you to switch between two templates or themes. You find a dropdown list in the upper left of the page. Full version = monobook Mobile Version = bootstrap3 This is just for tryout. Please let me know if you think it's useful to provide this dropdown list.

[LEDE-DEV] [PATCH v2 2/2] ar71xx: add support for the Airtight C-60

2016-10-04 Thread Christian Lamparter
This patch adds support for the Airtight C-60. SOC:Atheros AR9344 rev 2 (CPU:560.000MHz) RAM:128 MiB NOR:MX25L3205D 4MiB NAND: ST Micro NAND 32MiB 3,3V 8-bit SW-NET: AR8327N (2 Ports) WLAN1: Dual-Band AR9340 Rev:2 (built-in SoC) WLAN2: Dual-Band AR9300 Rev:4 PCIe Chip The switch i

[LEDE-DEV] [PATCH v2 1/2] generic: ar8216: improve ar8xxx_is_possible check

2016-10-04 Thread Christian Lamparter
The commit "generic: ar8216: add sanity check to ar8216_probe" (774da6c7a40320a320b28d71291c0e61fcf7bc8a) stated that PHY IDs should be checked at address 0-4. However, the PHY 4 was never check by the loop. This patch extends the check to be similar to the Atheors SDK. It tries all 4 ports and ski

Re: [LEDE-DEV] Adding support for dlink dwr-512

2016-10-04 Thread Giuseppe Lippolis
Dear All, Today I reach an important milestone in " Adding support for dlink dwr-512": BusyBox v1.25.0 () built-in shell (ash) _ //\ ____ ___ ___ / LE/ \| | | __| \| __| /DE /\ | |__| _|| |) | _| // LE \ ||___|___/|__

Re: [LEDE-DEV] VRV9510KWAC23

2016-10-04 Thread Juan Rios
Hello again. Thanks to borderline at http://foro.seguridadwireless.net/openwrt/(desarrollo)-openwrt-en-livevox-next-(astoria-networks-vrv9510)/ I could install the ZyXEL P-2812HNU-F1 uboot and I can boot into it. What I did was shortcut the flash pins like described here https://wiki.openwrt.org/t

Re: [LEDE-DEV] [PATCH 2/2] base-files: support usbport LED trigger

2016-10-04 Thread Felix Fietkau
On 2016-10-04 12:44, Rafał Miłecki wrote: > From: Rafał Miłecki > > This adds ucidef_set_led_usbport function that can be called by target > board.d files. Example usage: > ucidef_set_led_usbport "usb" "bcm53xx:blue:usb" "usb1-port1" "usb2-port1" > > List of available ports can be fetched using:

Re: [LEDE-DEV] [PATCH 1/3] nvram: fix globbing, word splitting and arithmetic variables

2016-10-04 Thread Jan-Tarek Butt
On 10/04/16 14:51, John Crispin wrote: > > > On 04/10/2016 14:47, Jan-Tarek Butt wrote: >> Double quote to prevent globbing and word splitting. >> $/${} is unnecessary on arithmetic variables. >> Remove unused variables > > SoB missing here aswell > Ok, Sorry I'll read the patch howto and sen

Re: [LEDE-DEV] [PATCH 2/3] ct-bugcheck: fix globbing, word splitting and formatting

2016-10-04 Thread John Crispin
On 04/10/2016 14:50, Jan-Tarek Butt wrote: > Double quote to prevent globbing and word splitting. > { cmd1; cmd2; } >> file instead of individual redirects. Hi, apart from the SoB missing, this seems to be a resend of a patch sent previously, yet i dont see a list of things that you changed bet

[LEDE-DEV] [PATCH 2/3] ct-bugcheck: fix globbing, word splitting and formatting

2016-10-04 Thread Jan-Tarek Butt
Double quote to prevent globbing and word splitting. { cmd1; cmd2; } >> file instead of individual redirects. --- package/utils/ct-bugcheck/src/bugcheck.sh | 154 +++--- 1 file changed, 77 insertions(+), 77 deletions(-) diff --git a/package/utils/ct-bugcheck/src/bugcheck.s

Re: [LEDE-DEV] [PATCH 1/3] nvram: fix globbing, word splitting and arithmetic variables

2016-10-04 Thread John Crispin
On 04/10/2016 14:47, Jan-Tarek Butt wrote: > Double quote to prevent globbing and word splitting. > $/${} is unnecessary on arithmetic variables. > Remove unused variables SoB missing here aswell John > --- > package/utils/nvram/files/nvram.init | 27 +-- > 1 f

[LEDE-DEV] [PATCH 1/3] nvram: fix globbing, word splitting and arithmetic variables

2016-10-04 Thread Jan-Tarek Butt
Double quote to prevent globbing and word splitting. $/${} is unnecessary on arithmetic variables. Remove unused variables --- package/utils/nvram/files/nvram.init | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/package/utils/nvram/files/nvram.init

Re: [LEDE-DEV] package/boot/uboot-envtools/files/uboot-envtools.sh

2016-10-04 Thread John Crispin
On 04/10/2016 14:35, John Crispin wrote: > > > On 04/10/2016 14:31, Jan-Tarek Butt wrote: >> >> >> On 10/04/16 07:35, Mathias Kresin wrote: >>> 04.10.2016 01:49, Jan-Tarek Butt: Hi, Does anyone understand what this "variables" in line 24 to 28 are use [0]? [0] htt

Re: [LEDE-DEV] package/boot/uboot-envtools/files/uboot-envtools.sh

2016-10-04 Thread John Crispin
On 04/10/2016 14:31, Jan-Tarek Butt wrote: > > > On 10/04/16 07:35, Mathias Kresin wrote: >> 04.10.2016 01:49, Jan-Tarek Butt: >>> Hi, >>> >>> Does anyone understand what this "variables" in line 24 to 28 are use [0]? >>> >>> [0] >>> https://git.lede-project.org/?p=source.git;a=blob;f=package/

Re: [LEDE-DEV] package/boot/uboot-envtools/files/uboot-envtools.sh

2016-10-04 Thread Jan-Tarek Butt
On 10/04/16 07:35, Mathias Kresin wrote: > 04.10.2016 01:49, Jan-Tarek Butt: >> Hi, >> >> Does anyone understand what this "variables" in line 24 to 28 are use [0]? >> >> [0] >> https://git.lede-project.org/?p=source.git;a=blob;f=package/boot/uboot-envtools/files/uboot-envtools.sh;h=e21b28367751

Re: [LEDE-DEV] New device: Two USB ports, only one USB activity LED

2016-10-04 Thread Rafał Miłecki
On 2 September 2016 at 13:42, J Mo wrote: > I have a new device I am working on and it has two USB ports but only one > USB activity LED. > > Right now the LED works the way I like with one of the USB ports, but not > the other port. I would like for the LED to go active and/or blink when > there

[LEDE-DEV] [PATCH 2/2] base-files: support usbport LED trigger

2016-10-04 Thread Rafał Miłecki
From: Rafał Miłecki This adds ucidef_set_led_usbport function that can be called by target board.d files. Example usage: ucidef_set_led_usbport "usb" "bcm53xx:blue:usb" "usb1-port1" "usb2-port1" List of available ports can be fetched using: ls -d /sys/bus/usb/devices/*/*-port* or echo usbport >

[LEDE-DEV] [PATCH 1/2] kernel: add package for usbport LED trigger

2016-10-04 Thread Rafał Miłecki
From: Rafał Miłecki This is upstream alternative for LEDE's ledtrig-usbdev. It's main advantages are: 1) Support for assigning more than 1 USB port to the LED 2) Setting proper state when activating with device already connected 3) FWIW it's an upstream driver Signed-off-by: Rafał Miłecki ---

Re: [LEDE-DEV] Call defines for minifying scripting languages

2016-10-04 Thread Zefir Kurtisi
On 10/03/2016 01:00 PM, Jan-Tarek Butt wrote: > Hi, > > My Idea ist to create calldefs to minify all scriptes there are > interpreted by run time. > > As example see the mail "[PATCH] LuaSrcDiet call define for lua > code Minifying". > > I plan to write also calldefs for shellscripts, python a

Re: [LEDE-DEV] o2 box 6431 / VGV7510KW22 - SIP with FXS/TAE Ports | owsip or alternative ?

2016-10-04 Thread Daniel Golle
On Mon, Oct 03, 2016 at 01:56:06AM +0200, Hauke Mehrtens wrote: > On 09/23/2016 09:02 PM, Daniel Golle wrote: > > On Fri, Sep 23, 2016 at 08:14:24PM +0200, Dennis Schneck wrote: > >> > >> > >> > >> Hello, > >> i use the o2 box 6431 / VGV7510KW22 with LEDE r1640. > >> Like to use my SIP Accout wit

Re: [LEDE-DEV] replacing files in base system from a package?

2016-10-04 Thread Russell Senior
> "Karl" == Karl Palsson writes: Karl> What's the "new" way of doing this? In the past, in OpenWrt CC and Karl> before, a package could install files like /etc/banner and Karl> /etc/inittab that were provided by the base-files package. It was Karl> always listed as "unreliable" as apparently

Re: [LEDE-DEV] Call defines for minifying scripting languages

2016-10-04 Thread Bastian Bittorf
* Karl Palsson [04.10.2016 08:38]: [...] > about the scripts _at all_ right up until they try and look in > one to debug something behaving oddly. At _that_ point they will > care _very much_ that it's all minified garbage, with some > presumption that they could "just get the source somewhere e

Re: [LEDE-DEV] [PATCH] package/utils/nvram/files/nvram.init * Double quote to prevent globbing and word splitting. * $/${} is unnecessary on arithmetic variables. * remove unused variables

2016-10-04 Thread Mathias Kresin
04.10.2016 02:35, Jan-Tarek Butt: Signed-off-by: Jan-Tarek Butt Some problem with the commit title and message as with your ct-bugcheck patch. --- package/utils/nvram/files/nvram.init | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/packag

Re: [LEDE-DEV] [PATCH] package/utils/ct-bugcheck/src/bugcheck.sh * Double quote to prevent globbing and word splitting. * { cmd1; cmd2; } >> file instead of individual redirects. * fix formating

2016-10-04 Thread Mathias Kresin
04.10.2016 03:23, Jan-Tarek Butt: Hey Jan-Tarek please use a proper commit title and message. Something like: ct-bugcheck: fix globbing, word splitting and formatting Double quote to prevent globbing and word splitting. Use { cmd1; cmd2; } >> file instead of individual redirects because of XXX