[LEDE-DEV] Removing package overlay functionality

2017-04-16 Thread Philip Prindeville
commit b044bd5921e9644c9df9655bef10cee0af730724
Author: Felix Fietkau 
Date:   Mon Apr 3 12:36:35 2017 +0200

build: remove package makefile overlay functionality

Recent attempts to use it have shown that it does not work properly
except for a few undocumented cases. It's better to remove this now to
avoid having more people fall into the same trap

Signed-off-by: Felix Fietkau 


I was using the overlay functionality, having been steered toward it after my 
suggestion of adding pre- and post-install hooks that could be added by the 
developer to customize the build process was nixed (for instance, if you want 
to run a trivial sed script on a config file which is generated from a .in file 
and therefore hard to patch).

Yousong steered me toward using the Build/IncludeOverlay mechanism (see the 
thread “Makefile Question” around 13 Feb 2017).

Now I abruptly found the overlay mechanism has been deleted, and I don’t recall 
seeing any discussion on whether to do this or not, just the following post 
script after the fact:

> I agree. I've pushed a commit to my staging tree that removes package
> overlay support.

If it’s hard to use, it should be fixed, not removed.  If it can’t be fixed, 
then it should be better documents.

Telling someone to use “method X” and then 2 months later deleting it after 
they’ve spent the time trying to figure out how to use it isn’t cool.

My impression was that LEDE was going to be a little more welcoming to a 
broader developer community.

Yanking the carpet out from under people doesn’t strike me as particularly 
welcoming, nor much of a reward for someone bothering to learn about some of 
the arcane aspects of the system (why bother, if your knowledge could be 
rendered obsolete in the time it takes someone else to snap their fingers?).

I think we can and should do better than this.

-Philip



___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev


[LEDE-DEV] [PATCH] dnsmasq: fix uninitialized varname in init-script

2017-04-16 Thread Bastian Bittorf
minor/cosmetic: fixes the following misleading message:

root@box:~ /etc/init.d/dnsmasq restart
sh: out of range

Signed-off-by: Bastian Bittorf 
---
 package/network/services/dnsmasq/files/dnsmasq.init | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/network/services/dnsmasq/files/dnsmasq.init 
b/package/network/services/dnsmasq/files/dnsmasq.init
index 83553f1..448d3ee 100644
--- a/package/network/services/dnsmasq/files/dnsmasq.init
+++ b/package/network/services/dnsmasq/files/dnsmasq.init
@@ -698,7 +698,7 @@ dnsmasq_start()
 
if [ -x /usr/sbin/odhcpd -a -x /etc/init.d/odhcpd ] ; then
local odhcpd_is_main odhcpd_is_enabled
-   config_get odhcpd_is_main odhcpd maindhcp
+   config_get odhcpd_is_main odhcpd maindhcp 0
/etc/init.d/odhcpd enabled && odhcpd_is_enabled=1 || 
odhcpd_is_enabled=0
 
 
-- 
1.9.1


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev


[LEDE-DEV] CVE-2016-10229 Remote code execution vulnerability in kernel networking subsystem

2017-04-16 Thread yanosz
Hello,

CVE-2016-10229 was patched in android recently. While some distributions
(ie Debian: https://security-tracker.debian.org/tracker/CVE-2016-10229)
are not vulnerable due to having backported parts of the kernel code
before, I wonder about the status in Lede (and OpenWRT).

There are some rumors, that MSG_PEEK might be used in dnsmasq, but I
don't know any details here.

What's the current status in lede?

Thanks,
yanosz
-- 
For those of you without hope, we have rooms with color TV,
cable and air conditioning

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev


Re: [LEDE-DEV] What optimizations does low-end MIPS userspace need?

2017-04-16 Thread Alexandru Ardelean
On Sun, Apr 16, 2017 at 1:47 AM, Jay Carlson  wrote:
>
>> On Apr 15, 2017, at 1:57 AM, Alexandru Ardelean  
>> wrote:
>>
>> On Sat, 15 Apr 2017 at 02:01, Jay Carlson  wrote:
>>
>>> I’ve been fooling around with various userspace toolchain hacks for mips, 
>>> trying to make things faster globally. But then I realized: I don’t know 
>>> what “faster” is. Or what “better” is, in general.
>>>
>>> I want my Python/Firmata apps to launch faster on mt7688, but there is a 
>>> clear metric for winning there; I don’t need your help. :-)
>>
>> Strictly speaking for Python (if you haven't already) you might want to 
>> check some recent changes.
>>
>> Python now ships with bytecode files instead of source.
>> Seems that app startup is improved by even a factor of 9x on some low end 
>> CPUs.
>> Something like 500 msecs to 70 msecs to start a simple Hello World script.
>
> Very cool. That’s
>
> "python: use default host build prefix, remove cross-compile workarounds for 
> host” [1]
>
> and
>
> "python,python3: drop remove .pyc & .pyo files” [2]
>
> right?
>

Ah, last reply got through only to you, and not the list.
I've sent it from my phone, and for some reason, the Plain Text mode
wasn't enabled on it.
Will have to check that ; my browser has it enabled.

The commits are in this PR:
https://github.com/openwrt/packages/pull/4130/commits
Some are cleanups, and a few actually deal with the byte-code changes.

This commit should be the more important one : "python: split source
packages away from compiled packages "
But, it has some pre-work commits.


> --
> Jay Carlson
> n...@nop.com
>
> [0]: Am I supposed to be citing the openwrt package repository? If so, how?

not sure ; i don't know of a rule

> [1]: 
> https://github.com/openwrt/packages/commit/b70b978cc61bdd6fcdc7f8f7bae8ee3ef16baf4a
> [2}: 
> https://github.com/openwrt/packages/commit/05f8d6edf06c93dadab34f14a5fad48449dd7eda
>
>

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev