Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal V3

[John Crispin]

On 13/06/17 21:58, Florian Fainelli wrote:

On 05/28/2017 11:56 PM, John Crispin wrote:

Hi,

here is a V3 of the remerge proposal, I tried to fold all the comments
people made into it, if anything is missing let me know. Please remeber
that post remerge anything can be voted on, so cluttering the proposal
with many details will delay the remerge even more.

Ideally we manage to vote during this week.

ACK from me.

ACK from me also.

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] [PATCH 2/2] ath10k-ct firmware: Tx-hang and EAPOL handling fixes for wave-2 firmware.

[greearb]

From: Ben Greear 

Changes since last LEDE release include:

  *  Fix key-setting bug that broke sending the EAPOL 2/4 in some cases.  This 
was a
 bug I introduced some time back while trying to fix .11r and simplify the 
key
 handling logic.  (Patch to wpa_supplicant fixed the race with sending the 
4/4
 and setting the key...un-patched supplicant will still have this race and 
the 4-way
 auth will not work as reliably.)

  *  Increase amount of active-tids that can be scheduled.  This fixes a 
tx-stall
 seen with many station vdevs.

  *  Fix bug in upstream code that would cause the maximum peer to never be 
scheduled
 for tx.

Signed-off-by: Ben Greear 
---
 package/firmware/ath10k-firmware/Makefile | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/package/firmware/ath10k-firmware/Makefile 
b/package/firmware/ath10k-firmware/Makefile
index 17ff2ca..3fb009e 100644
--- a/package/firmware/ath10k-firmware/Makefile
+++ b/package/firmware/ath10k-firmware/Makefile
@@ -90,24 +90,24 @@ define Download/ath10k-firmware-qca9887-ct
 endef
 $(eval $(call Download,ath10k-firmware-qca9887-ct))
 
-QCA99X0_FIRMWARE_FILE_CT:=firmware-5-ct-full-community-9.bin-lede.002
+QCA99X0_FIRMWARE_FILE_CT:=firmware-5-ct-full-community-9.bin-lede.003
 define Download/ath10k-firmware-qca99x0-ct
   $(call Download/ct-firmware,QCA99X0,ath10k-10-4)
-  HASH:=e3c77077b47d55219f90816a51bf046f5b40c32be5e96bf629b083d873a879ad
+  HASH:=d29f305a1c3824b4854df19c6c962ca2542f00e45b3f133b8b219edc5c5de88e
 endef
 $(eval $(call Download,ath10k-firmware-qca99x0-ct))
 
-QCA9984_FIRMWARE_FILE_CT:=firmware-5-ct-full-community-9.bin-lede.002
+QCA9984_FIRMWARE_FILE_CT:=firmware-5-ct-full-community-9.bin-lede.003
 define Download/ath10k-firmware-qca9984-ct
   $(call Download/ct-firmware,QCA9984,ath10k-9984-10-4)
-  HASH:=610f7747db6b101f4fc21431b776ac640b5977357e5be9aece2349447b9b1d85
+  HASH:=30d671587766f7705f3199ebe779aa47a30e2efc75e47497bb154ff8b784053e
 endef
 $(eval $(call Download,ath10k-firmware-qca9984-ct))
 
-QCA9888_FIRMWARE_FILE_CT:=firmware-5-ct-full-community-9.bin-lede.002
+QCA9888_FIRMWARE_FILE_CT:=firmware-5-ct-full-community-9.bin-lede.003
 define Download/ath10k-firmware-qca9888-ct
   $(call Download/ct-firmware,QCA9888,ath10k-9888-10-4)
-  HASH:=f92e7d7968698af7c6f2d76b31b3645589e03839e15838010ce457c635e5aae6
+  HASH:=60dab2e00ebf4636dd24cba8d03dbc278f50d8ca8244d809a0e932bd977d85ab
 endef
 $(eval $(call Download,ath10k-firmware-qca9888-ct))
 
-- 
2.4.11


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH procd] upgraded: cmake: Find and include uloop.h

[Florian Fainelli]

On 05/31/2017 02:02 PM, Florian Fainelli wrote:
> Add a CMake FIND_PATH and INCLUDE_DIRECTORIES searching for
> libubox/uloop.h. Some external toolchains which do not include standard
> locations would fail to find the header otherwise.
> 
> Signed-off-by: Florian Fainelli 

Applied, I will follow-up on the modules you wrote Matthias, thanks!
-- 
Florian

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal V3

[Florian Fainelli]

On 05/28/2017 11:56 PM, John Crispin wrote:
> Hi,
> 
> here is a V3 of the remerge proposal, I tried to fold all the comments
> people made into it, if anything is missing let me know. Please remeber
> that post remerge anything can be voted on, so cluttering the proposal
> with many details will delay the remerge even more.
> 
> Ideally we manage to vote during this week.

ACK from me.
-- 
Florian

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] dnsmasq: fix error in call of list_contains()

[e9hack]

Hi,

it seems there is a second bug.

[ -n $notinterfaces ] fails, if notinterfaces contains spaces.

Regards,
Hartmut

Am 12.06.2017 um 23:11 schrieb Paul Oranje:
> --- a/package/network/services/dnsmasq/files/dnsmasq.init
> +++ b/package/network/services/dnsmasq/files/dnsmasq.init
> @@ -716,7 +716,7 @@ dnsmasq_ismain()
>   [ $port = "53" ] || return 1
>  
>   config_get notinterfaces "$cfg" notinterface ""
> - [ -n $notinterfaces ] && list_contains $notinterfaces "loopback" || 
> return 1
> + [ -n $notinterfaces ] && list_contains notinterfaces "loopback" || 
> return 1
>  
>   # dnsmasq instance is designated to listen on 127.0.0.1#53.
>   return 0
> 


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH v2] ramips: add support for Ubiquiti EdgeRouter X-SFP

[Kevin Darbyshire-Bryant]

On 12/06/17 21:00, Toke Høiland-Jørgensen wrote:

p.wa...@gmx.at writes:


My SQM configuration was basically just using cake + piece_of_cake.qos,
but that's clearly off topic for now. (I'm also CC'ing this mail to Toke,
the maintainer of sqm-scripts).


If you're crashing the box my guess would be there's a bug in the cake
qdisc somewhere. What happens if you run SQM with fq_codel instead?

-Toke


This isn't the first time I've heard cake implicated in cpu stalls but 
trying to discern a signal in some of the noise is difficult.


Using 'fq_codel' would be a good first elimination round.

For 2nd round elimination:  Cake is the only qdisc to my knowledge that 
pulls apart large 'GSO' (Generic segmentation offload) packets prior to 
sending them up the stack, a process cake calls 'peeling'.  It does this 
to retain control on how to schedule a (up to 64K) 'super packet', 
breaking it up into a series of 1500 byte packets instead.  Some have 
reported 'messing with ethtool' to disable GSO as being helpful.  I know 
not how 'ethtool' works.


Whether this is a bug in the cake peeling code, network interface driver 
is unclear, and again anecdotal evidence suggests this is only seen on 
multi-cpu systems.  I dread to think what happens if one cpu starts 
'grabbing one of those large skbs' for sending purposes, whilst another 
(in cake) is busy breaking it apart, or indeed if that scenario is possible.


Some ideas/thoughts/things to try :-)  Apologies for the continuing hijack.

KDB

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] [PATCH] dnsmasq: fix error in call of list_contains()

[Paul Oranje]

Fixes the first parameter to the call of list_contains() in dnsmasq_ismain()

Signed-off-by: Paul Oranje 
---
Commit a53f8ba6771de64c9c82a2e6867791226f3003cb introduces an error that has not
shown up in my tests of that commit (testing sh script is tough).
Thanks to Hartmut (e9hack).
---
 package/network/services/dnsmasq/Makefile   | 2 +-
 package/network/services/dnsmasq/files/dnsmasq.init | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/network/services/dnsmasq/Makefile 
b/package/network/services/dnsmasq/Makefile
index 35ac6b2891..11baff37e8 100644
--- a/package/network/services/dnsmasq/Makefile
+++ b/package/network/services/dnsmasq/Makefile
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
 
 PKG_NAME:=dnsmasq
 PKG_VERSION:=2.77
-PKG_RELEASE:=4
+PKG_RELEASE:=5
 
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
 PKG_SOURCE_URL:=http://thekelleys.org.uk/dnsmasq/
diff --git a/package/network/services/dnsmasq/files/dnsmasq.init 
b/package/network/services/dnsmasq/files/dnsmasq.init
index fda11401db..8dc11288af 100644
--- a/package/network/services/dnsmasq/files/dnsmasq.init
+++ b/package/network/services/dnsmasq/files/dnsmasq.init
@@ -716,7 +716,7 @@ dnsmasq_ismain()
[ $port = "53" ] || return 1
 
config_get notinterfaces "$cfg" notinterface ""
-   [ -n $notinterfaces ] && list_contains $notinterfaces "loopback" || 
return 1
+   [ -n $notinterfaces ] && list_contains notinterfaces "loopback" || 
return 1
 
# dnsmasq instance is designated to listen on 127.0.0.1#53.
return 0
-- 
2.13.1


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] dnsmasq: fix error in call of list_contains()

[Hans Dedecker]

On Mon, Jun 12, 2017 at 11:11 PM, Paul Oranje  wrote:
> Fixes the first parameter to the call of list_contains() in dnsmasq_ismain()
>
> Signed-off-by: Paul Oranje 
> ---
> Commit a53f8ba6771de64c9c82a2e6867791226f3003cb introduces an error that has 
> not
> shown up in my tests of that commit (testing sh script is tough).
> Thanks to Hartmut (e9hack).
> ---
>  package/network/services/dnsmasq/files/dnsmasq.init | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/network/services/dnsmasq/files/dnsmasq.init 
> b/package/network/services/dnsmasq/files/dnsmasq.init
> index fda11401db..8dc11288af 100644
> --- a/package/network/services/dnsmasq/files/dnsmasq.init
> +++ b/package/network/services/dnsmasq/files/dnsmasq.init
> @@ -716,7 +716,7 @@ dnsmasq_ismain()
> [ $port = "53" ] || return 1
>
> config_get notinterfaces "$cfg" notinterface ""
> -   [ -n $notinterfaces ] && list_contains $notinterfaces "loopback" || 
> return 1
> +   [ -n $notinterfaces ] && list_contains notinterfaces "loopback" || 
> return 1
>
> # dnsmasq instance is designated to listen on 127.0.0.1#53.
> return 0
> --
> 2.13.1
>
Increase PKG_RELEASE as well in the patch.

Hans

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev