Re: [LEDE-DEV] [PATCH 2/3] procd: Don't use syslog before its initialization

2017-03-10 Thread John Crispin
On 11/03/17 01:48, Michal Sojka wrote: When procd starts a rcS script, it captures its stdout and stderr and logs them to syslog. It could happen (and I don't know exactly why), that a rcS scripts produces some output before openlog() is called in procd. The result is that all subsequent logs f

Re: [LEDE-DEV] [PATCH] [ubox] syslog: remove unnecessary sizeof struct between messages

2017-03-12 Thread John Crispin
ole set. John > On Fri, Mar 10, 2017 at 12:57 PM, John Crispin wrote: >> >> >> On 10/03/17 11:06, Dan Bugnar wrote: >>> >>> The next message needs to be written after the data of current message. >>> This was adding "sizeof(

Re: [LEDE-DEV] [PATCH umdns 0/3] Stop storing hosts as services

2017-03-13 Thread John Crispin
se before and after every commit. I tested it in environment with: 1) 17.01.0-rc2 running umdns 2) Android smartphone running Bonjour Browser 3) D-Link DCS-2210L IP camera Acked-by: John Crispin thanks, looks like a nice cleanup Rafał Miłecki (3): Access cached records (instead of services

Re: [LEDE-DEV] [PATCH] Fix refreshing cached A(AAA) records that expire

2017-03-20 Thread John Crispin
-by: Rafał Miłecki Acked-by: John Crispin --- cache.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cache.c b/cache.c index 0e92137..921e612 100644 --- a/cache.c +++ b/cache.c @@ -76,7 +76,7 @@ cache_gc_timer(struct uloop_timeout *timeout) struct cache_serv

Re: [LEDE-DEV] [PATCH umdns] Drop entries cached for interface we're going to delete

2017-03-20 Thread John Crispin
On 20/03/17 12:54, Rafał Miłecki wrote: From: Rafał Miłecki Since we free memory with struct interface we can't keep referencing/using it in cached records or services. Signed-off-by: Rafał Miłecki Acked-by: John Crispin --- interface.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [LEDE-DEV] [PATCH] ipq8064: Fix dwc3 module unloading

2017-03-27 Thread John Crispin
the patch does not explain the mistake. please add that info John On 27/03/17 11:29, Thomas Reifferscheid wrote: Allow module unloading by fixing a mistake Signed-off-by: Thomas Reifferscheid --- target/linux/ipq806x/patches-4.9/0032-phy-add-qcom-dwc3-phy.patch | 2 +- 1 file changed,

Re: [LEDE-DEV] [PATCH fstools] libfstools: add basic documentation of mount functions

2017-03-28 Thread John Crispin
On 27/03/17 13:17, Rafał Miłecki wrote: From: Rafał Miłecki Signed-off-by: Rafał Miłecki Acked-by: John Crispin --- libfstools/mount.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libfstools/mount.c b/libfstools/mount.c index 81176ce..5358536 100644 --- a

Re: [LEDE-DEV] [PATCH] ar71xx: tp-link.mk: always include device version in image and DEVICE_TITLE

2017-03-28 Thread John Crispin
name and DEVICE_TITLE for all TP-Link devices, even if there is only one version of device at the moment. Also, keep DEVICE_TITLE in same format for all TP-Link devices. Signed-off-by: Piotr Dymacz Acked-by: John Crispin --- target/linux/ar71xx/image/tp-link.mk | 108

Re: [LEDE-DEV] [PATCH v2] ar8327: Add workarounds for AR8337 switch.

2017-03-29 Thread John Crispin
On 26/03/17 10:08, Vittorio Gambaletta (VittGam) wrote: - .phy_fixup = ar8327_phy_fixup, + //.phy_fixup = ar8337_phy_fixup, // not needed at the moment .set_mirror_regs = ar8327_set_mirror_regs, .get_arl_entry = ar8327_get_arl_entry, .sw_hw_apply = ar8327_sw_

Re: [LEDE-DEV] /tmp/sysupgrade

2017-04-10 Thread John Crispin
On 10/04/17 14:25, Kenneth Johansson wrote: I found that we touch the file /tmp/sysupgrade in a few places --- git grep "tmp/sysupgrade" | grep touch package/base-files/files/sbin/sysupgrade:touch /tmp/sysupgrade package/system/fstools/files/snapshot:touch /tmp/sysupgrade package/system/p

Re: [LEDE-DEV] /tmp/sysupgrade

2017-04-10 Thread John Crispin
On 10/04/17 15:24, Kenneth Johansson wrote: On 2017-04-10 14:43, John Crispin wrote: On 10/04/17 14:25, Kenneth Johansson wrote: I found that we touch the file /tmp/sysupgrade in a few places --- git grep "tmp/sysupgrade" | grep touch package/base-files/files/sbin/sysupgrade:

Re: [LEDE-DEV] [PATCH 2/2] ipq806x: Add support for ipq40xx subtarget

2017-04-17 Thread John Crispin
On 17/04/17 14:54, Felix Fietkau wrote: On 2017-04-17 13:26, Ram Chandra Jangir wrote: Hi Felix, What's the reason for making it a separate subtarget? We would like to add ipq40xx as subtarget for following reasons. 1. ipq40xx is different SoC than existing ipq806x 2. Would like to have SoC

Re: [LEDE-DEV] FW: UDP throughput caused kernel panic if configured bridge mode in /etc/config/network

2017-04-23 Thread John Crispin
Hi, this is most certainly a bug in the kernel. either the ethernet driver blows up under load or some other memory allocation related bug. it is very common for ethernet to kill boards under load by triggering bugs. John On 24/04/17 05:49, Y.B. Lu wrote: Hi John and Jo-Philipp, Have y

Re: [LEDE-DEV] [PATCH] asterisk-13.x: Add func_periodic_hook module

2017-04-24 Thread John Crispin
On 20/04/17 15:37, Roman Spychała wrote: From: Roman Spychała Signed-off-by: Roman Spychała --- net/asterisk-13.x/Makefile | 1 + 1 file changed, 1 insertion(+) Hi Roman, asterisk is part of the packaged feed on github. please send the patch as a PR there. John diff --git a/

Re: [LEDE-DEV] LEDE git master: possible force-push yesterday?

2017-04-29 Thread John Crispin
On 29/04/17 10:16, Hannu Nyman wrote: I think that I have stumbled upon a possible force-push that has been done on LEDE git master branch yesterday. I submitted yesterday two LEDE PRs in Github and got notified today that they contain extra commits. https://github.com/lede-project/source/p

Re: [LEDE-DEV] [PATCH] ipq806x: Add nand boot support for ipq40xx AP-DK04.1-C1

2017-05-05 Thread John Crispin
On 05/05/17 17:49, Ram Chandra Jangir wrote: This change add nand boot support for IPQ40xx based AP-DK04.1-C1 board using ubi image, also add sysupgrage support for AP-DK04.1-C1 and generates a sysupgrade.tar image. Testing: *Tested on IPQ40xx AP-DK04.1-C1 and IPQ806x AP148 Board: a. NAND b

[LEDE-DEV] openwrt and lede - remerge proposal

2017-05-08 Thread John Crispin
Hi, Felix, Imre and myself had 2 calls last week lasting several hours and discussed the following proposal of conditions for a remerge that we would like to propose and have people vote on. *) branding - the owrt side sees no option of using the lede brand - a (minor) majority voted for ope

Re: [LEDE-DEV] openwrt and lede - remerge proposal

2017-05-08 Thread John Crispin
On 08/05/17 15:29, David Woodhouse wrote: On Mon, 2017-05-08 at 15:19 +0200, John Crispin wrote: *) mailing list - ask david to add the openwrt-adm and openwrt lists - announce the switch to the infradead serves, asking people to unsubscribe if they have privacy issues with this - import the

Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal

2017-05-09 Thread John Crispin
On 09/05/17 09:49, Rafał Miłecki wrote: On 8 May 2017 at 15:19, John Crispin wrote: *) domain - transfer owner ship to SPI for openwrt.org and lede-project.org (...) *) SPI - TBD post remerge This is unclear to me. Are we postponing setting rules with SPI on how they should manage domains

Re: [LEDE-DEV] [PATCH v2 2/3] base-files: put board_name into separate file

2017-05-16 Thread John Crispin
Hi Roman, what is the reasoning behind moving this function to its own file ? John On 09/05/17 11:17, Roman Yeryomin wrote: Signed-off-by: Roman Yeryomin --- package/base-files/files/lib/functions.sh | 4 +--- package/base-files/files/lib/functions/board.sh | 6 ++ 2 files

Re: [LEDE-DEV] [PATCH v2 3/3] ipq806x: migrate to generic board detect infrastructure

2017-05-16 Thread John Crispin
On 09/05/17 11:17, Roman Yeryomin wrote: Signed-off-by: Roman Yeryomin --- .../linux/ipq806x/base-files/etc/board.d/01_leds | 4 +- .../ipq806x/base-files/etc/board.d/02_network | 4 +- target/linux/ipq806x/base-files/etc/diag.sh| 13 +++- .../etc/hotplug.d/firmware/11-at

Re: [LEDE-DEV] [PATCH v2] ipq806x: Add nand boot support for ipq40xx AP-DK04.1-C1

2017-05-16 Thread John Crispin
Hi Ram, please split this path up. there should be one self contained change per patch. John On 11/05/17 18:29, Ram Chandra Jangir wrote: This change add nand boot support for IPQ40xx based AP-DK04.1-C1 board using ubi image, also add sysupgrage support for AP-DK04.1-C1 and generates a

Re: [LEDE-DEV] Build fails with missing libgcrypt dependency

2017-05-16 Thread John Crispin
On 16/05/17 18:18, Mauro Mozzarelli wrote: Two days ago I have done a fresh git pull (from scratch) and I built LEDE without errors (well mwan3 still not working, but that is a different matter because LEDE did build). After the latest update done just right now, LEDE fails to build with the

Re: [LEDE-DEV] [PATCH V2] Support specifying instance name in JSON file

2017-05-18 Thread John Crispin
On 12/05/17 11:08, Rafał Miłecki wrote: From: Rafał Miłecki So far we were using host label as the instance name for every service. This change allows specifying it manually and fallbacks to the label for backward compatibility. Signed-off-by: Rafał Miłecki Acked-by: John Crispin --- V2

[LEDE-DEV] openwrt and lede - remerge proposal V2

2017-05-22 Thread John Crispin
Hi, here is a V2 of the remerge proposal, I tried to fold all the comments people made into it, if anything is missing let me know. John *) branding - the owrt side sees no option of using the lede brand - a (minor) majority voted for openwrt as a name over lede whilst most people s

Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal V2

2017-05-22 Thread John Crispin
On 22/05/17 11:02, Rafał Miłecki wrote: On 05/22/2017 09:40 AM, John Crispin wrote: *) branding - the owrt side sees no option of using the lede brand - a (minor) majority voted for openwrt as a name over lede whilst most people said they did not care - as the last vote had a 100% ACK for a

Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal V2

2017-05-22 Thread John Crispin
On 22/05/17 11:39, Vincenzo Romano wrote: I also agree to everything. With am extra point. 2017-05-22 11:18 GMT+02:00 tapper : *) SPI - nominate a new liaison team (imre and john offer to do this, if anyone else is interested let us know) - inform SPI of the new liaisons, voters and project r

Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal V2

2017-05-23 Thread John Crispin
On 23/05/17 17:29, Zoltan HERPAI wrote: Hi John, John Crispin wrote: here is a V2 of the remerge proposal, I tried to fold all the comments people made into it, if anything is missing let me know. [snip] Please let us know when you'll start a final vote on this proposal, or if you wa

Re: [LEDE-DEV] openwrt and lede - remerge proposal V2

2017-05-24 Thread John Crispin
On 23/05/17 22:42, Hauke Mehrtens wrote: On 05/22/2017 09:40 AM, John Crispin wrote: Hi, here is a V2 of the remerge proposal, I tried to fold all the comments people made into it, if anything is missing let me know. John . *) SPI - nominate a new liaison team (imre and

Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal V2

2017-05-24 Thread John Crispin
heeft Imre Kaloz het volgende geschreven: Hi, On 2017-05-22 03:10, John Crispin wrote: On 22/05/17 11:02, Rafał Miłecki wrote: On 05/22/2017 09:40 AM, John Crispin wrote: *) branding - the owrt side sees no option of using the lede brand - a (minor) majority voted for openwrt as a name over

Re: [LEDE-DEV] [PATCH] imx6: disable UART dma

2017-05-24 Thread John Crispin
On 16/05/17 11:57, Koen Vandeputte wrote: Fixes these prints on boot: [ 13.785600] imx-uart 202.serial: DMA transaction error. [ 13.793134] imx-uart 202.serial: DMA transaction error. [ 13.798721] imx-uart 202.serial: DMA transaction error. These error prints can only be see

Re: [LEDE-DEV] [PATCH 2/2] kernel: kmod-usb-net-pl: Add support for PL-27A1

2017-05-24 Thread John Crispin
On 25/04/17 13:20, Bjørn Mork wrote: Roman Spychała writes: diff --git a/target/linux/generic/patches-4.4/870-usb-plusb-Add-support-for-PL-27A1.patch b/target/linux/generic/patches-4.4/870-usb-plusb-Add-support-for-PL-27A1.patch new file mode 100644 index 00..794a861993 --- /dev/nu

Re: [LEDE-DEV] [PATCH] libre: Add zlib dependency

2017-05-24 Thread John Crispin
On 20/04/17 15:44, Roman Spychała wrote: From: Roman Spychała The patch fails to explain why this is required. please provide that info John Signed-off-by: Roman Spychała --- libs/re/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/re/Makefile b/li

Re: [LEDE-DEV] [PATCH] kernel: add kmod-snd-aloop package

2017-05-24 Thread John Crispin
On 25/04/17 09:46, Felix Fietkau wrote: On 2017-04-25 09:37, Roman Spychała wrote: From: Roman Spychała Signed-off-by: Roman Spychała I'm curious, what are you using this for? - Felix Hi Roman, could you answer felix's question ? i am also inclined to not merge this as i dont see th

Re: [LEDE-DEV] [PATCH ubox v3] logread: Add support for output template

2017-05-24 Thread John Crispin
On 02/05/17 03:38, Henry Chang wrote: From: Henry Chang Hi Henry, the patch fails to explain what it does and why it should be merged. Please add that information John Signed-off-by: Henry Chang --- log/logread.c | 163 --

Re: [LEDE-DEV] [PATCH v5 1/2] ar71xx: Add support for TP-Link MR6400

2017-05-24 Thread John Crispin
Hi On 02/04/17 15:25, Filip Moc wrote: You can flash via tftp recovery (serve factory image as /mr6400_tp_recovery.bin on 192.168.0.66/24, connect to any ethernet port and power on device while holding the reset button). Flashing via OEM web interface does not work. Hardware Specification (v1.

Re: [LEDE-DEV] [PATCH v3 6/6] ipq806x: Enable ubi image for ipq40xx AP-DK04.1-C1 board

2017-05-28 Thread John Crispin
Hi Ram, thanks for splitting the series up, i merged the first patches into my tree, however the final patch fails to apply. could you rebase/resend just that last one please ? John On 25/05/17 01:31, Ram Chandra Jangir wrote: This change enables ubi image for IPQ40xx AP-DK04.1-C1 boar

[LEDE-DEV] openwrt and lede - remerge proposal V3

2017-05-29 Thread John Crispin
(resend, this time as plain text) Hi, here is a V3 of the remerge proposal, I tried to fold all the comments people made into it, if anything is missing let me know. Please remeber that post remerge anything can be voted on, so cluttering the proposal with many details will delay the remerge

Re: [LEDE-DEV] [OpenWrt-Devel] Remerge logo ideas

2017-05-29 Thread John Crispin
On 29/05/17 12:11, Jamie Stuart wrote: Hi, First of all, I’m glad to hear the process of remerging LEDE with OpenWrt is moving forward. For what it’s worth, if prefer the LEDE name (it’s friendlier - ‘leddy’ - and not tied to the name of an old router!) However, it seems the consensus is tha

Re: [LEDE-DEV] [OpenWrt-Devel] Remerge logo ideas

2017-05-29 Thread John Crispin
- accent colours http://i.imgur.com/ZKtcFXo.png On 29 May 2017, at 13:52, John Crispin wrote: On 29/05/17 12:11, Jamie Stuart wrote: Hi, First of all, I’m glad to hear the process of remerging LEDE with OpenWrt is moving forward. For what it’s worth, if prefer the LEDE name (it’s friendlier

Re: [LEDE-DEV] openwrt and lede - remerge proposal V3

2017-05-29 Thread John Crispin
*) rules - owrt will adopt the lede rules and voting system ACK from me aswell. *) branding - the owrt side sees no option of using the lede brand - a (minor) majority voted for openwrt as a name over lede whilst most people said they did not care - as the last vote had a 100% ACK for a

Re: [LEDE-DEV] [PATCH] Fix UBIFS work on Mikrotik RB95x devices

2017-05-31 Thread John Crispin
Hi, please resend the patch with a proper prefix in the subject "ar71xx:" and also an Signed-off-by line added in the description John On 30/05/17 22:30, ad...@yapic.net wrote: From: Sergey Sergeev If nand chip has no NAND_NO_SUBPAGE_WRITE flag on its options ubifs can't use it mtd de

Re: [LEDE-DEV] MT7688 SPI confusion

2017-06-04 Thread John Crispin
flash via SPI and general ideas/inspiration on bridging with RTOS running on MCUs next to an embedded Linux SoC is more than welcome :) Cheers Daniel [1]: commit 877ee7d7f54847b4e95c1feb6de0f5413e2fe7a1 Author: John Crispin Date: Tue Apr 19 21:01:34 2016 + ralink: add spi fix

Re: [LEDE-DEV] [PATCH v2] ramips: add support for Ubiquiti EdgeRouter X-SFP

2017-06-04 Thread John Crispin
its in my staging tree which i will push later today or tomorrow. i pushed nand fixes for v4.9 end of last week, could you try the v4.9 kernel on your board please and let me know if it works ? John On 04/06/17 21:52, Sven Roederer wrote: Hi, I got a notification from patchwork, that thi

Re: [LEDE-DEV] [PATCH v2] ramips: add support for Ubiquiti EdgeRouter X-SFP

2017-06-07 Thread John Crispin
On 07/06/17 01:36, Sven Roederer wrote: John, just checked with master build f500799 as initrd-kernel. Looks fine as I can see from bootlog. Anything special to test? [1.71] MediaTek Nand driver init, version v2.1 Fix AHB virt2phys error [1.72] Allocate 16 byte aligned buffer:

Re: [LEDE-DEV] [PATCH v2] ramips: add support for Ubiquiti EdgeRouter X-SFP

2017-06-09 Thread John Crispin
se also have this issue? Best regards, P. Wassi On 07/06/17 12:10, John Crispin wrote: On 07/06/17 01:36, Sven Roederer wrote: John, just checked with master build f500799 as initrd-kernel. Looks fine as I can see from bootlog. Anything special to test? [1.71] MediaTek Nand dri

Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal V3

2017-06-13 Thread John Crispin
On 13/06/17 21:58, Florian Fainelli wrote: On 05/28/2017 11:56 PM, John Crispin wrote: Hi, here is a V3 of the remerge proposal, I tried to fold all the comments people made into it, if anything is missing let me know. Please remeber that post remerge anything can be voted on, so cluttering

Re: [LEDE-DEV] [PATCH procd] watchdog: add support for starting/stopping kernel watchdog

2017-06-22 Thread John Crispin
ped is set to disabled the watchdog fd will be created again. Signed-off-by: Hans Dedecker Acked-by: John Crispin feel free to merge the patch and update trunk John --- system.c | 6 + watchdog.c | 76 +++--- watch

[LEDE-DEV] mt7621 cpu stalls - need help testing

2017-06-29 Thread John Crispin
Hi, there have been various bug reports related to mt7621 where one of the cores seems to have dead locked. while digging thorugh the SDK i found that the recalibrate the delay loop after powering up all 4 cores. checking /proc/cpuinfo we see that the 4 cores run at different bogo mips. i pus

Re: [LEDE-DEV] mt7621 cpu stalls - need help testing

2017-06-29 Thread John Crispin
On 29/06/17 20:14, Jaap Buurman wrote: Dear John, This patch sounds very very promising! I will compile and test this first come this weekend. Thank you so very much for having a look at this issue :) Yours sincerely, Jaap ___ Lede-dev mailing lis

Re: [LEDE-DEV] [BUG] [lantiq] xrx200 network driver sleeping with spinlock held

2017-07-05 Thread John Crispin
On 03/07/17 18:52, Andrea Merello wrote: Due to some OT reasons I'm compiling LEDE kernel (4.9.31) with several debug checks enabled, and I'm using it on a Lantiq xrx200 board (fritzbox 3370). I've hit a bug (among another one) in lantiq_xrx200.c network driver: in the xrx200_close() function

Re: [LEDE-DEV] adding kernel module packages (kmod-rtc-ds1307) to opkg repos?

2017-07-07 Thread John Crispin
you need to add rtc to FEATURES inside target/linux/$target/Makefile grep FEATURES target/linux/* -r |grep rtc target/linux/ar71xx/nand/target.mk:FEATURES += squashfs nand rtc target/linux/armvirt/Makefile:FEATURES:=fpu pci rtc usb target/linux/gemini/Makefile:FEATURES:=squashfs pci rtc target/li

Re: [LEDE-DEV] [PATCH] ramips: pinctrl: return proper error if pinctrl0 is empty

2017-07-26 Thread John Crispin
On 26/07/17 08:08, Mathias Kresin wrote: Children of the pinctrl0 node are optional. Return EINVAL (=missing) instead of 0. Fixes a hang if the pinctrl0 has no children. Signed-off-by: Mathias Kresin Acked-by: John Crispin --- .../ramips/patches-4.9/0025-pinctrl-ralink-add-pinctrl

[LEDE-DEV] [RFC] kernel patches cleanup

2017-07-31 Thread John Crispin
Hi, I rebased my ages old kernel patch cleanup series. It can be found here [1]. the series annotates all patches and splits them up into 3 folders backports/pending/hacks. I'd like to push this asap if there are no mayor issues as it will be a pain to rebase once again John [1] htt

Re: [LEDE-DEV] [PATCH fstools] libblkid-tiny: add support for UBI superblock

2017-08-01 Thread John Crispin
adds simple code reading UBI version and unique number and setting it in the blkid_probe. Signed-off-by: Rafał Miłecki Acked-by: John Crispin --- CMakeLists.txt| 1 + libblkid-tiny/libblkid-tiny.c | 1 + libblkid-tiny/superblocks.h | 1 + libblkid-tiny/ubi.c

Re: [LEDE-DEV] [RFC] kernel patches cleanup

2017-08-01 Thread John Crispin
On 31/07/17 18:11, John Crispin wrote: Hi, I rebased my ages old kernel patch cleanup series. It can be found here [1]. the series annotates all patches and splits them up into 3 folders backports/pending/hacks. I'd like to push this asap if there are no mayor issues as it will

[LEDE-DEV] domain transfer

2017-08-08 Thread John Crispin
Hi, it looks like the domain was transfered to a new registrar last night. we are expecting that the contact info will also be updated shortly. John ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listi

Re: [LEDE-DEV] [PATCH] uboot-lantiq: Enable TFTP PUT support for backups

2017-08-12 Thread John Crispin
On 12/08/17 19:04, Carl-Daniel Hailfinger wrote: Backing up the current firmware from U-Boot over serial can take hours. Booting a working Linux image for backup purposes is not always an option. Using the tftpput command in U-Boot is the fastest and easiest way. tftpput will upload the content

Re: [LEDE-DEV] What to do when your PR stalls?

2017-08-16 Thread John Crispin
tl:dr ... most folks are on vacation in august John On 16/08/17 21:03, Philip Prindeville wrote: Hi. This was a bit of an issue with OpenWrt and I’m not sure if it’s starting to be a problem with LEDE or if August is just the month when all of Europe shuts down and nothing gets done… I

Re: [LEDE-DEV] Transmit timeouts with mtk_eth_soc and MT7621

2017-08-19 Thread John Crispin
Hi All, i have a staged commit on my laptop that makes all the (upstream) ethernet fixes that i pushed to mt7623 work on mt7621. please hang on for a few more days till i finished testing the support. this will add latest upstream ethernet support + DSA John On 19/08/17 17:06, Mingyu L

Re: [LEDE-DEV] Transmit timeouts with mtk_eth_soc and MT7621

2017-08-19 Thread John Crispin
On 19/08/17 23:13, Kristian Evensen wrote: Hi both, On Sat, 19 Aug 2017 at 20:16, John Crispin <mailto:j...@phrozen.org>> wrote: Hi All, i have a staged commit on my laptop that makes all the (upstream) ethernet fixes that i pushed to mt7623 work on mt7621. pleas

Re: [LEDE-DEV] Transmit timeouts with mtk_eth_soc and MT7621

2017-08-19 Thread John Crispin
On 20/08/17 00:07, Kristian Evensen wrote: On Sat, 19 Aug 2017 at 23:52, John Crispin <mailto:j...@phrozen.org>> wrote: On 19/08/17 23:13, Kristian Evensen wrote: > Hi both, > > On Sat, 19 Aug 2017 at 20:16, John Crispin mailto:j...@phrozen.or

Re: [LEDE-DEV] Transmit timeouts with mtk_eth_soc and MT7621

2017-08-19 Thread John Crispin
On 20/08/17 01:13, Florian Fainelli wrote: On 08/19/2017 03:30 PM, John Crispin wrote: On 20/08/17 00:07, Kristian Evensen wrote: On Sat, 19 Aug 2017 at 23:52, John Crispin mailto:j...@phrozen.org>> wrote: On 19/08/17 23:13, Kristian Evensen wrote: > Hi both, &g

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

2017-08-22 Thread John Crispin
On 23/08/17 05:34, Philip Prindeville wrote: On Aug 22, 2017, at 1:56 PM, Arjen de Korte wrote: Citeren Philip Prindeville : Found the issue, and posted PR #1308 to fix it. One-line fix. On Aug 19, 2017, at 3:06 PM, Philip Prindeville wrote: And it looks like Hannu is way ahead of me

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

2017-08-22 Thread John Crispin
patchset from v4.13-rc" --> Build FAIL Full clone + revert: "1f06858 mediatek: update to latest kernel patchset from v4.13-rc" --> Build FAIL Koen Hi Koen, must be related to target/linux/mediatek/modules.mk in that case. let me have a dig just now John

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

2017-08-22 Thread John Crispin
On 23/08/17 08:32, Arjen de Korte wrote: Citeren John Crispin : On 23/08/17 07:32, Koen Vandeputte wrote: Hi John, This the the hafd part. I've spend a full day on it and found this: Full clone + Check out: "364befe kernel: update 4.4 to 4.4.83" --> Build OK Full

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

2017-08-23 Thread John Crispin
pushed a fix, please retest John ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] MT7620 NAND patch and kernel 4.9

2017-08-24 Thread John Crispin
On 24/08/17 14:22, Robert Marko wrote: Hi, I am working on adding support for Xiaomi Router R3 and most of work is already done. https://wiki.openwrt.org/toh/xiaomi/mir3 Unfortunately, it uses NAND flash for which patch that supported it for MT7620 was dropped when ramips was updated to kernel

Re: [LEDE-DEV] [PATCH 4/4] ramips/RT5350F-OLINUXINO(-EVB) dts: enable ttyS1

2017-08-29 Thread John Crispin
Hi, comment inline On 26/08/17 21:54, Zoltan Gyarmati wrote: The RT5350F's second UART pins are available on the base module and on the EVB as well, so enable it in the device tree. Additionaly, the uartlite@c00 and uart@500 nodes swapped in rt5350.dtsi to keep the serial console as ttyS0.

Re: [LEDE-DEV] [PATCH 2/2] main: add start|stop|flush|reload|restart event handling

2017-08-30 Thread John Crispin
On 28/08/17 09:57, Florian Eckert wrote: Add -e option for fw3 start|stop|flush|reload|restart events. If option is set, then common hotplug events are executed in dir '/etc/hotplug.d/firewall' Hi, this should be made into a generic feature inside procd. there is already hotplug trigger sup

Re: [LEDE-DEV] [PATCH ubox 1/3] kmodloader: fix endianess check

2017-08-30 Thread John Crispin
On 30/08/17 15:23, Hans Dedecker wrote: Use __BYTE_ORDER macro to check system endianess as the macro's __LITTLE_ENDIAN, __BIG_ENDIAN are defined irrespective of the sytem endianess leading to an endianess check failure on big endian systems. Thanks ! Acked-by: John Crispin ... feel

Re: [LEDE-DEV] [PATCH] ramips: Add support for the HNET C108

2017-09-06 Thread John Crispin
On 06/09/17 09:26, Kristian Evensen wrote: Hi, Thanks for the feedback. On Wed, Sep 6, 2017 at 9:03 AM, Mathias Kresin wrote: Not working: * USB port. What does not working means? Not detected? USB devices not powered (but are working with an external powered hub)? Any error messages? No

Re: [LEDE-DEV] LEDE call for vote on remerge proposal V3

2017-09-19 Thread John Crispin
Hi Zoltan, actually its been 29 days since the domain transfer had been completed and ownership has been set properly. i already had a chat with some devs last week about what to do next, people are all very busy with their daytime jobs at the moment and starting on the next step does obviou

Re: [LEDE-DEV] [LEDE-DEV, v2, 07/11] uboot-at91: move BUILD_SUBTARGET from U-Boot/Default to devices

2017-09-20 Thread John Crispin
Hi, it looks like uboot fails to build right now, could you have a look at the issue please ?     John   AS  spl/arch/arm/cpu/armv7/cache_v7_asm.o arch/arm/cpu/armv7/cache_v7_asm.S: Assembler messages: arch/arm/cpu/armv7/cache_v7_asm.S:28: Error: selected processor does not support `dmb'

Re: [LEDE-DEV] [PATCH procd 01/17] utrace: Fix environment initialization

2017-09-21 Thread John Crispin
Hi Michal. sorry for the delay, i am halfway through reviewing your patches. thanks for sending them.     John On 12/09/17 13:12, Michal Sojka wrote: We want to copy the existing environment instead of the new one to itself. Other bugs in this code are fixed in the next commit. Signed-off-

Re: [LEDE-DEV] umdns - TTL restricted to 255

2017-09-25 Thread John Crispin
Hi, rfc6762 has the following ... 11.  Source Address Check    All Multicast DNS responses (including responses sent via unicast)    SHOULD be sent with IP TTL set to 255.  This is recommended to    provide backwards-compatibility with older Multicast DNS queriers    (implementing a draft versi

Re: [LEDE-DEV] umdns - TTL restricted to 255

2017-09-25 Thread John Crispin
in that case its a bug and the code should be changed to only have that restriction on queries     John On 25/09/17 17:21, Philipp Meier wrote: My question is about query (not response). LEDE is ignoring query when TTL != 255. Philipp On 09/25/2017 05:16 PM, John Crispin wrote: Hi

Re: [LEDE-DEV] umdns: query response only every 60s

2017-09-26 Thread John Crispin
On 26/09/17 16:51, Cristian Morales Vega wrote: On 26 September 2017 at 15:41, Philipp Meier wrote: Hi When using umdns I experience the follow not expected behavior: There is no mDNS response sent for a service where an announcement or a response has been sent in the last 60 seconds (see s

Re: [LEDE-DEV] [PATCH] ramips: mt7621: add MT29F2G08ABAE NAND flash support

2017-09-27 Thread John Crispin
--- a/target/linux/ramips/patches-4.9/0039-mtd-add-mt7621-nand-support.patch +++ b/target/linux/ramips/patches-4.9/0039-mtd-add-mt7621-nand-support.patch @@ -4302,7 +4302,7 @@ Signed-off-by: John Crispin +#endif /* __NAND_DEF_H__ */ --- /dev/null +++ b/drivers/mtd/nand/nand_device_list.h

Re: [LEDE-DEV] [PATCH] ramips: mt7621: add MT29F2G08ABAE NAND flash support

2017-09-27 Thread John Crispin
ah, this patches the hacky driver, my bad, i'll merge it On 28/09/17 06:57, John Crispin wrote: Hi Roman, please resend with a fully annotated patch and also make sure to send this upstream please. we stopped accepting mtd chip support patches that did not get sent upstrea

Re: [LEDE-DEV] [PATCH] umdns: Remove incorrect comma in http service json config

2017-09-27 Thread John Crispin
On 26/09/17 10:55, Philipp Meier wrote: Remove trailing comma in http service json configuration file Signed-off-by: Philipp Meier --- json/http.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/json/http.json b/json/http.json index cf60532..2a7b50a 100644 --- a/json/htt

Re: [LEDE-DEV] [PATCH] umdns: Remove incorrect comma in http service json config

2017-09-28 Thread John Crispin
On 28/09/17 09:42, Philipp Meier wrote: On 26/09/17 10:55, Philipp Meier wrote: Remove trailing comma in http service json configuration file Signed-off-by: Philipp Meier --- json/http.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/json/http.json b/json/http.json i

Re: [LEDE-DEV] [PATCH] base-files: create /etc/config/ directory

2017-09-30 Thread John Crispin
/. Without any of these package the system will not boot up fully because the /etc/config/ directory is missing and some init scripts just fail. Make sure all images with the base-files contain a /etc/config/ directory. Signed-off-by: Hauke Mehrtens Acked-by: John Crispin --- package/base-files

Re: [LEDE-DEV] Fix NULL pointer dereferece in at803x_link_change_notify()

2017-10-06 Thread John Crispin
Hi, the subject is missing the prefix On 28/09/17 15:27, Andrey Jr. Melnikov wrote: Hello. please drop the line above Fix NULL pointer dereferece in at803x_link_change_notify(). you just copied the subject here. please explain the bug instead.     John Signed-Off-by: "Andrey Jr. Melnikov

Re: [LEDE-DEV] [PATCH] ar71xx: Fix NULL pointer dereferece in at803x_link_change_notify()

2017-10-07 Thread John Crispin
Hi Andrey, merged Thanks ! next time please add [PATCH V2] and a short explanation what of what the difference between v1 and v2 is below the tear-line     John On 07/10/17 23:00, Andrey Jr. Melnikov wrote: Check pdata pointer before use to avoid OOPS if dev_get_platdata() return NULL. Sig

Re: [LEDE-DEV] [PATCH][RFC] procd: service: add data within the service itself

2017-10-18 Thread John Crispin
Hi Pierre sorry for the late reply, comments inline On 04/10/17 12:50, pme.leb...@gmail.com wrote: From: Pierre Lebleu It gives the ability to create firewall data within the service itself rather than within an instance. Signed-off-by: Pierre Lebleu --- service/service.c | 45 ++

[LEDE-DEV] [PATCH] libubus-req: add data_cb callback handling for ubus notifications

2017-11-01 Thread John Crispin
Signed-off-by: John Crispin --- libubus-req.c | 13 + libubus.h | 3 +++ 2 files changed, 16 insertions(+) diff --git a/libubus-req.c b/libubus-req.c index 0c7d589..92f80fa 100644 --- a/libubus-req.c +++ b/libubus-req.c @@ -253,6 +253,18 @@ ubus_notify_complete_cb(struct

Re: [LEDE-DEV] [PATCH mountd 0/2] mount: improve handling unsupported filesystems

2017-11-06 Thread John Crispin
(e.g. LEDE 17.01 release users) so I found it worth fixing. Rafał Miłecki (2): mount: drop duplicated filesystem check from mount_add_list mount: add mount with ignore=1 for unsupported filesystems mount.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) Acked-by:

Re: [LEDE-DEV] [PATCH procd] add limits.h because it is needed for INT_MAX

2017-11-06 Thread John Crispin
On 23/10/17 17:55, Johannes Wegener wrote: --- trace/trace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/trace/trace.c b/trace/trace.c index 76b6b7f..c471e15 100644 --- a/trace/trace.c +++ b/trace/trace.c @@ -25,6 +25,7 @@ #include #include #include +#include #ifndef PTRAC

Re: [LEDE-DEV] [PATCH 0/2] uboot-at91: fix build error

2017-11-06 Thread John Crispin
On 05/10/17 01:14, Sandeep Sheriker Mallikarjun wrote: This patch series fixes the uboot-at91 build error's. In case when a uboot package is selected of a different subtarget device, the build will fail due to wrong cpu type. Sandeep Sheriker Mallikarjun (2): uboot-at91: remove sama5 platfo

Re: [LEDE-DEV] [PATCH] musl: update to 1.1.17

2017-11-06 Thread John Crispin
On 19/10/17 23:41, Christian Lamparter wrote: This patch updates musl to the latest 1.1.17 release. Rick Felker stated in his release note: " This release fixes numerous bugs affecting visible behavior and safety/internal consistency, including a stack-based buffer overflow in dns parsing and

Re: [LEDE-DEV] [PATCH] kernel: Switch to No-op for the default scheduler.

2017-11-07 Thread John Crispin
j On 07/11/17 19:41, Rosen Penev wrote: most users don't have multithreaded workloads though. On Mon, Nov 6, 2017 at 4:43 PM, Dave Taht wrote: I happen to like deadline schedulers, and at least from a kernel perspective, we have a very large set of multithreaded workloads. So I would not ma

Re: [LEDE-DEV] [PATCH v2] base-files: Don't deconfigure IP settings while using NFS root

2017-11-07 Thread John Crispin
On 06/11/17 15:39, Petr Štetiar wrote: This patch allows me to boot my system with root file system mounted over Network File System (NFS). Without this patch, the boot process ends in the preinit step: init: - preinit - ... + [ eth0 = eth0+ ip link set dev eth0 down nfs: serve

Re: [LEDE-DEV] [PATCH v2] base-files: Don't deconfigure IP settings while using NFS root

2017-11-07 Thread John Crispin
On 08/11/17 08:01, John Crispin wrote: On 06/11/17 15:39, Petr Štetiar wrote: This patch allows me to boot my system with root file system mounted over Network File System (NFS). Without this patch, the boot process ends in the preinit step:     init: - preinit -     ...     + [ eth0

Re: [LEDE-DEV] [PATCH] kernel: bump 4.9 to 4.9.60

2017-11-07 Thread John Crispin
On 06/11/17 17:17, Koen Vandeputte wrote: Refreshed all patches. Compiled on: cns3xxx, imx6 Run-tested on: cns3xxx, imx6 Hi, the target/linux/layerscape/patches-4.9/820-base-soc-Introduce-soc_device_match-interface.patchpatch looks overly large. why is this such a huge change ?     John

Re: [LEDE-DEV] [PATCH][ubox] Add log priority filtering to daemon

2017-11-07 Thread John Crispin
On 11/07/17 17:55, Ron Brash wrote: After wanting to filter logs at the logger level, instead of post log-write, we added a feature such that we can filter within the logd daemon itself. sorry for the late review ... Signed-off-by: “Ron Brash <“ron.br...@gmail.com”> --- log/logd.c | 14 ++

Re: [LEDE-DEV] [PATCH v2][RFC] procd: service: add data within the service itself

2017-11-09 Thread John Crispin
Hi comments inline On 25/10/17 17:59, Pierre Lebleu wrote: It gives the ability to create data within the service itself. Change since v1: - dump the data inside the service rather than in a "*" instance. Signed-off-by: Pierre Lebleu --- service/service.c | 44

Re: [LEDE-DEV] [PATCH] procd: service_data: Support data within the service itself

2017-11-09 Thread John Crispin
On 25/10/17 18:05, Pierre Lebleu wrote: Use the same approach than the service_triggers for the service_data. Signed-off-by: Pierre Lebleu Hi, This one is good to go, once the other patch is fixed.     John --- package/base-files/files/etc/rc.common | 4 package/system/procd/fi

Re: [LEDE-DEV] [PATCH] ar71xx: add support for Ubiquiti Litebeam M5

2017-11-16 Thread John Crispin
Hi Arne, comments inline On 19/10/17 15:56, Arne Zachlod wrote: Specification: - SoC: Atheros AR9342 - Flash: 8 MiB - RAM: 64 MiB - UART: 1x UART on PCB - 115200 8N1 - Ethernet: 1 x 100 Mbit with passive PoE (24V/0.2A) Doesn't work: * Flash via TFTP with Uiquiti Uboot Installation via vendor

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-17 Thread John Crispin
On 07/11/17 21:24, Rosen Penev wrote: Less verbose Signed-off-by: Rosen Penev --- Hi, this does not fix any bugs and is a pure style change. yeah, it might safe a few bytes but i dont see that as a valid trade-off, sorry ...     John interface.c | 22 -- 1 file

  1   2   3   4   5   6   7   8   >