[LEDE-DEV] RFC: splitting up the patches folder

Hi, i have been thinking of how to split up the kernel patches folder in a better way. for a start we have all the backports inside the same folder as our normal patches, unfortunately we have some backports and patches that have in the meantime been sent upstream not numbered as 0xx-*.patch. i

Re: [LEDE-DEV] [PATCH] mdnsd: the service is ignoring questions

On 19/12/2016 16:58, John Crispin wrote: > When a question is incoming the service was incorrectly resettig the > query timeout regardless of it being the right service. This causes > the code to never answer the questions it is being asked. > > Reported-by: Cristian Mora

[LEDE-DEV] [PATCH] mdnsd: the service is ignoring questions

When a question is incoming the service was incorrectly resettig the query timeout regardless of it being the right service. This causes the code to never answer the questions it is being asked. Reported-by: Cristian Morales Vega <crist...@samknows.com> Signed-off-by: John Cris

Re: [LEDE-DEV] [PATCH] mediatek: enable support for vfpv4 and neon

On 19/12/2016 14:56, Christian Lamparter wrote: > On Sunday, December 11, 2016 9:13:56 AM CET John Crispin wrote: >> >> On 25/11/2016 20:57, Christian Lamparter wrote: >>> While researching for the armvirt target, I looked at the >>> existing arm platforms. It t

Re: [LEDE-DEV] [PATCH v2] kernel: bump to 4.4.39

Hi, i merged Kevin's version from github as it used the sha256sum stuff that Felix recently added. the rest was identical afaict John On 19/12/2016 09:24, Koen Vandeputte wrote: > Hi Stijn S., > > I indeed addressed Stijn Tintel (CC'd him in 1st mail) as he kindly > requested not to

Re: [LEDE-DEV] [LEDE-DEV v3] Add support of using device symlinks.

On 19/12/2016 09:48, Nikolay Ledovskikh wrote: >> The patch is missing the subject prefix. please make sure to add it next >> time. I have fixed it for you while merging the patch into my staging tree. > > Thank you very much. > You mean subject prefix (after ..v3] and before "Add support

Re: [LEDE-DEV] [PATCH] ubox: Initialize conditionally uninitialized variabled

On 18/12/2016 01:48, Rosen Penev wrote: > -Wconditional-uninitialized in clang the warning are false positives. please check this next time and add the information to the commit description. also a description is expected to be a sentence or two and not a few words. John > >

Re: [LEDE-DEV] [LEDE-DEV v3] Add support of using device symlinks.

On 19/12/2016 08:37, Nikolay Ledovskikh wrote: >> pong ... >> >> "weekend, that thing where people rest" > > OK. I'll wait for that wonderful moment > The patch is missing the subject prefix. please make sure to add it next time. I have fixed it for you while merging the patch into my staging

Re: [LEDE-DEV] [PATCH] kernel: add KERNEL_DEVMEM and KERNEL_DEVKMEM

hauke-m.de> Acked-by: John Crispin <j...@phrozen.org> > --- > config/Config-kernel.in | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/config/Config-kernel.in b/config/Config-kernel.in > index 3c69c86..3f30013 100644 > --- a/config/Config-kerne

Re: [LEDE-DEV] [LEDE-DEV v3] Add support of using device symlinks.

On 19/12/2016 08:20, Nikolay Ledovskikh wrote: >> It's useful when using multiple usb devices that should be bound to >> certain usb ports. Symlinks are created by hotplug handlers. > > Ping. > pong ... "weekend, that thing where people rest" ___

Re: [LEDE-DEV] [PATCH] libubox: replace strtok with strsep

On 18/12/2016 17:29, Arjen de Korte wrote: > Citeren John Crispin <j...@phrozen.org>: > >> On 16/12/2016 11:10, Felix Fietkau wrote: >>> On 2016-12-16 10:58, John Crispin wrote: >>>> >>>> >>>> On 14/12/2016 06:43, Rosen Penev wrot

Re: [LEDE-DEV] [PATCH] libubox: replace strtok with strsep

On 16/12/2016 11:10, Felix Fietkau wrote: > On 2016-12-16 10:58, John Crispin wrote: >> >> >> On 14/12/2016 06:43, Rosen Penev wrote: >>> strsep is re-entrant whereas strtok not necessarily so. >>> >>> Signed-off by: Rosen Penev <ros...@gmail.co

Re: [LEDE-DEV] [PATCH] libubox: replace strtok with strsep

On 14/12/2016 06:43, Rosen Penev wrote: > strsep is re-entrant whereas strtok not necessarily so. > > Signed-off by: Rosen Penev > --- > ulog.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ulog.c b/ulog.c > index 296605d..985d366 100644 > ---

Re: [LEDE-DEV] [LEDE-DEV, 3/3, v2] uqmi: Prevent 'POLICY MISMATH' error.

On 16/12/2016 10:10, Nikolay Ledovskikh wrote: > Thanks for your comments. I'll update patches with your tips and send > new versions. > and i'll handle them quicker this time :-) > 2016-12-16 11:41 GMT+03:00 Matti Laakso : >>> On 07/12/2016 18:13, Nickolay Ledovskikh

Re: [LEDE-DEV] [LEDE-DEV, 3/3, v2] uqmi: Prevent 'POLICY MISMATH' error.

On 07/12/2016 18:13, Nickolay Ledovskikh wrote: > Add uqmi 'sync' command call to release stalled cid when preparing to > setup new connection. As a result it prevents 'POLICY MISMATCH' errors. > > Signed-off-by: Nickolay Ledovskikh > --- >

Re: [LEDE-DEV] [LEDE-DEV, 2/3, v2] Add support of using device symlinks.

On 07/12/2016 18:13, Nickolay Ledovskikh wrote: > It's useful when using multiple usb devices that should be bound to > certain usb ports. Symlinks are created by hotplug handlers. > > Signed-off-by: Nickolay Ledovskikh > --- >

Re: [LEDE-DEV] [LEDE-DEV, 2/3, v2] Add support of using device symlinks.

On 16/12/2016 08:58, Nikolay Ledovskikh wrote: >> still pending not had time to look into this. it'll take me a moment as >> i am not familiar with the code so i need to find a free moment to >> properly review this, sorry for the delay >> >> John > > OK. I just offer to use 'readlink'

Re: [LEDE-DEV] [LEDE-DEV, 3/3, v3] uqmi: Prevent 'POLICY MISMATCH' error.

Hi, still pending not had time to look into this. it'll take me a moment as i am not familiar with the code so i need to find a free moment to properly review this, sorry for the delay John On 16/12/2016 08:51, Nikolay Ledovskikh wrote: > So. What about patch? 'sync' call allows us not

Re: [LEDE-DEV] [LEDE-DEV, 2/3, v2] Add support of using device symlinks.

Hi, still pending not had time to look into this. it'll take me a moment as i am not familiar with the code so i need to find a free moment to properly review this, sorry for the delay John On 16/12/2016 08:42, Nikolay Ledovskikh wrote: > So what? It's more general and useful when, for

Re: [LEDE-DEV] [PATCH v2 0/2] target: replace realview with new target armvirt

On 16/12/2016 07:42, Yousong Zhou wrote: > On 8 December 2016 at 23:21, Yousong Zhou wrote: >> Changes since PATCH v1 >> >> - Enabled CONFIG_XZ_DEC_BCJ >> - Enabled squashfs rootfs >> >> Changes since RFC v1 >> >> - CONFIG_SMP enabled with CONFIG_NR_CPUS=4 >> -

Re: [LEDE-DEV] mdnsd ignoring questions

On 14/12/2016 17:35, Cristian Morales Vega wrote: > I have found a problem with mdnsd, but since I'm no expert in the > protocol and would prefer to stay that way, could somebody comment on > these? > > The problem is with service_reply_single() >

Re: [LEDE-DEV] Help on porting new device (DCS-933L)

On 14/12/2016 09:22, Luiz Angelo Daros de Luca wrote: > Hi John, > > I did not get your mails. I just saw them on the maillist history. > > My device is labeled A1 (external tag). However, the ID on board is B1 > (and according to openwrt wiki, A1 should use a different SoC). > If I consider

Re: [LEDE-DEV] Help on porting new device (DCS-933L)

On 13/12/2016 09:43, John Crispin wrote: > > > On 13/12/2016 09:17, Luiz Angelo Daros de Luca wrote: >> Hello, >> >> I'm trying to port LEDE to a new device DCS-933L. It's a dlink ip >> camera with 8MB Flash and 64 MB RAM. Currently my branch is published

Re: [LEDE-DEV] [PATCH rpcd 1/2] cmake: Find libubox/blobmsg_json.h

On 11/12/2016 09:12, John Crispin wrote: > > > On 03/12/2016 18:34, Florian Fainelli wrote: >> Add a CMake FIND_PATH and INCLUDE_DIRECTORIES searching for blobmsg_json.h. >> Some external toolchains which do not include standard locations would fail >> to &

Re: [LEDE-DEV] [PATCH] mediatek: enable support for vfpv4 and neon

his information. > This should have the nice side effect that LEDE's phase2 builders > no longer need to built a separate "cortex-a7" target, so this > should free up some resources. > > Cc: John Crispin <j...@phrozen.org> > Signed-off-by: Christian Lamparter <chu

Re: [LEDE-DEV] [PATCH rpcd 1/2] cmake: Find libubox/blobmsg_json.h

On 03/12/2016 18:34, Florian Fainelli wrote: > Add a CMake FIND_PATH and INCLUDE_DIRECTORIES searching for blobmsg_json.h. > Some external toolchains which do not include standard locations would fail to > find the header otherwise. > > Signed-off-by: Florian Fainelli >

Re: [LEDE-DEV] [PATCH netifd] ubus: Display the IPv6 prefix assigned address

; > Signed-off-by: Hans Dedecker <dedec...@gmail.com> Acked-by: John Crispin <j...@phrozen.org> feel free to push this to the tree yourself. i have closed the patchwork ticket for you already John > --- > ubus.c | 11 ++- > 1 file changed, 10 insertions(+), 1

Re: [LEDE-DEV] [PATCH] comgt-ncm: Add support for specifying profile index

Hi Matti i noticed that you remove the ipv6 option/support and this is not mentioned in the commit message. could you elaborate on that one ? John On 06/12/2016 17:52, Matti Laakso wrote: > Add support for specifying a call profile index instead of APN. A > specific index different from

Re: [LEDE-DEV] [PATCH v2] ramips: build factory images for Buffalo WSR-1166DHP/WSR-1166DHP2

it is still in my staging tree. i will drop it and await your V3 John On 10/12/2016 14:34, Naoki FUKAUMI wrote: > hi > > I noticed buffalo-tag fix and mkwsrimg can be used for some other > Buffalo WxR products too. > (probably. I just checked some of official update images for now) > >

Re: [LEDE-DEV] Convert ar71xx to devicetree

On 09/12/2016 10:08, p.wa...@gmx.at wrote: >> looks like the link to privatedns.org is causing this. > > I've just checked on the web server's access log: there > was no bot checking the contents of my site, so it must really be > related to the URI itself. > > As this is not the first time,

Re: [LEDE-DEV] Convert ar71xx to devicetree

looks like the link to privatedns.org is causing this. amazing feature, who wants to send a mail with a privatedns.org to lkml ? On 09/12/2016 09:59, John Crispin wrote: > > > On 09/12/2016 09:40, p.wa...@gmx.at wrote: >>> Done. Pushed the cleanup commit to my staging tr

Re: [LEDE-DEV] Convert ar71xx to devicetree

On 09/12/2016 09:40, p.wa...@gmx.at wrote: >> Done. Pushed the cleanup commit to my staging tree > > Thank you, Felix. This commit works perfectly on DT boards :) > (I did not test it on non-DT devices) > > In the meantime I've prepared DT things here: >

Re: [LEDE-DEV] [PATCH] kernel: make fix extending dtb cmd with bootloader

On 09/12/2016 00:21, Hauke Mehrtens wrote: > This was introduced in kernel 4.4, but broken there and fixed in 4.5. > I would like to activate it, but I am scared about the boot loader > around giving us all sorts of command lines. > > Signed-off-by: Hauke Mehrtens we had

Re: [LEDE-DEV] [PATCH] kernel: Add kmod-ethoc

On 09/12/2016 04:31, Florian Fainelli wrote: > Add the kernel module package for the Opencores.org Ethernet MAC, > depends on PHYLIB. > > Signed-off-by: Florian Fainelli > --- > package/kernel/linux/modules/netdevices.mk | 15 +++ > 1 file changed, 15

Re: [LEDE-DEV] RFC: removing support for old Atheros reference boards

On 08/12/2016 21:27, Felix Fietkau wrote: > On 2016-12-08 21:26, Felix Fietkau wrote: >> Hi all, >> >> support code for some old ar71xx reference boards (e.g. AP83) carries >> quite a bit of specific code that bloats images. I consider it highly >> unlikely that anybody still actually uses this

Re: [LEDE-DEV] Convert ar71xx to devicetree

On 08/12/2016 18:06, Felix Fietkau wrote: > On 2016-12-08 17:31, John Crispin wrote: >> Hi, >> >> i was planning to start working on this in early 2017. i was hoping that >> rather than converting ar71xx to DT we simply create a new target called >> ath79 and sta

Re: [LEDE-DEV] Convert ar71xx to devicetree

On 08/12/2016 18:28, Felix Fietkau wrote: > On 2016-12-08 18:17, John Crispin wrote: >> >> >> On 08/12/2016 18:10, Felix Fietkau wrote: >>> On 2016-12-08 18:08, John Crispin wrote: >>>> >>>> >>>> On 08/12/2016 18:06, Felix Fietk

Re: [LEDE-DEV] Convert ar71xx to devicetree

On 08/12/2016 18:10, Felix Fietkau wrote: > On 2016-12-08 18:08, John Crispin wrote: >> >> >> On 08/12/2016 18:06, Felix Fietkau wrote: >>> On 2016-12-08 17:31, John Crispin wrote: >>>> Hi, >>>> >>>> i was planning to start

Re: [LEDE-DEV] Convert ar71xx to devicetree

On 08/12/2016 17:17, p.wa...@gmx.at wrote: > Hi, > > one of the open ToDos for LEDE is 'Convert ar71xx to devicetree'. > In the last weeks, I've tried some stuff to get myself an idea of what > needs to be done. Currently, I'm in this state: > -) AR9331 devices (TL-WR740-v4, TL-WR741-v4,

Re: [LEDE-DEV] Kernel Oops / panic

Hi, are you using snapshots or building the image yourself ? if it is self built then please enable KALLSYMS and paste the log. John On 08/12/2016 17:14, e9hack wrote: > Hi, > > I'm using a TP-Link Archer C7 (Atheros AR7xxx/AR9xxx). Since my build from > 4.12.2016 ~12:00, the kernel

Re: [LEDE-DEV] [PATCH 1/1] add support for overlaying rootfs content

On 07/12/2016 21:52, Karl Palsson wrote: > > Rafał Miłecki wrote: >> On 7 December 2016 at 16:44, Karl Palsson >> wrote: >>> How is this different from just reverting the commit that stopped >>> this from working? I'm all for this, don't get me wrong,

Re: [LEDE-DEV] [PATCH] kernel: add TI tmp102 and tmp103 temperature sensors

On 07/12/2016 22:45, Hauke Mehrtens wrote: > This just adds the kmods for these kernel modules. > This is found on some Lantiq / Intel reference boards. > > Signed-off-by: Hauke Mehrtens > --- > package/kernel/linux/modules/hwmon.mk | 30 ++ > 1

Re: [LEDE-DEV] [PATCH] Allow sending a fd in a ubus_request

On 08/12/2016 13:47, amine.ahd wrote: > In the current implementation, a fd can be sent in the reply to an existing > request which can be inefficient in certain cases. > Example: when you want to create a pipe between two process with the help of > a 3rd process acting as a manager: you need

Re: [LEDE-DEV] [PATCH uclient] Fix unused results warnings

On 03/12/2016 18:58, Florian Fainelli wrote: > Fixes: > > uclient-http.c:385:8: error: ignoring return value of 'fread', declared with > attribute warn_unused_result [-Werror=unused-result] >fread(, sizeof(val), 1, f); > ^ > > uclient-fetch.c: In function 'main': >

Re: [LEDE-DEV] [PATCH fstools] libfstools: Check return values for fread and system

On 03/12/2016 18:32, Florian Fainelli wrote: > libfstools/rootdisk.c: In function 'rootdisk_volume_identify': > libfstools/rootdisk.c:172:7: error: ignoring return value of 'fread', > declared with attribute warn_unused_result [-Werror=unused-result] > fread(, sizeof(magic), 1, f); >^

Re: [LEDE-DEV] web->wiki switch - short glitch in the matrix

lks, > > This seems to be working perfectly (I did *not* stay up to see if there would > be a glitch). www.lede-project.org and wiki.lede-project.org now lead to the > same site. > > Thanks for all who pitched in. > > Rich > >> On Nov 29, 2016, at 3:42 AM, J

[LEDE-DEV] web->wiki switch - short glitch in the matrix

Hi, we will change DNS now to point the main site at the wiki. if all goes well we wont notice any downtime. John ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] Fwd: [PATCH] ath9k: Add airtime fairness scheduler

On 28/11/2016 14:58, bart van zoest wrote: > Hi Weedy and Toke, > > I am trying to apply the patch using: "curl > https://patchwork.ozlabs.org/patch/699159/raw/ | git apply -v". Is the > following output normal? > > :60: trailing whitespace. > :65: trailing whitespace. > :67: space before

Re: [LEDE-DEV] [PATCH] tools: upslug2: Utilize existing bz2 archive

On 26/11/2016 22:34, Florian Fainelli wrote: > Le 26/11/2016 à 13:33, John Crispin a écrit : >> >> >> On 23/11/2016 22:00, Florian Fainelli wrote: >>> http://downloads.openwrt.org/sources has a copy of the sources, but under >>> tar.bz2 file format, s

Re: [LEDE-DEV] [PATCH] tools: upslug2: Utilize existing bz2 archive

On 23/11/2016 22:00, Florian Fainelli wrote: > http://downloads.openwrt.org/sources has a copy of the sources, but under > tar.bz2 file format, so utilize this one since the SVN server is down. Hi we recently switched to xz from bz2. i think we should just upload a xz file to the mirror

Re: [LEDE-DEV] can I have some feedback about a wrapper to call initscripts

On 22/11/2016 09:51, Jo-Philipp Wich wrote: > Hi Alberto, > > personally I like the service wrapper since it alligns the service > handling with Debian and older CentOS / Redhat distros. > > In its current form though, the script is not providing enough > functionality to justify its existence

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

On 21/11/2016 13:56, John Crispin wrote: > NAK, please dont fiddle with inode counts. change the blocksize or the > default mkfs_ext4 uses. > > John https://git.lede-project.org/?p=project/make_ext4fs.git;a=blob;f=make_ext4fs.c#l281 > > On 12/11/2016 09:26, Bas

Re: [LEDE-DEV] [PATCH] scripts/getver.sh: treat all commits as local if can't find upstream

gt; from e.g. 2200 upstream commits and 20 local ones. > > The new format still provides revision number but also points clearly > that is may be not the upstream one: > r0+2220 > > Signed-off-by: Rafał Miłecki <ra...@milecki.pl> Acked-by: John Crispin < j...@phrozen.org&g

Re: [LEDE-DEV] [PATCH] include: image.mk: ext4: double the default inode counter

NAK, please dont fiddle with inode counts. change the blocksize or the default mkfs_ext4 uses. John On 12/11/2016 09:26, Bastian Bittorf wrote: > A rootfs typically has lots of small files, so the default > counter with 1024 inodes for 16 megabytes partition size can > be too restrictive

Re: [LEDE-DEV] [PATCH] ar71xx: fix drivers/mtd/nand/ar934x_nfc.c

On 16/11/2016 16:35, Rafał Miłecki wrote: > On 16 November 2016 at 12:41, wrote: >>> patch fails to apply to current HEAD. could you check/resend it please >> >> Just checked again on a new git clone - everything is fine here. > > I can confirm it applies cleanly > $ curl

Re: [LEDE-DEV] [PATCH] ar71xx: fix drivers/mtd/nand/ar934x_nfc.c

Hi, patch fails to apply to current HEAD. could you check/resend it please John On 16/11/2016 07:25, p.wa...@gmx.at wrote: > From: Paul Wassi > > Fix the incorrect usage of ar934x_nfc_write_page and > ar934x_nfc_write_page_raw. > Add *page* in the argument list and

Re: [LEDE-DEV] Crash on D-Link DIR-869-A1 (ar71xx) with ath10k / Coova-Chilli

00.0: SWBA > overrun on vdev 0, skipped old beacon > > This is a 64MB RAM unit though and has over half of its memory free before > starting Coova-Chilli. We have the same software running on 32MB units for > many years with 20MB free still. > > Why does it only get O

Re: [LEDE-DEV] [PATCH, usbmode] Extend StandardEject sequence to include LUN 1

Hi, a slightly more elaborate description might be appropriate here John On 08/11/2016 16:39, Benjamin Berg wrote: > Also sending the eject command to LUN 1 is required for some D-Link devices. > > Signed-off-by: Benjamin Berg > Signed-off-by: René van Weert

Re: [LEDE-DEV] rpcd-mod-nosql - prpl funding proposal

Hi Luka, On 10/11/2016 01:23, Luka Perkov wrote: > cache for a period of time some arbitrary (runtime) data. sounds interesting ... procd provides this feature already for managed services. please explain some of the use cases and why you think that existing feature set is not sufficient. also

Re: [LEDE-DEV] Crash on D-Link DIR-869-A1 (ar71xx) with ath10k / Coova-Chilli

can you retry with KALLSYMS enabled such that the stack trace is a little more descriptive please John On 08/11/2016 10:33, James Wood wrote: > Hi, > > I'm trying to use Coova-Chilli on this ar71xx based device which supports > both 2.5 and 5GHz respectively. I'm facing a problem in

Re: [LEDE-DEV] [PATCH] net-snmp: add package snmp-mibs

Hi, please submit patches to the packages feed via a github PR John On 07/11/2016 22:07, Sven Roederer wrote: > this installs the default MIBS-files under /usr/share/snmp/mibs > > Signed-off-by: Sven Roederer > --- > net/net-snmp/Makefile | 23

Re: [LEDE-DEV] [RFC] ADSL Modem Allnet All0333CJ Rev.C / Amazon-SE SoC

Hi Tino, supporting ASE is possible, however once you have the wifi driver and dsl stuff installed there is not much space left for even a webui on the system. there was once support for dgn1000 but it got dropped as it was never really useful. if you want to add support for the allnet router,

Re: [LEDE-DEV] [PATCH] package net/cifs-utils: missing dependency?

Hi Paul, this package is located inside the packages feed. please send the patch as a PR using github. John On 28/10/2016 20:54, p.wa...@gmx.at wrote: > From: Paul Wassi > > Add dependency to kmod-fs-cifs > > Signed-off-by: Paul Wassi > --- >

Re: [LEDE-DEV] [PATCH] brcm47xx: add support for per-device rootfs

On 24/10/2016 21:33, Rafał Miłecki wrote: > From: Rafał Miłecki <ra...@milecki.pl> > > Signed-off-by: Rafał Miłecki <ra...@milecki.pl> Acked-by: John Crispin <j...@phrozen.org> > --- > target/linux/brcm47xx/image/Makefile | 99 > ++

Re: [LEDE-DEV] [PATCH] initramfs: Escape colons in depfile

Hi, this seems to be a backport for the kernel tree. please resend it as a patch adding the actual patch that is being backported to the generic targets patch folder. this would need to be done for 3.18, 4.1 and 4.4 John On 23/09/2016 10:35, Michal Marek wrote: > Special characters are

Re: [LEDE-DEV] [PATCH 1/1] package/utils: Add beep package

Hi, after some time considering i am against merging this into trunk. there are no direct users and no hardware that wont function without. please submit the package as a PR to the packages feed. John On 19/10/2016 16:59, Chris Blake wrote: > This adds the "beep" binary as a package to

Re: [LEDE-DEV] [PATCH v3 02/13] scripts: fix formatting

patch looks good but subject and description do not match John On 06/10/2016 10:50, Jan-Tarek Butt wrote: > remove whitespaces on end of lines > > Signed-off-by: Jan-Tarek Butt > --- > scripts/combined-ext-image.sh | 4 ++-- > scripts/flashing/flash.sh | 6 +++---

Re: [LEDE-DEV] [PATCH v3 01/13] scripts: Double quote to prevent globbing and word splitting

patch looks good but is imho autogenerated and most likely not thoroughly runtime tested. John On 06/10/2016 10:50, Jan-Tarek Butt wrote: > Signed-off-by: Jan-Tarek Butt > --- > scripts/arm-magic.sh | 11 ++- > scripts/clean-package.sh | 2

Re: [LEDE-DEV] [PATCH] package/boot/uboot-kirkwood: bump to upstream 2016.09.01

On 25/10/2016 09:51, p.wa...@gmx.at wrote: > From: Paul Wassi > > Bump U-Boot for Kirkwood to upstream 2016.09.01. Local patches > cleaned up and reworked. Rename OpenWrt/LEDE occurrences. please drop this part while the remerge discussion is underway. i dont want to have to

Re: [LEDE-DEV] [PATCH] [PATCH] fstools: added f2fs to block-mount, really correct indentation

Hi, after some recent changes in the fstools repo this patch applies but causes a compile error. could you please rebase/test/send the patch there were also a lot of whitespace errors. please use tabs to indent your c code John On 21/10/2016 14:54, Alberto Bursi wrote: > added the code

Re: [LEDE-DEV] [PATCH 2/3 v2] ar71xx: add mac partition to the MR12/MR16

On 21/10/2016 13:54, Chris Blake wrote: > On the stock Meraki Firmare for the MR12/MR16, a chunk of SPI space > after u-boot-env is used to store the boards Mac address. Sadly as this > was removed on any device already on OpenWRT/LEDE, moving forward a new, > 64k partition named "mac" will be

Re: [LEDE-DEV] [PATCH] kirkwood: remove redundant code in etc/board.d/02_network

On 23/10/2016 12:42, p.wa...@gmx.at wrote: > From: Paul Wassi > > Remove redundant code: merge boards/cases that share > the same network configuration. > > Signed-off-by: Paul Wassi patch does not apply to current HEAD. what tree did you base this on ?

Re: [LEDE-DEV] [PATCHv2] ipq806x: add support for ZyXEL NBG6817

On 18/10/2016 09:49, André Valentin wrote: > Hi John, > > thanks for your comments. Please take a look: > > Am 18.10.2016 um 08:22 schrieb John Crispin: > >>> +++ b/target/linux/ipq806x/base-files/lib/preinit/04_set_mtd_ipq806x.sh >>> @@ -0,0 +1,21

Re: [LEDE-DEV] [PATCHv2] ipq806x: add support for ZyXEL NBG6817

On 18/10/2016 08:54, J Mo wrote: > > > On 10/17/2016 11:22 PM, John Crispin wrote: >>> +boot_hook_add preinit_main preinit_assign_mtd2block >>> > diff --git >>> > a/target/linux/ipq806x/base-files/lib/preinit/05_set_iface_mac_ipq806x.sh >>&

Re: [LEDE-DEV] [PATCHv2] ipq806x: add support for ZyXEL NBG6817

Hi André, few comments inline On 17/10/2016 21:22, André Valentin wrote: > CPU: 1.8GHz ARM, RAM: 512MB > Storage: 4MiB Serial Flash, 3.9GiB MMC > NIC: 2x1GBit/s, 5 external and 2 internal Port Switch > WiFi: Dualband, ATH10k 2.4GHz, 5GHz MU-MIMO > > Changes: > -remove kernel compression changes

Re: [LEDE-DEV] [PATCH] rsyslog: do not daemonize and allow procd to manage rsyslogd

On 18/10/2016 03:15, Alexis Green wrote: > This allows user to stop and/or restart the daemon. Currently, running > "/etc/init.d/rsyslogd stop" does not stop the daemon once it's started. > > Signed-off-by: Alexis Green > --- > net/rsyslog/files/rsyslog.init | 2 +- > 1 file

Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2

Hi, 2 ordering comments inline. please prefix the patch subject with "ar71xx: " John On 17/10/2016 12:14, Gareth Parker wrote: > The Comfast E380AC is a single port PoE Dual Band AP. > > There are two versions which are only identifiable through the web > administration interface, v1

Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2

On 18/10/2016 07:54, Rafał Miłecki wrote: > On 17 October 2016 at 12:14, Gareth Parker wrote: >> The Comfast E380AC is a single port PoE Dual Band AP. >> >> There are two versions which are only identifiable through the web >> administration interface, v1 has 128mb ram

Re: [LEDE-DEV] [PATCH]fstools: added xfs and f2fs to block-mount

On 16/10/2016 16:23, Alberto Bursi wrote: > Damn, while this patch adds only partial xfs support to fstools (it > allows to mount xfs by block mount). > why only partial ? > Most of fstools have code to use f2fs too already so the fact that block > mount couldn't mount f2fs is 100% a bug

Re: [LEDE-DEV] [RFC 1/1] x86: Add support for the PC Engines APU2 Board

t; > On Sat, Oct 15, 2016 at 2:27 AM, John Crispin <j...@phrozen.org> wrote: >> Hi Chris, >> >> i had quick read of the patch and it looks good at first glance. i >> would suggest you split he patch up as follows. >> >> 1) add the 2 new drivers >>

Re: [LEDE-DEV] [RFC 1/1] x86: Add support for the PC Engines APU2 Board

Hi Chris, i had quick read of the patch and it looks good at first glance. i would suggest you split he patch up as follows. 1) add the 2 new drivers 2) add the support for the new board 3) the patches that add board.d, led, diag ... and all the other parts adding the rootfs board support to

Re: [LEDE-DEV] [PATCH] ct-bugcheck: fix globbing, word splitting and change formatting

On 14/10/2016 18:03, Ben Greear wrote: > On 10/14/2016 08:58 AM, Jan-Tarek Butt wrote: >> Double quote to prevent globbing and word splitting. >> Use short syntax to enhance reading quallity. > > I disagree that the short syntax helps reading quality, > but if others like it then I guess that

Re: [LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

On 06/10/2016 16:44, Bastian Bittorf wrote: > * Jo-Philipp Wich [06.10.2016 16:35]: >> removing the dollar signs lets expressions succeed which would otherwise >> fail - which means it introduces a behavior change. > > thanks for showing this. i must repeat myself: > > before we

Re: [LEDE-DEV] [PATCH v2 1/2] generic: ar8216: improve ar8xxx_is_possible check

Hi comment inline On 04/10/2016 22:55, Christian Lamparter wrote: > The commit "generic: ar8216: add sanity check to ar8216_probe" > (774da6c7a40320a320b28d71291c0e61fcf7bc8a) stated that PHY IDs > should be checked at address 0-4. However, the PHY 4 was > never check by the loop. This patch

Re: [LEDE-DEV] Adding support for dlink dwr-512

Hi, congrats, please make sure to add a proper SoB line when you submit this. also the changes to the kernel config look out of place, please remove them when submitting the patch John On 04/10/2016 22:27, Giuseppe Lippolis wrote: > Dear All, > Today I reach an important milestone in "

Re: [LEDE-DEV] [PATCH 2/3] ct-bugcheck: fix globbing, word splitting and formatting

On 04/10/2016 14:50, Jan-Tarek Butt wrote: > Double quote to prevent globbing and word splitting. > { cmd1; cmd2; } >> file instead of individual redirects. Hi, apart from the SoB missing, this seems to be a resend of a patch sent previously, yet i dont see a list of things that you changed

Re: [LEDE-DEV] [PATCH 1/3] nvram: fix globbing, word splitting and arithmetic variables

On 04/10/2016 14:47, Jan-Tarek Butt wrote: > Double quote to prevent globbing and word splitting. > $/${} is unnecessary on arithmetic variables. > Remove unused variables SoB missing here aswell John > --- > package/utils/nvram/files/nvram.init | 27 +-- > 1

Re: [LEDE-DEV] package/boot/uboot-envtools/files/uboot-envtools.sh

On 04/10/2016 14:35, John Crispin wrote: > > > On 04/10/2016 14:31, Jan-Tarek Butt wrote: >> >> >> On 10/04/16 07:35, Mathias Kresin wrote: >>> 04.10.2016 01:49, Jan-Tarek Butt: >>>> Hi, >>>> >>>> Does anyone und

Re: [LEDE-DEV] package/boot/uboot-envtools/files/uboot-envtools.sh

On 04/10/2016 14:31, Jan-Tarek Butt wrote: > > > On 10/04/16 07:35, Mathias Kresin wrote: >> 04.10.2016 01:49, Jan-Tarek Butt: >>> Hi, >>> >>> Does anyone understand what this "variables" in line 24 to 28 are use [0]? >>> >>> [0] >>>

Re: [LEDE-DEV] [PATCH 1/2] generic: ar8216: fix ar8xxx_is_possible check

On 03/10/2016 22:57, Christian Lamparter wrote: >> > why do you want to remove this check ? imho it does no harm > The C-60 doesn't have a PHY at 3. This caused the check in ar8xxx_is_possible > to fail and the ethernet ports on the C-60. Also, it doesn't look like the > qca8k.c (DSA) driver

Re: [LEDE-DEV] [PATCH 1/2] generic: ar8216: fix ar8xxx_is_possible check

On 01/10/2016 18:33, Christian Lamparter wrote: > The commit "generic: ar8216: add sanity check to ar8216_probe" > (774da6c7a40320a320b28d71291c0e61fcf7bc8a) stated that PHY IDs > should be checked at address 0-4. However, the PHY 4 was > never check by the for loop... And I can't find any

Re: [LEDE-DEV] [patch master 00/15] shell code improvement for /scripts

On 30/09/2016 22:02, Jan-Tarek Butt wrote: > Hi, > > I did some bugfixing and code quality improvement for > all shell scrips inside the dir ./scripts. > > cheers > Tarek Hi Tarek, did you manually generate these or did you use some semantic patching tools. John > Jan-Tarek Butt

Re: [LEDE-DEV] The procd daemon does not handle correctly the instances

t; > For the method "add", it only update the PID as you said so. > > I just purpose to call the method "add" rather than "set" when we specify the > instance. > > > Pierre > > -Original Message- > From: John Crispin [mai

Re: [LEDE-DEV] [wiki]Wiki structure proposals and some questions

it seems to have been rejected with "Message has a suspicious header" i am assuming that microsoft is adding weird headers to your mails. John On 29/09/2016 09:47, Alberto Bursi wrote: > I sent this yesterday and it is still waiting "moderator approval". > > > On 09/28/2016 05:51 PM,

Re: [LEDE-DEV] The procd daemon does not handle correctly the instances

this might actually be solvable int he scripts, will need to take a closer look today John On 29/09/2016 07:20, John Crispin wrote: > procd uses a vlist to store instances in. if oe changes all are > restarted. we need to change this as per my last mail to only restart &

Re: [LEDE-DEV] The procd daemon does not handle correctly the instances

cd_open_service() { > } > > _procd_close_service() { > + local method="set" > + [ -n "$1" ] && method="$1" > + > json_close_object > _procd_open_trigger > service_triggers > _procd_close_trigge

Re: [LEDE-DEV] merging the layerscape target

series, yet the module does not build. i would suggest dropping this patch as it seems totally unrelated and in fact makes it not work. does your target use FSL EHCI support ? John > If have other better ways in dealing with the dependencies in LEDE? > > > Thanks & Best

Re: [LEDE-DEV] The procd daemon does not handle correctly the instances

On 27/09/2016 17:34, Lebleu Pierre wrote: > Hi all, > > I found a bug in the daemon process management. Indeed, when we have several > instances of one daemon such as "dnsmasq" and we want to restart only one > instance, the other instance is killed by procd. It seems procd updates the >

Re: [LEDE-DEV] merging the layerscape target

ith the dependencies in LEDE? > > > Thanks & Best Regards > Jiang Yutang > Hi, ok, looks like this is not related to layerscape. i'll try to have a look at it tonight. John >> -Original Message- >> From: John Crispin [mailto:j...@phrozen.or

Re: [LEDE-DEV] [PATCH v3] ar71xx: add support for Cisco Meraki Z1 Cloud Managed Teleworker Gateway

Hi, comment inline On 20/09/2016 14:14, Chris Blake wrote: > This patch adds support for Cisco's Z1. > Detailed instructions for the flashing the device can > be found in the OpenWrt wiki: > > > Signed-off-by: Chris Blake > ---

<    1   2   3   4   5   6   >