Re: [LEDE-DEV] [PATCH libubox] blobmsg_json: add new functions blobmsg_format_json_value*

On 06/03/2016 11:05 AM, John Crispin wrote: > > > On 01/06/2016 22:27, Matthias Schiffer wrote: >> The current blobmsg_format_json* functions will return invalid JSON when >> the "list" argument is given as false (blobmsg_format_element() will >> output the

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH libubox] blobmsg_json: add new functions blobmsg_format_json_value*

On 06/03/2016 04:55 PM, Eyal Birger wrote: > > Hi, > >> On 3 Jun 2016, at 13:11, Matthias Schiffer <mschif...@universe-factory.net> >> wrote: >> > (snip) >> >> 1) and 2) would allow blobmsg to store everything that json-c can (with the >>

[LEDE-DEV] [PATCH libubox] blobmsg_json: add new functions blobmsg_format_json_value*

roduce new functions which will never print the blob_attr name and thus always produce valid JSON. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- blobmsg_json.c | 49 - blobmsg_json.h | 14 ++ 2 files change

Re: [LEDE-DEV] [PATCH libubox 1/3] Fix various memory management issues

;> return bool instead of void to allow returning an error. >> >> Also fix a buffer size miscalculation in lua/uloop. >> >> Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> >> --- [...] >> @@ -316,8 +323,13 @@ char *blobmsg_format_json_with_c

[LEDE-DEV] [PATCH libubox v2 3/3] blobmsg_json: add new functions blobmsg_format_json_value*

roduce new functions which will never print the blob_attr name and thus always produce valid JSON. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: no changes blobmsg_json.c | 61 -- blobmsg_json.h | 14 +++

[LEDE-DEV] [PATCH libubox v2 2/3] loop: make uloop_run() return the cancelling signal

when uloop_end() was used), so a program using loop an comply with [1]. [1] https://www.cons.org/cracauer/sigint.html Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: keep uloop_cancelled in addition to uloop_status to make libubus happy uloop.c | 9 +++-- u

[LEDE-DEV] [PATCH libubox v2 1/3] Fix various memory management issues

Consistently handle allocation failures. Some functions are changed to return bool or int instead of void to allow returning an error. Also fix a buffer size miscalculation in lua/uloop and use _exit() instead of exit() on errors after forking. Signed-off-by: Matthias Schiffer <msc

Re: [LEDE-DEV] [PATCH libubox 1/3] Fix various memory management issues

On 06/21/2016 12:32 PM, Jo-Philipp Wich wrote: > Hi, > > first of all, thanks for putting work into that - I like the changes in > general. Have a few comments inline below. > > ~ Jo > [...] >> diff --git a/lua/uloop.c b/lua/uloop.c >> index 782b5a5..db89e72 100644 >> --- a/lua/uloop.c >> +++

[LEDE-DEV] [PATCH libubox 1/3] Fix various memory management issues

Consistently handle allocation failures. Some functions are changed to return bool instead of void to allow returning an error. Also fix a buffer size miscalculation in lua/uloop. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- blobmsg.c

[LEDE-DEV] [PATCH libubox v3] blobmsg_json: add new functions blobmsg_format_json_value*

roduce new functions which will never print the blob_attr name and thus always produce valid JSON. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v3: fix rebase breakage v2: no changes blobmsg_json.c | 58 -- blo

Re: [LEDE-DEV] [PATCH 2/2] [RFC] ar71xx/cpe510: use second wifi calibration table

On 05/23/2016 03:23 AM, Alexander Couzens wrote: > The cpe510 has two calibration tables. The first calibration > table requires to modify ath9k driver to work (patched tx gain table). Hi, do you have any idea if the TP-Link firmware also uses the second calibration table, or if their version of

[LEDE-DEV] [PATCH ubus] ubusd: fix systemd socket activation support

). The ENABLE_SYSTEMD default is changed to OFF as the socket activation uses libsystemd, so setting ENABLE_SYSTEMD to ON will now require libsystemd. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- CMakeLists.txt | 15 ++- ubusd.c

Re: [LEDE-DEV] x86_64 kernel panic

On 07/30/2016 11:34 AM, Lucian Cristian wrote: > today's snapshot seems to panic early on kernel boot followed by reset > > > regards > > > Lucian Thanks for the report, I could reproduce the issue (log attached). It crashes at crashlog_init_fs+0x51/0x139, so it's probably caused by

Re: [LEDE-DEV] [PATCH] kernel: adm6996: set carrier status

On 08/07/2016 10:24 PM, Mathias Kresin wrote: > Due to the missing carrier status set, the interface wasn't usable on a > BTHOMEHUB2B after ip link down and up as it is done in preinit. > > Signed-off-by: Mathias Kresin > --- >

Re: [LEDE-DEV] [PATCH libubox 2/3] loop: make uloop_run() return the cancelling signal

On 06/20/2016 09:59 AM, Matthias Schiffer wrote: > When a process quits in response to a signal it handles, it should to so > be re-sending the signal to itself. This especially important for SIGINT, > as is explained in [1]. > > uloop currently hides the reason for quitting u

[LEDE-DEV] [PATCH netifd] system-linux: add VXLAN support

-by: Matthias Schiffer <mschif...@universe-factory.net> --- I've also added a matching proto package in my staging tree. Seems to work fine and I could probably just push this myself, but I prefer to get a least a little review as I'm not really familar with the netifd code. system-linux.c

Re: [LEDE-DEV] [PATCH netifd] system-linux: add VXLAN support

On 02/25/2017 11:51 AM, Felix Fietkau wrote: > On 2017-02-24 20:52, Hans Dedecker wrote: >> On Fri, Feb 24, 2017 at 6:12 PM, Matthias Schiffer >> <mschif...@universe-factory.net> wrote: >>> On 02/24/2017 05:53 PM, Hans Dedecker wrote: >>>> On Thursd

Re: [LEDE-DEV] [PATCH netifd] system-linux: add VXLAN support

On 02/24/2017 05:53 PM, Hans Dedecker wrote: > On Thursday, 23 February 2017 22:23:32 CET Matthias Schiffer wrote: >> VXLAN shares many attributes with the tunnel devices, so it is implemented >> as a new tunnel type. The 'remote' attribute can be used for an unicast >> peer

[LEDE-DEV] [PATCH netifd v3] system-linux: add VXLAN support

-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: Updated to use a nested JSON object for the VXLAN-specific attributes - although one could argue that MAC address, port and "ID" aren't very specific after all, at least I can see us using the same attributes if we ever ad

[LEDE-DEV] [PATCH netifd v2] system-linux: add VXLAN support

-by: Matthias Schiffer <mschif...@universe-factory.net> --- Updated to use a nested JSON object for the VXLAN-specific attributes - although one could argue that MAC address, port and "ID" aren't very specific after all, at least I can see us using the same attributes if we ever add L2TPv3 s

Re: [LEDE-DEV] [PATCH v1 1/2] base-files, mac80211, broadcom-wl: plug-and-play wifi detection

On 10/08/2016 05:41 PM, Christian Lamparter wrote: > Hello, > > On Friday, October 7, 2016 8:29:30 PM CEST Matthias Schiffer wrote: >> On 10/07/2016 08:10 PM, Christian Lamparter wrote: >>> Currently, the wifi detection script is executed as part of >>> the (ea

Re: [LEDE-DEV] [PATCH v1 1/2] base-files, mac80211, broadcom-wl: plug-and-play wifi detection

On 10/08/2016 07:13 PM, Christian Lamparter wrote: > On Saturday, October 8, 2016 6:04:09 PM CEST Matthias Schiffer wrote: >> On 10/08/2016 05:41 PM, Christian Lamparter wrote: >>> On Friday, October 7, 2016 8:29:30 PM CEST Matthias Schiffer wrote: >>>> On 10/07/2016

Re: [LEDE-DEV] [PATCH v1 1/2] base-files, mac80211, broadcom-wl: plug-and-play wifi detection

On 10/07/2016 08:10 PM, Christian Lamparter wrote: > Currently, the wifi detection script is executed as part of > the (early) boot process. Pluggable wifi USB devices, which > are inserted at a later time are not automatically > detected and therefore they don't show up in LuCI. > > A user has

Re: [LEDE-DEV] Ubnt power beam board - back to defaults after reboot

On 10/20/2016 10:20 AM, Jiri Pirko wrote: > Thu, Oct 20, 2016 at 09:48:48AM CEST, garet...@orcon.net.nz wrote: >> Hi Jiri >> This is a common problem on XM devices due to new uboot on AirOS >= 5.6.x, >> although I haven't got any XW devices to test but its possibly the same? >> Try downgrading

Re: [LEDE-DEV] per device rootfs vs multiple devices

On 10/12/2016 12:59 PM, Karl Palsson wrote: > > Hi, > > I was trying to add help text to the generated Kconfig for the > CONFIG_TARGET_MULTI_PROFILE and CONFIG_TARGET_PER_DEVICE_ROOTFS > settings based on some irc conversations with nbd, and was trying > out the behaviour to verify my help text.

Re: [LEDE-DEV] [PATCH v2 2/5] mac80211: use uci to generate wireless config file

On 10/12/2016 01:42 PM, Jonas Gorski wrote: > On 11 October 2016 at 13:37, Christian Lamparter > wrote: >> Previously, wifi detect simply dumped its generated wireless >> configuration out to STDOUT. A second step was needed to >> append the configuration to

Re: [LEDE-DEV] can't install luci

On 10/15/2016 06:30 PM, Torbjorn Jansson wrote: > On 2016-10-15 17:39, Matthias Schiffer wrote: >> On 10/15/2016 05:19 PM, Matthias Schiffer wrote: >>> On 10/15/2016 05:04 PM, Torbjorn Jansson wrote: >>>> Hello >>>> >>>> i decided to gi

Re: [LEDE-DEV] can't install luci

On 10/15/2016 05:04 PM, Torbjorn Jansson wrote: > Hello > > i decided to give lede a try on one of my rasberry pi computers and i > almost immediately ran into problems. > > opkg update works fine, but when i do: > opkg install luci-ssl > > i get: > > root@lede:~# opkg install luci-ssl >

[LEDE-DEV] [PATCH netifd] proto: allow configuring deprecated static IPv6 addresses

-by: Matthias Schiffer <mschif...@universe-factory.net> --- proto.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/proto.c b/proto.c index 23304f3..a8642db 100644 --- a/proto.c +++ b/proto.c @@ -36,6 +36,7 @@ enum { OPT_GATEWAY, OPT

Re: [LEDE-DEV] batman-adv-legacy fails building because of missing dep kmod-crypto-core

On 12/07/2016 12:34 PM, Jochen Demmer wrote: > Hi, > > my current commit: ee55a19a618a30182213937c8c96e056d8f9ed41 > tried to build with the following diffconfig: > https://paste.fedoraproject.org/500943/ > > Getting this error: > > Collected errors: > *

Re: [LEDE-DEV] procd & custom reload support

On 01/13/2017 12:20 PM, Jo-Philipp Wich wrote: > Hi Rafał, > >> What I'd like to achieve is procd monitoring /etc/foo.conf and calling >> my custom reload function if there is a real need to reload service. >> >> Is that possible with procd? > > Yes. This facility was recently introduced with >

Re: [LEDE-DEV] Model detection for UBNT Rocket Ti master

On 11/29/2016 07:48 PM, p.wa...@gmx.at wrote: > Hi Matthias, > > the patch "ar71xx: add model detection for UBNT Rocket Ti" [1] > currently breaks all ar71xx for me. > During bootup, the serial console shows: >> [5.491732] init: - preinit - >> /etc/preinit: /lib/ar71xx.sh: line 85: syntax

Re: [LEDE-DEV] [PATCH] ar71xx: Added support for the TP-Link WA855RE V1

On 12/18/2016 03:35 PM, Federico Cappon wrote: > The device it's similar to the WR841N/ND v9 but without the internal switch. > For install Lede, after soldering the serial, follow the istruction for the > WR841N/ND v9 > > Signed-off-by: Federico Cappon > --- >

[LEDE-DEV] [PATCH netifd v2] proto: allow configuring deprecated static IPv6 addresses

-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- v2: change ip6preferred to ip6deprecated with reversed logic proto.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/proto.c b/proto.c index 23304f3..fd48354 100644 --- a/proto.c +++ b/p

Re: [LEDE-DEV] Release planning

On 12/24/2016 03:40 PM, Daniel Golle wrote: > Hi! > > On Wed, Dec 21, 2016 at 08:13:00PM +0100, Jo-Philipp Wich wrote: >> ... >> # Open questions >> >> - Are there any outstanding changes? >> >> Is there important changes we should wait for before branching the >> release? Is there pending

Re: [LEDE-DEV] [PATCH netifd] proto: allow configuring deprecated static IPv6 addresses

On 12/21/2016 09:51 PM, Hans Dedecker wrote: > On Mon, Dec 19, 2016 at 10:10 PM, Matthias Schiffer > <mschif...@universe-factory.net> wrote: >> On 12/19/2016 10:02 PM, Hans Dedecker wrote: >>> On Sun, Dec 11, 2016 at 3:03 AM, Matthias Schiffer >>> <mschif..

Re: [LEDE-DEV] [PATCH] ar71xx: Added support for the TP-Link WA855RE V1

As mentioned on IRC, I found a few more minor issues. I could fix them up myself when merging your patch, but if you do it yourself, you'll learn a few more things to pay attention to for future patch submissions :) On 12/19/2016 06:06 PM, Federico Cappon wrote: > The device it's similar to the

Re: [LEDE-DEV] Release 17.01.0 binary packages have changed and SDK inconsistency

On 03/29/2017 08:57 PM, Jo-Philipp Wich wrote: > Hi Pau, > > I will not reiterate the arguments made elsewhere in this thread but > merely describe why the version tagged 17.01.0 SDK uses fixed feed sources. > > The main objective here was to make the build reproducible in a way that > you can

[LEDE-DEV] [PATCH netifd] ubus: add interface method to trigger renew event

Not all topology or connectivity changes may be detected by netifd, depending on the underlying technology (e.g. VPN software); this adds a way to explicitly trigger a renew. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- interface.c | 9 + interface.

Re: [LEDE-DEV] mtd: spi-nor: fix Spansion regressions (aliased with Winbond)

On 04/06/2017 05:45 AM, Joe Ayers wrote: > Matthias, was there ever a conclusion to this post: > http://lists.infradead.org/pipermail/linux-mtd/2016-March/066348.html > ? > > My interest from http://www.aredn.org is support for Ubiquiti > PBE-M5-620 and I suspect this issue is related. > > [

[LEDE-DEV] [RFC 06/13] base-files: always use staged sysupgrade

to allow unmounting the root filesystem. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- package/base-files/files/lib/upgrade/common.sh | 123 +++-- package/base-files/files/lib/upgrade/nand.sh | 60 ++-- package/base-files/files/lib/upgrade/

[LEDE-DEV] [RFC 09/13] procd: init: add support for sysupgrades triggered from preinit

This will allow to add sysupgrade support via upgraded for failsafe mode. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the

[LEDE-DEV] [RFC 05/13] procd: remove procd-nand package

We always want to support staged upgrades now, so it's better to include upgraded into the main package. /lib/upgrade/nand.sh is moved to base-files. The procd-nand-firstboot package is removed for now, it may return later as a separate package. Signed-off-by: Matthias Schiffer <msc

[LEDE-DEV] [RFC 13/13] x86: sysupgrade: explicitly rescan disk after writing partition table

e ask_bool that can't work anymore with staged sysupgrade. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- target/linux/x86/base-files/lib/upgrade/platform.sh | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/linux/x86/base-files/lib/upgrade/platf

[LEDE-DEV] [RFC 12/13] ramips: sysupgrade: move nand_do_upgrade call to platform_do_upgrade

All targets with NAND support should gradually move their nand_do_upgrade calls from platform_pre_upgrade to platform_do_upgrade. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- target/linux/ramips/base-files/lib/upgrade/platform.sh | 9 + 1 file chan

[LEDE-DEV] [RFC 07/13] fstools: snapshot: handle jffs2 conversion using upgraded

We can reuse the kill_remaining and run_ramfs facilities of the stage2 run by upgraded. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- package/system/fstools/Makefile | 2 +- package/system/fstools/files/snapshot | 16 +--- 2 files changed, 10 inse

[LEDE-DEV] [RFC 11/13] base-files: add support for staged sysupgrades from failsafe mode

Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- .../base-files/files/lib/preinit/40_run_failsafe_hook | 6 +- .../base-files/files/lib/preinit/99_10_failsafe_login | 11 +++ package/base-files/files/sbin/sysupgrade | 18 +--

[LEDE-DEV] [RFC 01/13] procd: prepare NAND sysupgrade for making upgraded dynamically linked

Use install_bin to copy upgraded with all dependencies. The old name /tmp/upgraded is temporarily retained as a symlink to avoid breaking things. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- package/system/procd/files/nand.sh | 9 + 1 file changed, 5 inse

[LEDE-DEV] [RFC 03/13] procd: upgraded: link dynamically, chroot during exec

, and libraries need to be made available. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the whole series. --- ...raded-link-dynam

[LEDE-DEV] [RFC 04/13] procd: upgraded: add support for passing a "command" argument to stage2

This allows us to make use of upgraded in "snapshot convert" as well. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier test

[LEDE-DEV] [RFC 00/13] Universal staged sysupgrade

n the LEDE repo for now to facilitate testing the series. Matthias Matthias Schiffer (13): procd: prepare NAND sysupgrade for making upgraded dynamically linked procd: system: always support staged sysupgrade procd: upgraded: link dynamically, chroot during exec procd: upgraded: a

[LEDE-DEV] [RFC 02/13] procd: system: always support staged sysupgrade

ade" method that will become unused with the staged sysupgrade is retained for now. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the

[LEDE-DEV] [RFC 08/13] procd: remove code that has become unnecessary after sysupgrade changes

Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the whole series. --- ...-that-has-become-unnecessary-after-sysupg.patch

[LEDE-DEV] [RFC 10/13] base-files: sysupgrade cleanup

in that function on some targets. Targets that do the latter should be fixed eventually to use platform_do_upgrade for that purpose. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- package/base-files/files/lib/upgrade/common.sh | 100 - package/base-files/fil

Re: [LEDE-DEV] [PATCH netifd 1/2] interface-ip: set address indicator flag when IPv6 address lifetime changes

On 03/09/2017 05:32 PM, Hans Dedecker wrote: > Trigger interface update event when IPv6 address lifetime changes by setting > the address indicator flag to inform external subsystems about IPv6 address > lifetime change. > > Signed-off-by: Hans Dedecker AFAICT, this will

Re: [LEDE-DEV] [PATCH netifd 1/2] interface-ip: set address indicator flag when IPv6 address lifetime changes

On 03/09/2017 11:03 PM, Hans Dedecker wrote: > On Thu, Mar 9, 2017 at 10:20 PM, Matthias Schiffer > <mschif...@universe-factory.net> wrote: >> On 03/09/2017 05:32 PM, Hans Dedecker wrote: >>> Trigger interface update event when IPv6 address lifetime changes by settin

Re: [LEDE-DEV] [PATCH 00/12] alternatives support

On 03/06/2017 05:27 PM, Yousong Zhou wrote: > On 5 March 2017 at 23:06, Matthias Schiffer > <mschif...@universe-factory.net> wrote: >> On 03/05/2017 10:31 AM, Yousong Zhou wrote: >>> This patch set tries to make it possible that files serving the same purpose >

Re: [LEDE-DEV] [PATCH 00/12] alternatives support

On 03/05/2017 10:31 AM, Yousong Zhou wrote: > This patch set tries to make it possible that files serving the same purpose > and installed to different locations can be available under the same name > through a symbolic link > > The idea is from alternatives of debian system [1,2]. "ip" command

Re: [LEDE-DEV] [PATCH] firmware-utils: mktplinkfw: rework combined image option

On 07/10/2017 01:02 AM, Piotr Dymacz wrote: > We use combined option in "mktplinkfw" tool for generating initramfs > kernel images and header for kernel inside "safeloader" image type (in > fact, only for TL-WR1043ND v4 at this moment). > > There is also "mktplinkfw-kernel" tool, a stripped-down

[LEDE-DEV] [PATCH 3/4] scripts/getver.sh: include branch name in revision string

assumed. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/getver.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/getver.sh b/scripts/getver.sh index 215bb036a5..f6d18bb3a3 100755 --- a/scripts/getver.sh +++ b/scripts/getver.sh @@ -5,

[LEDE-DEV] [PATCH 1/4] scripts/getver.sh: fail when an invalid commit reference is given

Correctly return "unknown" instead of printing various error messages, followed by a "r0-..." revision. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/getver.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/getver.sh

[LEDE-DEV] [PATCH 4/4] scripts/getver.sh: only consider version override file when no argument is given

Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/getver.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/getver.sh b/scripts/getver.sh index f6d18bb3a3..30cf32ed14 100755 --- a/scripts/getver.sh +++ b/scripts/getver.sh @@ -10,7

[LEDE-DEV] [PATCH 2/4] scripts/getver.sh: drop try_hg

We don't use Mercurial, try_hg didn't understand GET_REV, and its output didn't have anything to do with the way LEDE counts revisions. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- scripts/getver.sh | 9 + 1 file changed, 1 insertion(+), 8 deletions(-)

[LEDE-DEV] [PATCH] scripts: metadata: always resolve dependencies through provides list

logic is that build dependencies are now always interpreted as source package names, instead of putting build and runtime dependencies into the same list. Fixes FS#837. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- Some thorough review would be appreciated, I forgot

Re: [LEDE-DEV] [PATCH 3/4] scripts/getver.sh: include branch name in revision string

On 07/10/2017 02:19 AM, Matthias Schiffer wrote: > To determine the originating branch of a commit, a file called "branch" > must be added to the root of the repository (similar to the existing > "version" file used to override the getver.sh logic). When no suc

Re: [LEDE-DEV] procd: cherry-pick kernel watchdog start/stop to lede-17.01 branch

On 07/12/2017 08:02 PM, Philip Prindeville wrote: > >> On Jul 11, 2017, at 3:19 AM, Hans Dedecker wrote: >> >> Hi, >> >> I would like to cherry-pick the start/stop kernel watchdog support to >> the lede-17.01 procd branch : >> >> e5e99c4 watchdog: add support for

Re: [LEDE-DEV] [PATCH procd v3 1/2] init: Check chroot return value in sysupgrade_exec_upgraded()

d from > preinit") > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> > --- > sysupgrade.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Matthias Schiffer <mschif...@universe-factory.net> You should be able to push this yourself,

Re: [LEDE-DEV] [PATCH procd v2 1/2] init: Check chroot return value in sysupgrade_exec_upgraded()

On 07/18/2017 03:33 AM, Florian Fainelli wrote: > chroot() can fail and its return value should be checked against, in that case > do an exit() since this is a fatal condition that we cannot recover from. > > Fixes: 63789e51ed91 ("init: add support for sysupgrades triggered from > preinit") >

Re: [LEDE-DEV] [RFC 13/13] x86: sysupgrade: explicitly rescan disk after writing partition table

On 04/24/2017 12:19 PM, Jo-Philipp Wich wrote: > Hi, > >> While we're at it, also remove the ask_bool that can't work anymore with >> staged sysupgrade. > > We should find an alternative solution though; like some new flag > "--proceed-even-if-partition-table-changed" to avoid accidentally >

Re: [LEDE-DEV] [RFC 01/13] procd: prepare NAND sysupgrade for making upgraded dynamically linked

On 04/24/2017 10:05 PM, Philip Prindeville wrote: > Inline… > >> On Apr 23, 2017, at 6:06 PM, Matthias Schiffer >> <mschif...@universe-factory.net> wrote: >> >> Use install_bin to copy upgraded with all dependencies. The old name >> /tmp/upgraded is

Re: [LEDE-DEV] openwrt and lede - remerge proposal

On 05/11/2017 12:17 AM, Hauke Mehrtens wrote: > Thanks for moving this forward. > > On 05/08/2017 03:19 PM, John Crispin wrote: >> *) github > . >> >> - obsolete the lede github org after a grace period of 3-6 months > > As long as it does not cost us effort I would like to keep the lede >

Re: [LEDE-DEV] openwrt and lede - remerge proposal

[Some lists were dropped from this thread, adding again] > >>> According to the rules there shall be no personal mail accounts at all. >>> There should be plenty of time until the actual remerge to fade them out >>> and to set up forwarding elsewhere. >> >> I hope you agree that a merge means

[LEDE-DEV] [PATCH v2 03/19] procd: system: always support staged sysupgrade

ade" method that will become unused with the staged sysupgrade is retained for now. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the

[LEDE-DEV] [PATCH v2 01/19] procd: clean up trailing whitespace in nand.sh

Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- package/system/procd/files/nand.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/system/procd/files/nand.sh b/package/system/procd/files/nand.sh index 01dba61644..b5f86e0301

[LEDE-DEV] [PATCH v2 00/19] Universal staged sysupgrade and assorted fixes

sysupgrade fixes (now sysupgrade with growing kernel partition actually works) * apply x86 sysupgrade fixes to sunxi as well It would be great if someone with access to sunxi hardware could test my changes, the sunxi patches were not tested at all. Thanks for the feedback I got so far. Matthias

[LEDE-DEV] [PATCH v2 02/19] procd: prepare NAND sysupgrade for making upgraded dynamically linked

Use install_bin to copy upgraded with all dependencies. The old name /tmp/upgraded is temporarily retained as a symlink to avoid breaking things. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- package/system/procd/files/nand.sh | 5 +++-- 1 file changed, 3 insertions

[LEDE-DEV] [PATCH v2 04/19] procd: upgraded: link dynamically, chroot during exec

, and libraries need to be made available. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the whole series. --- ...raded-link-dynam

[LEDE-DEV] [PATCH v2 14/19] ramips: sysupgrade: move nand_do_upgrade call to platform_do_upgrade

All targets with NAND support should gradually move their nand_do_upgrade calls from platform_pre_upgrade to platform_do_upgrade. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- target/linux/ramips/base-files/lib/upgrade/platform.sh | 9 + 1 file chan

[LEDE-DEV] [PATCH v2 06/19] procd: remove procd-nand package

We always want to support staged upgrades now, so it's better to include upgraded into the main package. /lib/upgrade/nand.sh is moved to base-files. The procd-nand-firstboot package is removed for now, it may return later as a separate package. Signed-off-by: Matthias Schiffer <msc

[LEDE-DEV] [PATCH v2 08/19] fstools: clean up trailing whitespace in snapshot script

Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- package/system/fstools/files/snapshot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/system/fstools/files/snapshot b/package/system/fstools/files/snapshot index c1a5b733f3..baf24f1e3e

[LEDE-DEV] [PATCH v2 15/19] x86: sysupgrade: move partition table change check to platform_check_image

The staged sysupgrade will prevent us from using ask_bool in platform_do_upgrade; therefore, the check is moved to platform_check_image. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- .../linux/x86/base-files/lib/upgrade/platform.sh | 29 +++---

[LEDE-DEV] [PATCH v2 10/19] procd: remove code that has become unnecessary after sysupgrade changes

Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the whole series. --- ...-that-has-become-unnecessary-after-sysupg.patch

[LEDE-DEV] [PATCH v2 05/19] procd: upgraded: add support for passing a "command" argument to stage2

This allows us to make use of upgraded in "snapshot convert" as well. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier test

[LEDE-DEV] [PATCH v2 12/19] base-files: sysupgrade cleanup

in that function on some targets. Targets that do the latter should be fixed eventually to use platform_do_upgrade for that purpose. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- package/base-files/files/lib/upgrade/common.sh | 100 --- package/base-files

[LEDE-DEV] [PATCH v2 07/19] base-files: always use staged sysupgrade

to allow unmounting the root filesystem. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- package/base-files/files/lib/upgrade/common.sh | 123 +++-- package/base-files/files/lib/upgrade/nand.sh | 60 ++-- package/base-files/files/lib/upgrade/

[LEDE-DEV] [PATCH v2 18/19] sunxi: sysupgrade: don't write partitions twice

at 1024KiB). In addition, conv=notrunc is replaced with conv=fsync. It seems this was an oversight, as notrunc doesn't make sense for block devices and all other dd commands use conv=fsync. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- target/linux/sunxi/base-fil

[LEDE-DEV] [PATCH v2 11/19] procd: init: add support for sysupgrades triggered from preinit

This will allow to add sysupgrade support via upgraded for failsafe mode. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> Note: obviously, this patch should go into the procd repo when it is actually applied; it is provided like this for now to allow easier testing of the

[LEDE-DEV] [PATCH v2 16/19] x86: sysupgrade: refactor platform_do_upgrade

By returning early when no upgrade device can be found and handling the SAVE_PARTITIONS=0 case differently, we can get rid of two levels of if. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- .../linux/x86/base-files/lib/upgrade/platform.sh | 69 +++

[LEDE-DEV] [PATCH v2 17/19] x86: sysupgrade: explicitly rescan disk after writing partition table

This should ensure that the kernel partition can be mounted in platform_copy_config when its size has changed. Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- target/linux/x86/base-files/lib/upgrade/platform.sh | 6 ++ 1 file changed, 6 insertions(+) diff

[LEDE-DEV] [PATCH v2 19/19] sunxi: sysupgrade: sync with x86

: sysupgrade: explicitly rescan disk after writing partition table Signed-off-by: Matthias Schiffer <mschif...@universe-factory.net> --- target/linux/sunxi/Makefile| 2 +- .../linux/sunxi/base-files/lib/upgrade/platform.sh | 120 - 2 files changed, 72 inse

Re: [LEDE-DEV] openwrt and lede - remerge proposal V3

On 05/29/2017 09:03 AM, John Crispin wrote: > (resend, this time as plain text) > > Hi, > > here is a V3 of the remerge proposal, I tried to fold all the comments > people made into it, if anything is missing let me know. Please remeber > that post remerge anything can be voted on, so cluttering

[LEDE-DEV] [PATCH uclient] uclient-http: fix Host: header for literal IPv6 addresses

, as neither IPv4 addresses nor DNS names can contain colons. An alternative would be to add a flag to the uclient_url struct; but as this struct is exposed in public headers, such a change could be considered an ABI change, making a backport difficult. Signed-off-by: Matthias Schiffer <msc

Re: [LEDE-DEV] [PATCH 1/5] build: append metadata for supported images.gz

On 11/28/2017 10:51 PM, Christian Lamparter wrote: > Targets that either directly or indirectly set > CONFIG_TARGET_IMAGES_GZIP currently have no way > to append the metadata at the end of new image > creation process. And this is going to be > necessary in order to convert the targets to use >

Re: [LEDE-DEV] [PATCH] base-files: do not backup unchanged files

On 11/24/2017 08:11 AM, Luiz Angelo Daros de Luca wrote: >>> After applied, the list of files in backup in a fresh installation change >>> from: >>> to: >>> >>> root at LEDE:~# sysupgrade  -l >>> /etc/config/dhcp >>> /etc/config/firewall >>> /etc/config/network >>> /etc/config/system >>>

Re: [LEDE-DEV] fixing of image file names

On 12/12/2017 11:01 PM, Jonas Gorski wrote: > On 12 December 2017 at 21:03, Jo-Philipp Wich wrote: >> Hi Piotr, >> >> my rough idea was to somehow tie the manifest generation to the "define >> Device/*" macros present in the image building code because there you >> have all required

Re: [LEDE-DEV] [PATCH] base-files: do not backup unchanged files

On 11/17/2017 10:14 AM, Jonas Gorski wrote: > On 17 November 2017 at 01:41, wrote: >> From: Luiz Angelo Daros de Luca >> >> Only backup /aaa/bbb/ccc if /rom/aaa/bbb/ccc does not exist >> or /aaa/bbb/ccc is different from /rom/aaa/bbb/ccc. >> >>

Re: [LEDE-DEV] LEDE version numbers?

On 11/07/2017 07:23 AM, David Lang wrote: > 17.01 is pointer to a particular commit on the master branch > > I haven't looked at the specific method used for the r# generation, but I > think it's incremented daily r# is the number of commits since the "reboot" tag. If your local branch (e.g.

Re: [LEDE-DEV] [PATCH] hostapd: explicitly set beacon interval for wpa_supplicant

On 11/07/2017 01:19 PM, Sven Eckelmann wrote: > The beacon_int is currently set explicitly for hostapd and when LEDE uses > iw to join an IBSS/mesh. But it was not done when wpa_supplicant was used > to join an encrypted IBSS or mesh. > > This configuration is required when an AP interface is

Re: [LEDE-DEV] LEDE version numbers?

On 11/07/2017 06:20 PM, Bjørn Mork wrote: > Matthias Schiffer <mschif...@universe-factory.net> writes: > >> Fixing our revision numbering to include the branch name to make this more >> or less unambiguous is the intent of the two patches I linked. The commit >&g

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

On 11/08/2017 10:57 AM, Zefir Kurtisi wrote: > On 11/07/2017 09:24 PM, Rosen Penev wrote: >> Less verbose >> >> Signed-off-by: Rosen Penev >> --- >> interface.c | 22 -- >> 1 file changed, 8 insertions(+), 14 deletions(-) >> >> diff --git a/interface.c

  1   2   >