Re: [LEDE-DEV] [PATCH] brcm47xx: open code Makefile entries for all devices

[Rafał Miłecki]

On 20 October 2016 at 08:02, Rafał Miłecki  wrote:
> From: Rafał Miłecki 
>
> If we want to use some of new features like per device rootfs we will
> need this to specify them there.
>
> Signed-off-by: Rafał Miłecki 

Pushed with spaces instead of tabs to match other targets. Thanks Felix.

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] [PATCH] brcm47xx: open code Makefile entries for all devices

[Rafał Miłecki]

From: Rafał Miłecki 

If we want to use some of new features like per device rootfs we will
need this to specify them there.

Signed-off-by: Rafał Miłecki 
---
 target/linux/brcm47xx/image/Makefile | 642 ---
 1 file changed, 527 insertions(+), 115 deletions(-)

diff --git a/target/linux/brcm47xx/image/Makefile 
b/target/linux/brcm47xx/image/Makefile
index b9cdbf4..9076605 100644
--- a/target/linux/brcm47xx/image/Makefile
+++ b/target/linux/brcm47xx/image/Makefile
@@ -77,7 +77,7 @@ define Build/trx-without-loader
 endef
 
 define Build/asus-trx
-   $(STAGING_DIR_HOST)/bin/asustrx -p "$(PRODUCTID)" -i $@ -o $@.new
+   $(STAGING_DIR_HOST)/bin/asustrx -p $(PRODUCTID) -i $@ -o $@.new
mv $@.new $@
 endef
 
@@ -159,69 +159,69 @@ define Device/asus
IMAGE/trx := trx-with-loader | asus-trx
 endef
 
-define AsusDevice
-  define Device/asus-$(1)
-   $$(Device/asus)
-   PRODUCTID := $(2)
-  endef
-  TARGET_DEVICES += asus-$(1)
-endef
-
 define Device/linksys
IMAGES := bin
IMAGE/bin := trx-with-loader | linksys-bin
 endef
 
-define LinksysDevice
-  define Device/linksys-$(1)
-   $$(Device/linksys)
-   DEVICE_ID := $(2)
-   VERSION := $(3)
-  endef
-  TARGET_DEVICES += linksys-$(1)
-endef
-
 define Device/motorola
IMAGES := bin
IMAGE/bin := trx-with-loader | motorola-bin
 endef
 
-define MotorolaDevice
-  define Device/motorola-$(1)
-   $$(Device/motorola)
-   MOTOROLA_DEVICE := $(2)
-  endef
-  TARGET_DEVICES += motorola-$(1)
-endef
-
 define Device/netgear
IMAGES := chk
IMAGE/chk := trx-with-loader | netgear-chk
 endef
 
-define NetgearDevice
-  define Device/netgear-$(1)
-   $$(Device/netgear)
-   NETGEAR_BOARD_ID := $(2)
-   NETGEAR_REGION := $(3)
-  endef
-  TARGET_DEVICES += netgear-$(1)
-endef
-
 #
 # Subtarget generic
 #
 
 ifeq ($(SUBTARGET),generic)
   # BCM4705 with tg3
-  $(eval $(call LinksysDevice,wrt300n-v1.1,EWC2,1.51.2))
-  $(eval $(call LinksysDevice,wrt310n-v1,310N,1.0.10))
-  $(eval $(call LinksysDevice,wrt350n-v1,EWCG,1.04.1))
-  $(eval $(call LinksysDevice,wrt610n-v1,610N,1.0.1))
+  define Device/linksys-wrt300n-v1.1
+   $(Device/linksys)
+   DEVICE_ID := EWC2
+   VERSION := 1.51.2
+  endef
+  TARGET_DEVICES += linksys-wrt300n-v1.1
+
+  define Device/linksys-wrt310n-v1
+   $(Device/linksys)
+   DEVICE_ID := 310N
+   VERSION := 1.0.10
+  endef
+  TARGET_DEVICES += linksys-wrt310n-v1
+
+  define Device/linksys-wrt350n-v1
+   $(Device/linksys)
+   DEVICE_ID := EWCG
+   VERSION := 1.04.1
+  endef
+  TARGET_DEVICES += linksys-wrt350n-v1
+
+  define Device/linksys-wrt610n-v1
+   $(Device/linksys)
+   DEVICE_ID := 610N
+   VERSION := 1.0.1
+  endef
+  TARGET_DEVICES += linksys-wrt610n-v1
 
   # BCMA SoC with SSB WiFi
-  $(eval $(call LinksysDevice,wrt610n-v2,610N,2.0.0))
-  $(eval $(call LinksysDevice,e3000-v1,61XN,1.0.3))
+  define Device/linksys-wrt610n-v2
+   $(Device/linksys)
+   DEVICE_ID := 610N
+   VERSION := 2.0.0
+  endef
+  TARGET_DEVICES += linksys-wrt610n-v2
+
+  define Device/linksys-e3000-v1
+   $(Device/linksys)
+   DEVICE_ID := 61XN
+   VERSION := 1.0.3
+  endef
+  TARGET_DEVICES += linksys-e3000-v1
 
   TARGET_DEVICES += standard
 endif
@@ -293,28 +293,147 @@ ifeq ($(SUBTARGET),legacy)
netgear-wgt634u \
usrobotics-usr5461
 
-  $(eval $(call AsusDevice,wl-300g,WL300g  ))
-  $(eval $(call AsusDevice,wl-320gp,WL320gP ))
-  $(eval $(call AsusDevice,wl-330ge,WL-330gE))
-  $(eval $(call AsusDevice,wl-500gp-v1,WL500gp ))
-  $(eval $(call AsusDevice,wl-500gp-v2,WL500gpv2   ))
-  $(eval $(call AsusDevice,wl-500w,WL500W  ))
-  $(eval $(call AsusDevice,wl-520gu,WL520gu ))
-  $(eval $(call AsusDevice,wl-550ge,WL550gE ))
-  $(eval $(call AsusDevice,wl-hdd25,WLHDD   ))
-  $(eval $(call LinksysDevice,wrt54g3g,W54F,2.20.1))
-  $(eval $(call LinksysDevice,wrt54g3g-em,W3GN,2.20.1))
-  $(eval $(call LinksysDevice,wrt54g,W54G,4.71.1))
-  $(eval $(call LinksysDevice,wrt54gs-v4,W54s,1.09.1))
-  $(eval $(call LinksysDevice,wrt150n,N150,1.51.3))
-  $(eval $(call LinksysDevice,wrt160n-v1,N150,1.50.1))
-  $(eval $(call LinksysDevice,wrt300n-v1,EWCB,1.03.6))
-  $(eval $(call MotorolaDevice,wa840g,2))
-  $(eval $(call MotorolaDevice,we800g,3))
-  $(eval $(call MotorolaDevice,wr850g,1))
-  $(eval $(call NetgearDevice,wgr614-v8,U12H072T00_NETGEAR,2))
-  $(eval $(call NetgearDevice,wndr3300-v1,U12H093T00_NETGEAR,2))
-  $(eval $(call NetgearDevice,wnr834b-v2,U12H081T00_NETGEAR,2))
+  define Device/asus-wl-300g
+   $(Device/asus)
+   PRODUCTID := "WL300g  "
+  endef
+  TARGET_DEVICES += asus-wl-300g
+
+  define Device/asus-wl-320gp
+   $(Device/asus)
+   PRODUCTID := "WL320gP "
+  endef
+  TARGET_DEVICES +=