Re: [LEDE-DEV] ipset-dns - does anybody actually use this?

[jarellczc]

2017-11-27 9:37 GMT+08:00  :
> Patch submitted to enable configuring dnsmasq IPset domain rules
> through LuCI
>
> https://github.com/openwrt/luci/pull/1453
About 1.3 billion people need this.
>
> ___
> Lede-dev mailing list
> Lede-dev@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] ipset-dns - does anybody actually use this?

[Joe Mullally]

Woops, that should have been in reply to
http://lists.infradead.org/pipermail/lede-dev/2017-October/009225.html

On Mon, Nov 27, 2017 at 1:37 AM,   wrote:
> Patch submitted to enable configuring dnsmasq IPset domain rules
> through LuCI
>
> https://github.com/openwrt/luci/pull/1453

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] ipset-dns - does anybody actually use this?

[josephusmullally]

Patch submitted to enable configuring dnsmasq IPset domain rules
through LuCI

https://github.com/openwrt/luci/pull/1453

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] ipset-dns - does anybody actually use this?

[Joe Mullally]

One usecase not currently supported is managing dnsmasq ipset lists 
through LuCI, which enables anyone to maintain them. With ipset-dns 
this is easy to do using LuCI "dhcp.@dnsmasq[0].server" entries.


If it was added, I think ipset-dns could be deprecated.


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] ipset-dns - does anybody actually use this?

[Jason A. Donenfeld]

Hi Stijn,

That was quick. Thanks!

Jason

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] ipset-dns - does anybody actually use this?

[Stijn Tintel]

On 08-10-17 16:20, Jason A. Donenfeld wrote:
> On Sun, Oct 8, 2017 at 3:04 PM, Jason A. Donenfeld  wrote:
>> In that case, I'll take a closer look at the patches LEDE ships for
>> the package and merging them into the upstream repo.
> If you don't wind up removing that, future packages won't need to
> include that patch any longer:
> https://git.zx2c4.com/ipset-dns/commit/?id=ade2cf88e933f4f90451e0a6171f0aa4a523f989
Updated in my staging tree: https://git.lede-project.org/ffd778ea

Thanks,
Stijn

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] ipset-dns - does anybody actually use this?

[Jason A. Donenfeld]

On Sun, Oct 8, 2017 at 3:04 PM, Jason A. Donenfeld  wrote:
> In that case, I'll take a closer look at the patches LEDE ships for
> the package and merging them into the upstream repo.

If you don't wind up removing that, future packages won't need to
include that patch any longer:
https://git.zx2c4.com/ipset-dns/commit/?id=ade2cf88e933f4f90451e0a6171f0aa4a523f989

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] ipset-dns - does anybody actually use this?

[Jason A. Donenfeld]

On Sun, Oct 8, 2017 at 3:02 PM, Florian Fainelli  wrote:
> Still using ipset-dns here, thanks for the reminder, I should probably
> migrate to dnsmasq now to achieve the same goals. There may be other
> users out there though ;)

Cool, okay, good to know!

In that case, I'll take a closer look at the patches LEDE ships for
the package and merging them into the upstream repo.

Jason

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] ipset-dns - does anybody actually use this?

[Florian Fainelli]

Hi,

On 10/07/2017 04:48 PM, Jason A. Donenfeld wrote:
> Hey,
> 
> I'm upstream on the ipset-dns project:
> https://git.zx2c4.com/ipset-dns/about/
> 
> It's a part of a core LEDE repo:
> https://git.lede-project.org/?p=source.git;a=tree;f=package/network/services/ipset-dns
> 
> Pretty soon after I wrote ipset-dns, I thought it was kind of a
> hassle, and so I rewrote the whole thing instead as a patch to
> dnsmasq, submitted it upstream to Simon, and it was accepted. This
> seems to work much more easily than my original ipset-dns, and I
> imagine it's what most people use for that kind of thing on LEDE.
> Funny enough, when I look at the git repo for ipset-dns, on February
> 15, 2013, I made the "initial commit." On the 23rd, 8 days later, I
> added a note telling people to use dnsmasq instead.
> 
> In spite of this, it went into LEDE, and I assume people used it in
> between then and whenever my patch inside of dnsmasq was released in a
> version that was inside of LEDE.
> 
> But this was all years ago.
> 
> So, I'm wondering: does anybody actually use ipset-dns? Does it have
> any utility? As cool as it is having a piece of my code in the core
> LEDE repo, I can't help wondering if it should be removed...

Still using ipset-dns here, thanks for the reminder, I should probably
migrate to dnsmasq now to achieve the same goals. There may be other
users out there though ;)
-- 
Florian

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] ipset-dns - does anybody actually use this?

[Jason A. Donenfeld]

Hey,

I'm upstream on the ipset-dns project:
https://git.zx2c4.com/ipset-dns/about/

It's a part of a core LEDE repo:
https://git.lede-project.org/?p=source.git;a=tree;f=package/network/services/ipset-dns

Pretty soon after I wrote ipset-dns, I thought it was kind of a
hassle, and so I rewrote the whole thing instead as a patch to
dnsmasq, submitted it upstream to Simon, and it was accepted. This
seems to work much more easily than my original ipset-dns, and I
imagine it's what most people use for that kind of thing on LEDE.
Funny enough, when I look at the git repo for ipset-dns, on February
15, 2013, I made the "initial commit." On the 23rd, 8 days later, I
added a note telling people to use dnsmasq instead.

In spite of this, it went into LEDE, and I assume people used it in
between then and whenever my patch inside of dnsmasq was released in a
version that was inside of LEDE.

But this was all years ago.

So, I'm wondering: does anybody actually use ipset-dns? Does it have
any utility? As cool as it is having a piece of my code in the core
LEDE repo, I can't help wondering if it should be removed...

If somebody still uses it, great; that's the beauty of open source.
But if not, it's something to think about removing maybe. Just FYI.

Regards,
Jason

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev