Re: [LEDE-DEV] [PATCH] build: unsilence move command

2017-02-20 Thread Rafał Miłecki 
On 20 February 2017 at 17:48, Thomas Reifferscheid
 wrote:
> The @ sign in front of the "mv" command was significantly suppressing
> output to stdout. When reviewing the make/build logs it was tricking
> me a whole lot and it mad me lose time. Removing the @ sign will get
> stdout and logs right about what happened when.
>
> Signed-off-by: Thomas Reifferscheid 

Looks good to me.

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] [PATCH] build: unsilence move command

2017-02-20 Thread Thomas Reifferscheid 
The @ sign in front of the "mv" command was significantly suppressing
output to stdout. When reviewing the make/build logs it was tricking
me a whole lot and it mad me lose time. Removing the @ sign will get
stdout and logs right about what happened when.

Signed-off-by: Thomas Reifferscheid 
---
 include/image-commands.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/image-commands.mk b/include/image-commands.mk
index 49e4389..c513f19 100644
--- a/include/image-commands.mk
+++ b/include/image-commands.mk
@@ -8,7 +8,7 @@ define Build/uImage
-O linux -T kernel \
-C $(1) -a $(KERNEL_LOADADDR) -e $(if 
$(KERNEL_ENTRY),$(KERNEL_ENTRY),$(KERNEL_LOADADDR)) \
-n '$(if $(UIMAGE_NAME),$(UIMAGE_NAME),$(call 
toupper,$(LINUX_KARCH)) LEDE Linux-$(LINUX_VERSION))' -d $@ $@.new
-   @mv $@.new $@
+   mv $@.new $@
 endef
 
 define Build/buffalo-enc
-- 
2.1.4


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev