Re: [LEDE-DEV] [PATCH] iptables: link extension libraries with -lm

2018-04-30 Thread Alin Năstac
On Mon, Apr 30, 2018 at 7:58 AM, John Crispin wrote: > > > On 27/04/18 16:05, Alin Năstac wrote: >> >> According to "Automatic variables" chapter of make manual, $* expands >> to the pattern matched by % in an implicit rule. >> However, the make rules in which this patch use the

Re: [LEDE-DEV] [PATCH] iptables: link extension libraries with -lm

2018-04-29 Thread John Crispin
On 27/04/18 16:05, Alin Năstac wrote: According to "Automatic variables" chapter of make manual, $* expands to the pattern matched by % in an implicit rule. However, the make rules in which this patch use the $* variable is an explicit rule, hence $* expansion will be empty. On Fri, Apr 27,

Re: [LEDE-DEV] [PATCH] iptables: link extension libraries with -lm

2018-04-27 Thread Alin Năstac
According to "Automatic variables" chapter of make manual, $* expands to the pattern matched by % in an implicit rule. However, the make rules in which this patch use the $* variable is an explicit rule, hence $* expansion will be empty. On Fri, Apr 27, 2018 at 8:41 AM, John Crispin

Re: [LEDE-DEV] [PATCH] iptables: link extension libraries with -lm

2018-04-27 Thread Alin Năstac
Hi John, I forced CONFIG_NETFILTER_XT_MATCH_STATISTIC=y in my kernel config by adding it to openwrt/target/linux/brcm63xx/config-4.1 . However, you have to do a complete build from scratch, I noticed that removing iptables build directory and related files in openwrt/staging_dir/target-*/pkginfo

Re: [LEDE-DEV] [PATCH] iptables: link extension libraries with -lm

2018-04-27 Thread John Crispin
On 24/04/18 10:05, Alin Nastac wrote: This fixes an iptables link error when kernel config include CONFIG_NETFILTER_XT_MATCH_STATISTIC=y related to the missing -lm argument on the linker command line. Error is caused by the odd looking linker argument ${$*_LIBADD} which get expanded to an

[LEDE-DEV] [PATCH] iptables: link extension libraries with -lm

2018-04-24 Thread Alin Nastac
This fixes an iptables link error when kernel config include CONFIG_NETFILTER_XT_MATCH_STATISTIC=y related to the missing -lm argument on the linker command line. Error is caused by the odd looking linker argument ${$*_LIBADD} which get expanded to an empty string. Signed-off-by: Alin Nastac