Re: [LEDE-DEV] [PATCH] libubox: Fix calloc_a() to return mem aligned pointers

2017-02-24 Thread Ted Hess
-Original Message- From: Felix Fietkau Sent: Friday, February 24, 2017 3:39 AM To: Ted Hess ; Yousong Zhou ; lede-dev Subject: Re: [LEDE-DEV] [PATCH] libubox: Fix calloc_a() to return mem aligned pointers On 2017-02-24 03:37, Ted Hess wrote: Yousong - As a side note to your side

Re: [LEDE-DEV] [PATCH] libubox: Fix calloc_a() to return mem aligned pointers

2017-02-24 Thread Felix Fietkau
On 2017-02-24 03:37, Ted Hess wrote: > Yousong - > > As a side note to your side note - If you examine the actual > mechanics of the allocation, the memory block is indeed size aligned to > (4*sizeof(size_t)), but the actual pointer returned is offset of > (2*sizeof(size_t)) within the block. As

Re: [LEDE-DEV] [PATCH] libubox: Fix calloc_a() to return mem aligned pointers

2017-02-23 Thread Yousong Zhou
On 24 February 2017 at 08:30, Ted Hess <th...@kitschensync.net> wrote: > > > -Original Message- From: Yousong Zhou > Sent: Thursday, February 23, 2017 7:15 PM > To: Ted Hess > Cc: lede-dev > Subject: Re: [LEDE-DEV] [PATCH] libubox: Fix calloc_a() to re

Re: [LEDE-DEV] [PATCH] libubox: Fix calloc_a() to return mem aligned pointers

2017-02-23 Thread Ted Hess
-Original Message- From: Yousong Zhou Sent: Thursday, February 23, 2017 7:15 PM To: Ted Hess Cc: lede-dev Subject: Re: [LEDE-DEV] [PATCH] libubox: Fix calloc_a() to return mem aligned pointers On 24 February 2017 at 05:20, Ted Hess <th...@kitschensync.net> wrote: The c

[LEDE-DEV] [PATCH] libubox: Fix calloc_a() to return mem aligned pointers

2017-02-23 Thread Ted Hess
The current implementation of calloc_a() returns packed pointers for the extra arguments. These packed, unaligned, pointers are OK for a lot of architectures, but not all. This patch will aligned the pointers returned in a manner congruent with malloc(). I do not believe the extra padding overhead