Re: [LEDE-DEV] [PATCH] mt7621: add support for WeVO W2914NS v2

2016-11-17 Thread Mathias Kresin
17.11.2016 14:50, perillamint: Signed-off-by: Yong-hyu Ban Hi, I will set this patch to "changes requested" in patchwork. As you already noticed by yourself, not all changes that I've requested for v1 are addressed properly. Please use the --annotate option of git

Re: [LEDE-DEV] [PATCH] mt7621: add support for WeVO W2914NS v2

2016-11-17 Thread Mathias Kresin
17.11.2016 03:11, perillamint: Hi, Mathias Kresin. It seems its Ethernet LEDs are directly hooked into switch chip. It flashes without defining them in DTB. I dunno about where WLAN LEDs are hooked. I failed to drive them with sysfs gpio driver. It might be that they are driven directly by

Re: [LEDE-DEV] [PATCH] mt7621: add support for WeVO W2914NS v2

2016-11-16 Thread perillamint
Hi, Mathias Kresin. It seems its Ethernet LEDs are directly hooked into switch chip. It flashes without defining them in DTB. I dunno about where WLAN LEDs are hooked. I failed to drive them with sysfs gpio driver. I tried LED blinker script in https://wiki.openwrt.org/doc/hardware/port.gpio

Re: [LEDE-DEV] [PATCH] mt7621: add support for WeVO W2914NS v2

2016-11-16 Thread Mathias Kresin
Hi, find my comments inline. 2016-11-16 12:47 GMT+01:00 perillamint : > From: "Yong-hyu, Ban" > > Signed-off-by: Yong-hyu, Ban > --- > .../linux/ramips/base-files/etc/board.d/02_network | 1 + >

[LEDE-DEV] [PATCH] mt7621: add support for WeVO W2914NS v2

2016-11-16 Thread perillamint
From: "Yong-hyu, Ban" Signed-off-by: Yong-hyu, Ban --- .../linux/ramips/base-files/etc/board.d/02_network | 1 + target/linux/ramips/base-files/lib/ramips.sh | 3 + .../ramips/base-files/lib/upgrade/platform.sh | 1 +