Re: [LEDE-DEV] [PATCH RFC 2/3] openvpn: use proper quoting of push option in openvpn.config

2016-12-10 Thread Felix Fietkau
On 2016-12-09 21:07, Magnus Kroken wrote: > OpenVPN requires arguments to --push to be enclosed in double quotes. > A single set of quotes is stripped when the UCI config is parsed. > Enclosing in double and single quotes results in a proper configuration. > > This does not cause errors in OpenVPN

Re: [LEDE-DEV] [PATCH RFC 2/3] openvpn: use proper quoting of push option in openvpn.config

2016-12-09 Thread Magnus Kroken
Hi P On 09.12.2016 23.34, p.wa...@gmx.at wrote: What about doing the 'correct' quotation in the init script? I.e. removing the 'push' option from the append_params list and instead do the workaround for quoatition there. Thanks for making me rethink this. I thought about it when I worked on t

Re: [LEDE-DEV] [PATCH RFC 2/3] openvpn: use proper quoting of push option in openvpn.config

2016-12-09 Thread p . wassi
Hi Magnus, > This does not cause errors in OpenVPN 2.3, but OpenVPN 2.4 fails to start > with unquoted push arguments. > > This fixes FS#290 by way of documentation, but existing configurations > will need editing to work with OpenVPN 2.4. What about doing the 'correct' quotation in the init scr

[LEDE-DEV] [PATCH RFC 2/3] openvpn: use proper quoting of push option in openvpn.config

2016-12-09 Thread Magnus Kroken
OpenVPN requires arguments to --push to be enclosed in double quotes. A single set of quotes is stripped when the UCI config is parsed. Enclosing in double and single quotes results in a proper configuration. This does not cause errors in OpenVPN 2.3, but OpenVPN 2.4 fails to start with unquoted p