Re: [LEDE-DEV] [PATCH v2] base-files: ensure reset only works if an overlay exists

2016-10-20 Thread Rafał Miłecki
On 20 October 2016 at 08:11, Chris Blake wrote: > I agree that would work in terms of functionality, but the issue with > that logic is if you hold the button over 5 seconds, the system LED > will start flashing (as expected) but then no action is taken on the > board.

Re: [LEDE-DEV] [PATCH v2] base-files: ensure reset only works if an overlay exists

2016-10-20 Thread Chris Blake
Hey Rafal, I agree that would work in terms of functionality, but the issue with that logic is if you hold the button over 5 seconds, the system LED will start flashing (as expected) but then no action is taken on the board. The reason for my logic change was just to ensure the board would reboot

Re: [LEDE-DEV] [PATCH v2] base-files: ensure reset only works if an overlay exists

2016-10-20 Thread Rafał Miłecki
On 20 October 2016 at 07:37, Chris Blake wrote: > On Thu, Oct 20, 2016 at 12:29 AM, Rafał Miłecki wrote: >> On 20 October 2016 at 05:23, Chris Blake wrote: >>> diff --git a/package/base-files/files/etc/rc.button/reset >>>

Re: [LEDE-DEV] [PATCH v2] base-files: ensure reset only works if an overlay exists

2016-10-19 Thread Chris Blake
On Thu, Oct 20, 2016 at 12:29 AM, Rafał Miłecki wrote: > On 20 October 2016 at 05:23, Chris Blake wrote: >> diff --git a/package/base-files/files/etc/rc.button/reset >> b/package/base-files/files/etc/rc.button/reset >> index c6dc7cf..fab9a6c 100755 >>

Re: [LEDE-DEV] [PATCH v2] base-files: ensure reset only works if an overlay exists

2016-10-19 Thread Rafał Miłecki
On 20 October 2016 at 05:23, Chris Blake wrote: > diff --git a/package/base-files/files/etc/rc.button/reset > b/package/base-files/files/etc/rc.button/reset > index c6dc7cf..fab9a6c 100755 > --- a/package/base-files/files/etc/rc.button/reset > +++

[LEDE-DEV] [PATCH v2] base-files: ensure reset only works if an overlay exists

2016-10-19 Thread Chris Blake
Currently the reset script will try to run jffs2reset on boards that are running a rw ext4 or other rootfs, which will then cause jffs2reset to fail and the board to never reboot. This change ensures that jffs2reset is only ran if an overlay is mounted, and disables the "reset" feature if no