Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[Mauro Mozzarelli]

Wrong thread.

My apologies


On 23/08/17 09:29, Mauro Mozzarelli wrote:

It fails also with fresh git pull:


Checking 'grep'... ok.
Checking 'getopt'... ok.
Checking 'stat'... ok.
Checking 'unzip'... ok.
Checking 'bzip2'... ok.
Checking 'wget'... ok.
Checking 'perl'... ok.
Checking 'python'... ok.
Checking 'git'... ok.
Checking 'file'... ok.
Checking 'ldconfig-stub'... ok.

Build dependency: Please install ncurses. (Missing libncurses.so or 
ncurses.h)


/spi/router/lede/trunk/include/prereq.mk:12: recipe for target 
'prereq' failed

Prerequisite check failed. Use FORCE=1 to override.
/spi/router/lede/trunk/include/toplevel.mk:158: recipe for target 
'staging_dir/host/.prereq-build' failed

make[1]: *** [staging_dir/host/.prereq-build] Error 1
/spi/router/lede/trunk/include/toplevel.mk:83: recipe for target 
'prepare-tmpinfo' failed

make: *** [prepare-tmpinfo] Error 2


On 23/08/17 05:44, John Crispin wrote:



On 23/08/17 05:34, Philip Prindeville wrote:
On Aug 22, 2017, at 1:56 PM, Arjen de Korte 
 wrote:


Citeren Philip Prindeville :


Found the issue, and posted PR #1308 to fix it.  One-line fix.


On Aug 19, 2017, at 3:06 PM, Philip Prindeville 
 wrote:


And it looks like Hannu is way ahead of me:

https://bugs.lede-project.org/index.php?do=details_id=969


On Aug 19, 2017, at 2:59 PM, Philip Prindeville 
 wrote:


I rebased about an hour ago and then tried to rebuild 
everything.  Now I’m seeing what’s below.


I looked at the commit logs, though, and nothing stands out as a 
likely culprit… except maybe the bump from 4.9.40 to 4.9.44.


If I rebase back to

d9564d7 bcm53xx: backport DTS commits that setup USB LEDs

then things build again.


. /home/philipp/bertram/lede/include/shell.sh; export modules=; 
probe_module() { local mods="$1"; local boot="$2"; local 
params="$3"; local mod; shift 3; for mod in $mods; do mkdir -p 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; 
local mod_params=""; for param in $params; do case $param in 
$mod.*) mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; 
*) mod_params="$mod_params \"$param\""; ;; esac; done; echo 
"$mod$mod_params" >> 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp; 
done; if [ -e 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp 
]; then if [ "$boot" = "1" -a ! -e 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/ipt-nathelper-rtsp 
]; then mkdir -p 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; 
ln -s ../modules.d/ipt-nathelper-rtsp 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; 
fi; modules="${modules:+$modules }$mods"; fi; }; add_module() { 
local priority="$1"; local mods="$2"; local boot="$3"; local 
params="$4"; local mod; shift 4; for mod in $mods; do mkdir -p 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; 
local mod_params=""; for param in $params; do case $param in 
$mod.*) mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; 
*) mod_params="$mod_params \"$param\""; ;; esac; done; echo 
"$mod$mod_params" >> 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp; 
done; if [ -e 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp 
]; then if [ "$boot" = "1" -a ! -e 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/$priority-ipt-nathelper-rtsp 
]; then mkdir -p 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; 
ln -s ../modules.d/$priority-ipt-nathelper-rtsp 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; 
fi; modules="${modules:+$modules }$priority-ipt-nathelper-rtsp"; 
fi; }; probe_module "nf_conntrack_rtsp nf_nat_rtsp" "" ""; 

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[Mauro Mozzarelli]

It fails also with fresh git pull:


Checking 'grep'... ok.
Checking 'getopt'... ok.
Checking 'stat'... ok.
Checking 'unzip'... ok.
Checking 'bzip2'... ok.
Checking 'wget'... ok.
Checking 'perl'... ok.
Checking 'python'... ok.
Checking 'git'... ok.
Checking 'file'... ok.
Checking 'ldconfig-stub'... ok.

Build dependency: Please install ncurses. (Missing libncurses.so or 
ncurses.h)


/spi/router/lede/trunk/include/prereq.mk:12: recipe for target 'prereq' 
failed

Prerequisite check failed. Use FORCE=1 to override.
/spi/router/lede/trunk/include/toplevel.mk:158: recipe for target 
'staging_dir/host/.prereq-build' failed

make[1]: *** [staging_dir/host/.prereq-build] Error 1
/spi/router/lede/trunk/include/toplevel.mk:83: recipe for target 
'prepare-tmpinfo' failed

make: *** [prepare-tmpinfo] Error 2


On 23/08/17 05:44, John Crispin wrote:



On 23/08/17 05:34, Philip Prindeville wrote:
On Aug 22, 2017, at 1:56 PM, Arjen de Korte 
 wrote:


Citeren Philip Prindeville :


Found the issue, and posted PR #1308 to fix it.  One-line fix.


On Aug 19, 2017, at 3:06 PM, Philip Prindeville 
 wrote:


And it looks like Hannu is way ahead of me:

https://bugs.lede-project.org/index.php?do=details_id=969


On Aug 19, 2017, at 2:59 PM, Philip Prindeville 
 wrote:


I rebased about an hour ago and then tried to rebuild 
everything.  Now I’m seeing what’s below.


I looked at the commit logs, though, and nothing stands out as a 
likely culprit… except maybe the bump from 4.9.40 to 4.9.44.


If I rebase back to

d9564d7 bcm53xx: backport DTS commits that setup USB LEDs

then things build again.


. /home/philipp/bertram/lede/include/shell.sh; export modules=; 
probe_module() { local mods="$1"; local boot="$2"; local 
params="$3"; local mod; shift 3; for mod in $mods; do mkdir -p 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; 
local mod_params=""; for param in $params; do case $param in 
$mod.*) mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; 
*) mod_params="$mod_params \"$param\""; ;; esac; done; echo 
"$mod$mod_params" >> 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp; 
done; if [ -e 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp 
]; then if [ "$boot" = "1" -a ! -e 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/ipt-nathelper-rtsp 
]; then mkdir -p 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; 
ln -s ../modules.d/ipt-nathelper-rtsp 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; 
fi; modules="${modules:+$modules }$mods"; fi; }; add_module() { 
local priority="$1"; local mods="$2"; local boot="$3"; local 
params="$4"; local mod; shift 4; for mod in $mods; do mkdir -p 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; 
local mod_params=""; for param in $params; do case $param in 
$mod.*) mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; 
*) mod_params="$mod_params \"$param\""; ;; esac; done; echo 
"$mod$mod_params" >> 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp; 
done; if [ -e 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp 
]; then if [ "$boot" = "1" -a ! -e 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/$priority-ipt-nathelper-rtsp 
]; then mkdir -p 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; 
ln -s ../modules.d/$priority-ipt-nathelper-rtsp 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; 
fi; modules="${modules:+$modules }$priority-ipt-nathelper-rtsp"; 
fi; }; probe_module "nf_conntrack_rtsp nf_nat_rtsp" "" ""; if [ 
-n "$modules" ]; then modules="$(echo "$modules" | tr ' ' '\n' | 

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[Koen Vandeputte]

On 2017-08-23 09:55, John Crispin wrote:

pushed a fix, please retest
John

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev


Hi John,

Just done a full rebuild.
It doesn't whine anymore about the xtables-addons, which is good.

Now this one pops up again (reported by Mauro Mozzarelli yesterday):


find 
/mnt/ramdisk/test/firmware/builds/generic_imx6/build_dir/target-arm_cortex-a9+neon_musl_eabi/util-linux-2.30.1/ipkg-arm_cortex-a9_neon/dmesg 
-name 'CVS' -o -name '.svn' -o -name '.#*' -o -name '*~'| xargs -r rm -rf

Package dmesg is missing dependencies for the following libraries:
libncursesw.so.6
Makefile:673: recipe for target 
'/mnt/ramdisk/test/firmware/builds/generic_imx6/bin/packages/arm_cortex-a9_neon/base/dmesg_2.30.1-1_arm_cortex-a9_neon.ipk' 
failed
make[3]: *** 
[/mnt/ramdisk/test/firmware/builds/generic_imx6/bin/packages/arm_cortex-a9_neon/base/dmesg_2.30.1-1_arm_cortex-a9_neon.ipk] 
Error 1
make[3]: Leaving directory 
'/mnt/ramdisk/test/firmware/builds/generic_imx6/package/utils/util-linux'
package/Makefile:109: recipe for target 
'package/utils/util-linux/compile' failed

make[2]: *** [package/utils/util-linux/compile] Error 2
make[2]: Leaving directory '/mnt/ramdisk/test/firmware/builds/generic_imx6'
package/Makefile:105: recipe for target 
'/mnt/ramdisk/test/firmware/builds/generic_imx6/staging_dir/target-arm_cortex-a9+neon_musl_eabi/stamp/.package_compile' 
failed
make[1]: *** 
[/mnt/ramdisk/test/firmware/builds/generic_imx6/staging_dir/target-arm_cortex-a9+neon_musl_eabi/stamp/.package_compile] 
Error 2

make[1]: Leaving directory '/mnt/ramdisk/test/firmware/builds/generic_imx6'
/mnt/ramdisk/test/firmware/builds/generic_imx6/include/toplevel.mk:207: 
recipe for target 'world' failed

make: *** [world] Error 2



Remark: I'm using the full dmesg package, not the one provided in busybox

I'll leave the build in it's current state here.
If you want details from a certain file, please let me know.


Koen

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[John Crispin]

pushed a fix, please retest
John

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[Arjen de Korte]

Citeren John Crispin :


On 23/08/17 05:34, Philip Prindeville wrote:
On Aug 22, 2017, at 1:56 PM, Arjen de Korte  
 wrote:


Citeren Philip Prindeville :


Found the issue, and posted PR #1308 to fix it.  One-line fix.


On Aug 19, 2017, at 3:06 PM, Philip Prindeville  
 wrote:


And it looks like Hannu is way ahead of me:

https://bugs.lede-project.org/index.php?do=details_id=969


On Aug 19, 2017, at 2:59 PM, Philip Prindeville  
 wrote:


I rebased about an hour ago and then tried to rebuild  
everything.  Now I’m seeing what’s below.


I looked at the commit logs, though, and nothing stands out as  
a likely culprit… except maybe the bump from 4.9.40 to 4.9.44.


If I rebase back to

d9564d7 bcm53xx: backport DTS commits that setup USB LEDs

then things build again.


. /home/philipp/bertram/lede/include/shell.sh; export modules=;  
probe_module() { local mods="$1"; local boot="$2"; local  
params="$3"; local mod; shift 3; for mod in $mods; do mkdir -p  
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; local mod_params=""; for param in $params; do case $param in $mod.*) mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) mod_params="$mod_params \"$param\""; ;; esac; done; echo "$mod$mod_params" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp; done; if [ -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp ]; then if [ "$boot" = "1" -a ! -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/ipt-nathelper-rtsp ]; then mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; ln -s ../modules.d/ipt-nathelper-rtsp /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; fi; modules="${modules:+$modules }$mods"; fi; }; add_module() { local priority="$1"; local mods="$2"; local boot="$3"; local params="$4"; local mod; shift 4; for mod in $mods; do mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; local mod_params=""; for param in $params; do case $param in $mod.*) mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) mod_params="$mod_params \"$param\""; ;; esac; done; echo "$mod$mod_params" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp; done; if [ -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp ]; then if [ "$boot" = "1" -a ! -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/$priority-ipt-nathelper-rtsp ]; then mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; ln -s ../modules.d/$priority-ipt-nathelper-rtsp /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; fi; modules="${modules:+$modules }$priority-ipt-nathelper-rtsp"; fi; }; probe_module "nf_conntrack_rtsp nf_nat_rtsp" "" ""; if [ -n "$modules" ]; then modules="$(echo "$modules" | tr ' ' '\n' | sort | uniq | paste -s -d' ' -)"; mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL; echo "#!/bin/sh" > /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg; echo "[ -z \"\$IPKG_INSTROOT\" ] || exit 0" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg; echo ". /lib/functions.sh" >> 

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[John Crispin]

On 23/08/17 08:32, Arjen de Korte wrote:

Citeren John Crispin :


On 23/08/17 07:32, Koen Vandeputte wrote:

Hi John,

This the the hafd part.

I've spend a full day on it and found this:


Full clone + Check out:  "364befe kernel: update 4.4 to 4.4.83"
--> Build OK

Full clone + Check out:  "1f06858 mediatek: update to latest kernel 
patchset from v4.13-rc"

--> Build FAIL

Full clone + revert:  "1f06858 mediatek: update to latest kernel 
patchset from v4.13-rc"

--> Build FAIL


Koen



Hi Koen,

must be related to target/linux/mediatek/modules.mk in that case. let 
me have a dig just now


I don't think so. It also fails here if I rebuild after checking out 
"364befe kernel: update 4.4 to 4.4.83". The first time it builds OK, 
any subsequent builds of the same sources fail.


tmp/.packagedeps somehow adds this causing the error, now to fins out why

-$(curdir)/kernel/linux/compile += 
$(curdir)/firmware/linux-firmware/compile 
$(curdir)/firmware/prism54-firmware/compile
+$(curdir)/kernel/linux/compile += 
$(curdir)/firmware/linux-firmware/compile 
$(curdir)/firmware/prism54-firmware/compile 
$(curdir)/network/utils/xtables-addons/compile







Op 23-aug.-2017 06:44 schreef "John Crispin" >:




   On 23/08/17 05:34, Philip Prindeville wrote:

   On Aug 22, 2017, at 1:56 PM, Arjen de Korte
   > wrote:

   Citeren Philip Prindeville
   >:

   Found the issue, and posted PR #1308 to fix it.
   One-line fix.


   On Aug 19, 2017, at 3:06 PM, Philip Prindeville
   > wrote:

   And it looks like Hannu is way ahead of me:

https://bugs.lede-project.org/index.php?do=details_id=969



   On Aug 19, 2017, at 2:59 PM, Philip
   Prindeville
   >
   wrote:

   I rebased about an hour ago and then tried to
   rebuild everything.  Now I’m seeing what’s 
below.


   I looked at the commit logs, though, and
   nothing stands out as a likely culprit… except
   maybe the bump from 4.9.40 to 4.9.44.

   If I rebase back to

   d9564d7 bcm53xx: backport DTS commits that
   setup USB LEDs

   then things build again.


   . /home/philipp/bertram/lede/include/shell.sh;
   export modules=; probe_module() { local
   mods="$1"; local boot="$2"; local params="$3";
   local mod; shift 3; for mod in $mods; do mkdir
   -p
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d;
   local mod_params=""; for param in $params; do
   case $param in $mod.*) mod_params="$mod_params
   \"${param#$mod.}\""; ;; *.*) ;; *)
   mod_params="$mod_params \"$param\""; ;; esac;
   done; echo "$mod$mod_params" >>
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp;
   done; if [ -e
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp
   ]; then if [ "$boot" = "1" -a ! -e
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/ipt-nathelper-rtsp
   ]; then mkdir -p
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d;
   ln -s ../modules.d/ipt-nathelper-rtsp
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/;
   fi; modules="${modules:+$modules }$mods"; fi;
   }; add_module() { local priority="$1"; local
   mods="$2"; local boot="$3"; local params="$4";
   local mod; shift 4; for mod in $mods; do mkdir
   -p

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[Arjen de Korte]

Citeren John Crispin :


On 23/08/17 07:32, Koen Vandeputte wrote:

Hi John,

This the the hafd part.

I've spend a full day on it and found this:


Full clone + Check out:  "364befe kernel: update 4.4 to 4.4.83"
--> Build OK

Full clone + Check out:  "1f06858 mediatek: update to latest kernel  
patchset from v4.13-rc"

--> Build FAIL

Full clone + revert:  "1f06858 mediatek: update to latest kernel  
patchset from v4.13-rc"

--> Build FAIL


Koen



Hi Koen,

must be related to target/linux/mediatek/modules.mk in that case.  
let me have a dig just now


I don't think so. It also fails here if I rebuild after checking out  
"364befe kernel: update 4.4 to 4.4.83". The first time it builds OK,  
any subsequent builds of the same sources fail.


Op 23-aug.-2017 06:44 schreef "John Crispin" >:




   On 23/08/17 05:34, Philip Prindeville wrote:

   On Aug 22, 2017, at 1:56 PM, Arjen de Korte
   > wrote:

   Citeren Philip Prindeville
   >:

   Found the issue, and posted PR #1308 to fix it.
   One-line fix.


   On Aug 19, 2017, at 3:06 PM, Philip Prindeville
   > wrote:

   And it looks like Hannu is way ahead of me:


https://bugs.lede-project.org/index.php?do=details_id=969





   On Aug 19, 2017, at 2:59 PM, Philip
   Prindeville
   >
   wrote:

   I rebased about an hour ago and then tried to
   rebuild everything.  Now I’m seeing what’s below.

   I looked at the commit logs, though, and
   nothing stands out as a likely culprit… except
   maybe the bump from 4.9.40 to 4.9.44.

   If I rebase back to

   d9564d7 bcm53xx: backport DTS commits that
   setup USB LEDs

   then things build again.


   . /home/philipp/bertram/lede/include/shell.sh;
   export modules=; probe_module() { local
   mods="$1"; local boot="$2"; local params="$3";
   local mod; shift 3; for mod in $mods; do mkdir
   -p

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d;

   local mod_params=""; for param in $params; do
   case $param in $mod.*) mod_params="$mod_params
   \"${param#$mod.}\""; ;; *.*) ;; *)
   mod_params="$mod_params \"$param\""; ;; esac;
   done; echo "$mod$mod_params" >>

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp;

   done; if [ -e

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp

   ]; then if [ "$boot" = "1" -a ! -e

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/ipt-nathelper-rtsp

   ]; then mkdir -p

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d;

   ln -s ../modules.d/ipt-nathelper-rtsp

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/;

   fi; modules="${modules:+$modules }$mods"; fi;
   }; add_module() { local priority="$1"; local
   mods="$2"; local boot="$3"; local params="$4";
   local mod; shift 4; for mod in $mods; do mkdir
   -p

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d;

   local 

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[John Crispin]

On 23/08/17 07:32, Koen Vandeputte wrote:

Hi John,

This the the hafd part.

I've spend a full day on it and found this:


Full clone + Check out:  "364befe kernel: update 4.4 to 4.4.83"
--> Build OK

Full clone + Check out:  "1f06858 mediatek: update to latest kernel 
patchset from v4.13-rc"

--> Build FAIL

Full clone + revert:  "1f06858 mediatek: update to latest kernel 
patchset from v4.13-rc"

--> Build FAIL


Koen



Hi Koen,

must be related to target/linux/mediatek/modules.mk in that case. let me 
have a dig just now


John


Op 23-aug.-2017 06:44 schreef "John Crispin" >:




On 23/08/17 05:34, Philip Prindeville wrote:

On Aug 22, 2017, at 1:56 PM, Arjen de Korte
> wrote:

Citeren Philip Prindeville
>:

Found the issue, and posted PR #1308 to fix it.
One-line fix.


On Aug 19, 2017, at 3:06 PM, Philip Prindeville
> wrote:

And it looks like Hannu is way ahead of me:


https://bugs.lede-project.org/index.php?do=details_id=969




On Aug 19, 2017, at 2:59 PM, Philip
Prindeville
>
wrote:

I rebased about an hour ago and then tried to
rebuild everything.  Now I’m seeing what’s below.

I looked at the commit logs, though, and
nothing stands out as a likely culprit… except
maybe the bump from 4.9.40 to 4.9.44.

If I rebase back to

d9564d7 bcm53xx: backport DTS commits that
setup USB LEDs

then things build again.


. /home/philipp/bertram/lede/include/shell.sh;
export modules=; probe_module() { local
mods="$1"; local boot="$2"; local params="$3";
local mod; shift 3; for mod in $mods; do mkdir
-p

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d;
local mod_params=""; for param in $params; do
case $param in $mod.*) mod_params="$mod_params
\"${param#$mod.}\""; ;; *.*) ;; *)
mod_params="$mod_params \"$param\""; ;; esac;
done; echo "$mod$mod_params" >>

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp;
done; if [ -e

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp
]; then if [ "$boot" = "1" -a ! -e

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/ipt-nathelper-rtsp
]; then mkdir -p

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d;
ln -s ../modules.d/ipt-nathelper-rtsp

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/;
fi; modules="${modules:+$modules }$mods"; fi;
}; add_module() { local priority="$1"; local
mods="$2"; local boot="$3"; local params="$4";
local mod; shift 4; for mod in $mods; do mkdir
-p

/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d;
local mod_params=""; for param in $params; do
case $param in $mod.*) mod_params="$mod_params
\"${param#$mod.}\""; ;; *.*) ;; *)

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[John Crispin]

On 23/08/17 05:34, Philip Prindeville wrote:

On Aug 22, 2017, at 1:56 PM, Arjen de Korte  wrote:

Citeren Philip Prindeville :


Found the issue, and posted PR #1308 to fix it.  One-line fix.



On Aug 19, 2017, at 3:06 PM, Philip Prindeville 
 wrote:

And it looks like Hannu is way ahead of me:

https://bugs.lede-project.org/index.php?do=details_id=969



On Aug 19, 2017, at 2:59 PM, Philip Prindeville 
 wrote:

I rebased about an hour ago and then tried to rebuild everything.  Now I’m 
seeing what’s below.

I looked at the commit logs, though, and nothing stands out as a likely 
culprit… except maybe the bump from 4.9.40 to 4.9.44.

If I rebase back to

d9564d7 bcm53xx: backport DTS commits that setup USB LEDs

then things build again.


. /home/philipp/bertram/lede/include/shell.sh; export modules=; probe_module() { local mods="$1"; local boot="$2"; local params="$3"; local mod; shift 3; for mod in $mods; do mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; local mod_params=""; for param in $params; do case $param in $mod.*) 
mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) mod_params="$mod_params \"$param\""; ;; esac; done; echo "$mod$mod_params" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp; done; if [ -e 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp ]; then if [ "$boot" = "1" -a ! -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/ipt-nathelper-rtsp ]; then mkdir -p 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; ln -s ../modules.d/ipt-nathelper-rtsp /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; fi; modules="${modules:+$modules }$mods"; fi; }; add_module() { local priority="$1"; local 
mods="$2"; local boot="$3"; local params="$4"; local mod; shift 4; for mod in $mods; do mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; local mod_params=""; for param in $params; do case $param in $mod.*) mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) mod_params="$mod_params 
\"$param\""; ;; esac; done; echo "$mod$mod_params" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp; done; if [ -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp ]; then 
if [ "$boot" = "1" -a ! -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/$priority-ipt-nathelper-rtsp ]; then mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; ln -s ../modules.d/$priority-ipt-nathelper-rtsp 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; fi; modules="${modules:+$modules }$priority-ipt-nathelper-rtsp"; fi; }; probe_module "nf_conntrack_rtsp nf_nat_rtsp" "" ""; if [ -n "$modules" ]; then modules="$(echo "$modules" | tr ' ' '\n' | sort | uniq | paste -s -d' ' -)"; mkdir -p 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL; echo "#!/bin/sh" > 
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg; echo "[ -z \"\$IPKG_INSTROOT\" ] || exit 0" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg; echo ". /lib/functions.sh" >> 

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[Philip Prindeville]

> On Aug 22, 2017, at 1:56 PM, Arjen de Korte  wrote:
> 
> Citeren Philip Prindeville :
> 
>> Found the issue, and posted PR #1308 to fix it.  One-line fix.
>> 
>> 
>>> On Aug 19, 2017, at 3:06 PM, Philip Prindeville 
>>>  wrote:
>>> 
>>> And it looks like Hannu is way ahead of me:
>>> 
>>> https://bugs.lede-project.org/index.php?do=details_id=969
>>> 
>>> 
 On Aug 19, 2017, at 2:59 PM, Philip Prindeville 
  wrote:
 
 I rebased about an hour ago and then tried to rebuild everything.  Now I’m 
 seeing what’s below.
 
 I looked at the commit logs, though, and nothing stands out as a likely 
 culprit… except maybe the bump from 4.9.40 to 4.9.44.
 
 If I rebase back to
 
 d9564d7 bcm53xx: backport DTS commits that setup USB LEDs
 
 then things build again.
 
 
 . /home/philipp/bertram/lede/include/shell.sh; export modules=; 
 probe_module() { local mods="$1"; local boot="$2"; local params="$3"; 
 local mod; shift 3; for mod in $mods; do mkdir -p 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d;
  local mod_params=""; for param in $params; do case $param in $mod.*) 
 mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) 
 mod_params="$mod_params \"$param\""; ;; esac; done; echo "$mod$mod_params" 
 >> 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp;
  done; if [ -e 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp
  ]; then if [ "$boot" = "1" -a ! -e 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/ipt-nathelper-rtsp
  ]; then mkdir -p 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d;
  ln -s ../modules.d/ipt-nathelper-rtsp 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/;
  fi; modules="${modules:+$modules }$mods"; fi; }; add_module() { local 
 priority="$1"; local mods="$2"; local boot="$3"; local params="$4"; local 
 mod; shift 4; for mod in $mods; do mkdir -p 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d;
  local mod_params=""; for param in $params; do case $param in $mod.*) 
 mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) 
 mod_params="$mod_params \"$param\""; ;; esac; done; echo "$mod$mod_params" 
 >> 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp;
  done; if [ -e 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp
  ]; then if [ "$boot" = "1" -a ! -e 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/$priority-ipt-nathelper-rtsp
  ]; then mkdir -p 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d;
  ln -s ../modules.d/$priority-ipt-nathelper-rtsp 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/;
  fi; modules="${modules:+$modules }$priority-ipt-nathelper-rtsp"; fi; }; 
 probe_module "nf_conntrack_rtsp nf_nat_rtsp" "" ""; if [ -n "$modules" ]; 
 then modules="$(echo "$modules" | tr ' ' '\n' | sort | uniq | paste -s -d' 
 ' -)"; mkdir -p 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d;
  mkdir -p 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL;
  echo "#!/bin/sh" > 
 /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg;
  echo "[ -z 

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[Arjen de Korte]

Citeren Philip Prindeville :


Found the issue, and posted PR #1308 to fix it.  One-line fix.


On Aug 19, 2017, at 3:06 PM, Philip Prindeville  
 wrote:


And it looks like Hannu is way ahead of me:

https://bugs.lede-project.org/index.php?do=details_id=969


On Aug 19, 2017, at 2:59 PM, Philip Prindeville  
 wrote:


I rebased about an hour ago and then tried to rebuild everything.   
Now I’m seeing what’s below.


I looked at the commit logs, though, and nothing stands out as a  
likely culprit… except maybe the bump from 4.9.40 to 4.9.44.


If I rebase back to

d9564d7 bcm53xx: backport DTS commits that setup USB LEDs

then things build again.


. /home/philipp/bertram/lede/include/shell.sh; export modules=;  
probe_module() { local mods="$1"; local boot="$2"; local  
params="$3"; local mod; shift 3; for mod in $mods; do mkdir -p  
/home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; local mod_params=""; for param in $params; do case $param in $mod.*) mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) mod_params="$mod_params \"$param\""; ;; esac; done; echo "$mod$mod_params" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp; done; if [ -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp ]; then if [ "$boot" = "1" -a ! -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/ipt-nathelper-rtsp ]; then mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; ln -s ../modules.d/ipt-nathelper-rtsp /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; fi; modules="${modules:+$modules }$mods"; fi; }; add_module() { local priority="$1"; local mods="$2"; local boot="$3"; local params="$4"; local mod; shift 4; for mod in $mods; do mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; local mod_params=""; for param in $params; do case $param in $mod.*) mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) mod_params="$mod_params \"$param\""; ;; esac; done; echo "$mod$mod_params" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp; done; if [ -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp ]; then if [ "$boot" = "1" -a ! -e /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/$priority-ipt-nathelper-rtsp ]; then mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d; ln -s ../modules.d/$priority-ipt-nathelper-rtsp /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/; fi; modules="${modules:+$modules }$priority-ipt-nathelper-rtsp"; fi; }; probe_module "nf_conntrack_rtsp nf_nat_rtsp" "" ""; if [ -n "$modules" ]; then modules="$(echo "$modules" | tr ' ' '\n' | sort | uniq | paste -s -d' ' -)"; mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d; mkdir -p /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL; echo "#!/bin/sh" > /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg; echo "[ -z \"\$IPKG_INSTROOT\" ] || exit 0" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg; echo ". /lib/functions.sh" >> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg; echo "insert_modules $modules" >> 

Re: [LEDE-DEV] Issues with xtables-addons after rebasing today

[Philip Prindeville]

Found the issue, and posted PR #1308 to fix it.  One-line fix.


> On Aug 19, 2017, at 3:06 PM, Philip Prindeville 
>  wrote:
> 
> And it looks like Hannu is way ahead of me:
> 
> https://bugs.lede-project.org/index.php?do=details_id=969
> 
> 
>> On Aug 19, 2017, at 2:59 PM, Philip Prindeville 
>>  wrote:
>> 
>> I rebased about an hour ago and then tried to rebuild everything.  Now I’m 
>> seeing what’s below.
>> 
>> I looked at the commit logs, though, and nothing stands out as a likely 
>> culprit… except maybe the bump from 4.9.40 to 4.9.44.
>> 
>> If I rebase back to
>> 
>> d9564d7 bcm53xx: backport DTS commits that setup USB LEDs
>> 
>> then things build again.
>> 
>> 
>> . /home/philipp/bertram/lede/include/shell.sh; export modules=; 
>> probe_module() { local mods="$1"; local boot="$2"; local params="$3"; local 
>> mod; shift 3; for mod in $mods; do mkdir -p 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d;
>>  local mod_params=""; for param in $params; do case $param in $mod.*) 
>> mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) 
>> mod_params="$mod_params \"$param\""; ;; esac; done; echo "$mod$mod_params" 
>> >> 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp;
>>  done; if [ -e 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/ipt-nathelper-rtsp
>>  ]; then if [ "$boot" = "1" -a ! -e 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/ipt-nathelper-rtsp
>>  ]; then mkdir -p 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d;
>>  ln -s ../modules.d/ipt-nathelper-rtsp 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/;
>>  fi; modules="${modules:+$modules }$mods"; fi; }; add_module() { local 
>> priority="$1"; local mods="$2"; local boot="$3"; local params="$4"; local 
>> mod; shift 4; for mod in $mods; do mkdir -p 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d;
>>  local mod_params=""; for param in $params; do case $param in $mod.*) 
>> mod_params="$mod_params \"${param#$mod.}\""; ;; *.*) ;; *) 
>> mod_params="$mod_params \"$param\""; ;; esac; done; echo "$mod$mod_params" 
>> >> 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp;
>>  done; if [ -e 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d/$priority-ipt-nathelper-rtsp
>>  ]; then if [ "$boot" = "1" -a ! -e 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/$priority-ipt-nathelper-rtsp
>>  ]; then mkdir -p 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d;
>>  ln -s ../modules.d/$priority-ipt-nathelper-rtsp 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules-boot.d/;
>>  fi; modules="${modules:+$modules }$priority-ipt-nathelper-rtsp"; fi; }; 
>> probe_module "nf_conntrack_rtsp nf_nat_rtsp" "" ""; if [ -n "$modules" ]; 
>> then modules="$(echo "$modules" | tr ' ' '\n' | sort | uniq | paste -s -d' ' 
>> -)"; mkdir -p 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/etc/modules.d;
>>  mkdir -p 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL;
>>  echo "#!/bin/sh" > 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg;
>>  echo "[ -z \"\$IPKG_INSTROOT\" ] || exit 0" >> 
>> /home/philipp/bertram/lede/build_dir/target-x86_64_musl_powercode-bmu/linux-x86_64/xtables-addons-2.12/ipkg-x86_64/kmod-ipt-nathelper-rtsp/CONTROL/postinst-pkg;
>>  echo ". /lib/functions.sh" >> 
>>