Re: [LEDE-DEV] [PATCH] ubus cli: wait_for: fix race causing false timeouts

2016-10-07 Thread Zefir Kurtisi
On 10/07/2016 02:15 PM, Alexandru Ardelean wrote: > On Fri, Oct 7, 2016 at 3:09 PM, Felix Fietkau wrote: >> Instead of introducing yet another timer, wouldn't it also be possible >> to close this race window by registering the event handler before >> attempting the lookup? >> >> -

[LEDE-DEV] [PATCH v1 1/2] base-files, mac80211, broadcom-wl: plug-and-play wifi detection

2016-10-07 Thread Christian Lamparter
Currently, the wifi detection script is executed as part of the (early) boot process. Pluggable wifi USB devices, which are inserted at a later time are not automatically detected and therefore they don't show up in LuCI. A user has to deal with wifi detection manually, or restart the router.

[LEDE-DEV] [PATCH] ltq-ptm: Support 1508-byte MTU for RFC4638

2016-10-07 Thread David Woodhouse
Tested with VDSL on TP-Link WD8970, I see full 1500-byte PPP data frames, which end up being 1526 byte Ethernet frames (including Ethernet+VLAN headers) on the wire. Fixes: FS#210 Signed-off-by: David Woodhouse diff --git

Re: [LEDE-DEV] [PATCH v1 1/2] base-files, mac80211, broadcom-wl: plug-and-play wifi detection

2016-10-07 Thread Matthias Schiffer
On 10/07/2016 08:10 PM, Christian Lamparter wrote: > Currently, the wifi detection script is executed as part of > the (early) boot process. Pluggable wifi USB devices, which > are inserted at a later time are not automatically > detected and therefore they don't show up in LuCI. > > A user has

[LEDE-DEV] [PATCH] apm821xx: replace recovery image for the MBL with initramfs

2016-10-07 Thread Christian Lamparter
The patch "images: bump default rootfs size to 256 MB" a1f83bad606411a561e8e60110c71232b1a28aa2 caused a crash during boot for the recovery images. This is because both variants of the MyBook Live only have 256MB of RAM and for the recovery option, the ext4 rootfs was simply stored in the RAMDISK.

Re: [LEDE-DEV] [PATCH v1 1/2] base-files, mac80211, broadcom-wl: plug-and-play wifi detection

2016-10-07 Thread Jo-Philipp Wich
Hi, > - The broadcom-wl hotplug script is suboptimal. > As it will run for any net devices (ethernet). I think you can restrict the hotplugging for broadcom-wl to "wl[0-9]" net devices, this should avoid some extraneous invocations. Otherwise, Acked-by: Jo-Philipp Wich ~ Jo

Re: [LEDE-DEV] [PATCH] ubus cli: wait_for: fix race causing false timeouts

2016-10-07 Thread Felix Fietkau
On 2016-10-07 13:57, Zefir Kurtisi wrote: > In ubus_cli_wait_for() there is a critical section between > initially checking for the requested services and the > following handling of 'ubus.object.add' events. > > In our system we let procd (re)start services and synchronize > inter-service

Re: [LEDE-DEV] [PATCH] ubus cli: wait_for: fix race causing false timeouts

2016-10-07 Thread Alexandru Ardelean
On Fri, Oct 7, 2016 at 3:09 PM, Felix Fietkau wrote: > On 2016-10-07 13:57, Zefir Kurtisi wrote: >> In ubus_cli_wait_for() there is a critical section between >> initially checking for the requested services and the >> following handling of 'ubus.object.add' events. >> >> In our