Re: [LEDE-DEV] [PATCH 1/3] UBIFS, UBI: move volume string parser from UBIFS to UBI

2016-08-28 Thread Boris Brezillon
On Sat, 27 Aug 2016 21:43:53 +0200 Daniel Golle wrote: No explanation on why you do that. Please make reviewers life easier and explain what you're trying to achieve. This patch on its own is not a problem, as long as you have another FS base on UBI (I'm not talking about ubiblock) that is makin

Re: [LEDE-DEV] [PATCH 2/3] mtd: ubiblock: introduce ubiblock_create_dev

2016-08-28 Thread Boris Brezillon
On Sat, 27 Aug 2016 21:44:16 +0200 Daniel Golle wrote: > Define function ubiblock_create_dev(char *name, dev_t *bdev) > which returns the created device by setting the point bdev. > This is useful for in-kernel users creating a ubiblock device > in order to mount the root filesystem. No specific

Re: [LEDE-DEV] [PATCH 3/3] init: auto-create ubiblock device for non-UBIFS rootfs on UBI

2016-08-28 Thread Boris Brezillon
On Sat, 27 Aug 2016 21:44:46 +0200 Daniel Golle wrote: > Signed-off-by: Daniel Golle > --- > init/do_mounts.c | 62 > +--- > 1 file changed, 55 insertions(+), 7 deletions(-) > > diff --git a/init/do_mounts.c b/init/do_mounts.c > index dea5de