Re: [LEDE-DEV] [PATCH] mac80211: Fix race condition leading to wifi interfaces not coming up at boot sometimes.

2017-03-14 Thread Bastian Bittorf
* Vittorio Gambaletta (VittGam) [14.03.2017 07:55]: > +mac80211_iw_interface_add() { > + local phy="$1" > + local ifname="$2" > + local type="$3" > + local wdsflag="$4" please add a 'local ret' here, or better use the common 'local rc=0' and later always

Re: [LEDE-DEV] [PATCH] mac80211: Fix race condition leading to wifi interfaces not coming up at boot sometimes.

2017-03-14 Thread Vittorio G (VittGam)
If you're wondering where the -ENFILE error comes from... At first I thought it was obviously related to fs.file-max that defaults to "just" 8192. But it was not. It took me a while to figure out that the error came from here instead...

[LEDE-DEV] [PATCH] mac80211: Fix race condition leading to wifi interfaces not coming up at boot sometimes.

2017-03-13 Thread Vittorio Gambaletta (VittGam)
In the drv_mac80211_setup function, mac80211_interface_cleanup is called to ask the kernel to delete all existing interfaces for the phy that is being configured via netlink. Later in the first function, mac80211_prepare_vif is called to set up the new interfaces as required. But sometimes, when