Re: [LEDE-DEV] [PATCH] archs38: bump kernel to 4.14.

[Hauke Mehrtens]

On 01/29/2018 04:35 PM, Evgeniy Didin wrote:
> Hello Hauke,
> 
> There are two patches, which solves problem with undefined "Abort":
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm
> it/?id=7c2c11b208be09c156573fc0076b7b3646e05219
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm
> it/?id=dc8635b78cd8669c37e230058d18c33af7451ab1
> 
> These patches are applied in Linux 4.15 ver.
> 
> I have placed these patches in target/linux/generic/backport-4.14 and
> build finished without errors.
>  
> I expect these patches will be backported in upstream 4.14 branch
> anytime soon. Until these patches are accepted should I add them with 
> separate patch or should I add them in patch-series with kernel version
> update for archs38?

Please create a separate patch which adds these to patches to
target/linux/generic/backport-4.14

I haven't seen them in the 4.14 stable queue:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-4.14

You could write to the stable mailing list to get this backported to
stable kernel 4.14, see this for details:
https://github.com/torvalds/linux/blob/master/Documentation/process/stable-kernel-rules.rst

Hauke

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] archs38: bump kernel to 4.14.

[Evgeniy Didin]

Hello Hauke,

There are two patches, which solves problem with undefined "Abort":
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm
it/?id=7c2c11b208be09c156573fc0076b7b3646e05219
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm
it/?id=dc8635b78cd8669c37e230058d18c33af7451ab1

These patches are applied in Linux 4.15 ver.

I have placed these patches in target/linux/generic/backport-4.14 and
build finished without errors.
 
I expect these patches will be backported in upstream 4.14 branch
anytime soon. Until these patches are accepted should I add them with 
separate patch or should I add them in patch-series with kernel version
update for archs38?

Best regards,
Evgeniy Didin
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] archs38: bump kernel to 4.14.

[Claudiu Zissulescu]

Hi,

The compiler generates calls to special functions (like the one in question 
_multi3) if it doesn’t have a way how to solve it (via compiler backend rules). 
This function is implemented by the libgcc which will have a default method to 
address the functionality in question.
Now, from the link which you gave me, I understand users are not very happy 
with the _multi3 implementation (128 bit multiplication) in MIPS cores, 
therefore, they come up with an patched implementation. In ARC backend we try 
to address these issues, but if there is a problem, I will be happy to fix it.
Anyhow, if you see any issue with code gen (improvements/bugs), I would 
recommend you to send it over and I will spend some time in fixing them 
directly in the compiler.

Cheers,
Claudiu

> -Original Message-
> From: Alexey Brodkin
> Sent: Monday, January 29, 2018 2:38 PM
> To: Claudiu Zissulescu <claz...@synopsys.com>
> Cc: j...@phrozen.org; lede-dev@lists.infradead.org; ha...@hauke-m.de;
> evgeniy.di...@synopsys.com; linux-snps-...@lists.infradead.org
> Subject: Re: [LEDE-DEV] [PATCH] archs38: bump kernel to 4.14.
> 
> Hi Claudiu,
> 
> Could you please comment on the question from Hauke below?
> 
> On Sat, 2018-01-27 at 16:36 +0100, Hauke Mehrtens wrote:
> > Does the arc CPU also need some special handling like some MIPS CPUs:
> >
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i
> d=bbc25bee37d2b32cf3a1fab9195b6da3a185614a
> 
> -Alexey
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] archs38: bump kernel to 4.14.

[Alexey Brodkin]

Hi Claudiu,

Could you please comment on the question from Hauke below?

On Sat, 2018-01-27 at 16:36 +0100, Hauke Mehrtens wrote:
> Does the arc CPU also need some special handling like some MIPS CPUs:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bbc25bee37d2b32cf3a1fab9195b6da3a185614a

-Alexey
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] archs38: bump kernel to 4.14.

[Hauke Mehrtens]

Hi,

On 01/23/2018 05:48 PM, Evgeniy Didin wrote:
> Update Linux kernel version from 4.9 to 4.14 for archs38.
> config-4.14 was simply regenerated with "make kernel_menuconfig".
> 
> Signed-off-by: Evgeniy Didin 
> Cc: Alexey Brodkin 
> Cc: John Crispin 
> ---
>  target/linux/archs38/Makefile  |  2 +-
>  target/linux/archs38/{config-4.9 => config-4.14}   | 52 
> +++---
>  ...stmmac-Disable-frame-filtering-completely.patch |  0
>  3 files changed, 28 insertions(+), 26 deletions(-)
>  rename target/linux/archs38/{config-4.9 => config-4.14} (85%)
>  rename target/linux/archs38/{patches-4.9 => 
> patches-4.14}/700-stmmac-Disable-frame-filtering-completely.patch (100%)

When compiling I am getting this error:

.
  Building modules, stage 2.
  MODPOST 14 modules
ERROR: "abort" [lib/mpi/mpi.ko] undefined!
scripts/Makefile.modpost:92: recipe for target '__modpost' failed
make[6]: *** [__modpost] Error 1
Makefile:1215: recipe for target 'modules' failed
make[5]: *** [modules] Error 2
...

This module has the abort symbol:
hauke@hauke-desktop:~/openwrt/lede$ nm
build_dir/target-arc_archs_uClibc/linux-archs38_generic/linux-4.14.14/lib/mpi/mpi.ko
|fgrep abort
 U abort
hauke@hauke-desktop:~/openwrt/lede$

This is my configuration:
hauke@hauke-desktop:~/openwrt/lede$ ./scripts/diffconfig.sh
CONFIG_TARGET_archs38=y
CONFIG_TARGET_archs38_generic=y
CONFIG_TARGET_archs38_generic_Default=y
CONFIG_PACKAGE_kmod-crypto-aead=y
CONFIG_PACKAGE_kmod-crypto-authenc=y
CONFIG_PACKAGE_kmod-crypto-hash=y
CONFIG_PACKAGE_kmod-crypto-hw-ccp=y
CONFIG_PACKAGE_kmod-crypto-manager=y
CONFIG_PACKAGE_kmod-crypto-null=y
CONFIG_PACKAGE_kmod-crypto-pcompress=y
CONFIG_PACKAGE_kmod-crypto-rsa=y
CONFIG_PACKAGE_kmod-crypto-sha1=y
CONFIG_PACKAGE_kmod-crypto-sha256=y
CONFIG_PACKAGE_kmod-random-core=y

I am also using your new toolchain based on gcc 7.1.

Does the arc CPU also need some special handling like some MIPS CPUs:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bbc25bee37d2b32cf3a1fab9195b6da3a185614a

> diff --git 
> a/target/linux/archs38/patches-4.9/700-stmmac-Disable-frame-filtering-completely.patch
>  
> b/target/linux/archs38/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
> similarity index 100%
> rename from 
> target/linux/archs38/patches-4.9/700-stmmac-Disable-frame-filtering-completely.patch
> rename to 
> target/linux/archs38/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch

Is this patch still needed? Did you check if this problem still exists
with kernel 4.14?

Hauke

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev