Re: [LEDE-DEV] [PATCH] bcm53xx: calculate TRX CRC32 using whole kernel partition

2016-05-09 Thread Rafał Miłecki
On 9 May 2016 at 20:40, David Lang  wrote:
> Just a note, rather than removeing copyright openwrt you should probably say
> parts are copyright openwrt and parts copyright lede
>
> just because you added a bit doesn't give you sole copyright of the file :-)
>
> but it does mean that openwrt doesn't own the copyright of the entire file
> any more either.
>
> the git history can untangle this for anyone who cares.
>
> But there is enough bad feelings going around, we don't need someone getting
> angry over copyright notices being removed.

Please don't top post and consider using dots instead of new lines ;)

I'm aware adding something new to the code doesn't give me all
Copyrights. The thing is the whole real content of the old file (one
line) was rewritten by this patch. That's why I replaced Copyright.

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev


Re: [LEDE-DEV] [PATCH] bcm53xx: calculate TRX CRC32 using whole kernel partition

2016-05-09 Thread David Lang
Just a note, rather than removeing copyright openwrt you should probably say 
parts are copyright openwrt and parts copyright lede


just because you added a bit doesn't give you sole copyright of the file :-)

but it does mean that openwrt doesn't own the copyright of the entire file any 
more either.


the git history can untangle this for anyone who cares.

But there is enough bad feelings going around, we don't need someone getting 
angry over copyright notices being removed.


David Lang

On Mon, 9 May 2016, Rafał Miłecki wrote:


Date: Mon,  9 May 2016 20:35:20 +0200
From: Rafał Miłecki 
To: lede-dev@lists.infradead.org
Cc: Hauke Mehrtens , Rafał Miłecki 
Subject: [LEDE-DEV] [PATCH] bcm53xx: calculate TRX CRC32 using whole kernel
partition

This provides better protection of flash data.

Signed-off-by: Rafał Miłecki 
---
target/linux/bcm53xx/base-files/etc/uci-defaults/09_fix_crc | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/target/linux/bcm53xx/base-files/etc/uci-defaults/09_fix_crc 
b/target/linux/bcm53xx/base-files/etc/uci-defaults/09_fix_crc
index abbb04a..e8a7e4d 100644
--- a/target/linux/bcm53xx/base-files/etc/uci-defaults/09_fix_crc
+++ b/target/linux/bcm53xx/base-files/etc/uci-defaults/09_fix_crc
@@ -1,7 +1,12 @@
#!/bin/sh
#
-# Copyright (C) 2007 OpenWrt.org
+# Copyright (C) 2016 LEDE project
#
#

-mtd fixtrx firmware || mtd fixseama firmware
+kernel_size=$(cat /proc/mtd | egrep -m 1 "kernel|linux" | cut -d ' ' -f 2)
+[ -n "$kernel_size" ] && kernel_size=$((0x$kernel_size))
+
+mtd ${kernel_size:+-c $kernel_size} fixtrx firmware && exit 0
+mtd fixseama firmware && exit 0
+exit 1
--
1.8.4.5


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev