Re: [LEDE-DEV] [PATCH rpcd] iwinfo: add info about frequency restrictions

2017-12-12 Thread Jonas Gorski
On 12 December 2017 at 23:13, Jo-Philipp Wich  wrote:
> Hi,
>
>> I'd argue the no_ prefix makes it more clear that these restrictions
>> say what is prohibited, not what is allowed.
>
> What about calling it "prohibit" instead of "restrictions" then? That
> would make it both terse and unambiguous.

Make it "prohibitions" (or "prohibited") and fine by me. I'm no native
speaker though, so if anyone could step in if I say crap that would be
helpful.

Not calling it "restrictions" also avoids the awkwardness of the
channel not being restricted ("restricted: false") but having
restrictions, which somewhat contradicts itself on a first glance.


Regards
Jonas

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev


Re: [LEDE-DEV] [PATCH rpcd] iwinfo: add info about frequency restrictions

2017-12-12 Thread Jonas Gorski
Hi,

On 12 December 2017 at 23:05, Jo-Philipp Wich  wrote:
> Hi Rafał,
>
> in principle fine with me - but I guess all restrictions will be in the
> form { : true } so I'd rather make it an array.
>
> Also since a restriction implies something not possible, I'd drop the
> "no_" prefix too. So in the end it would look like:
>
> {
>   "channel": 1,
>   "mhz": 2412,
>   "restricted": false,
>   "active": false,
>   "restrictions": [
> "ht40minus",
> "80mhz"
>   }

Do these value say what the device is restricted from, or restricted to?

I'd argue the no_ prefix makes it more clear that these restrictions
say what is prohibited, not what is allowed.


Regards
Jonas

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev


Re: [LEDE-DEV] [PATCH rpcd] iwinfo: add info about frequency restrictions

2017-12-12 Thread Jo-Philipp Wich
Hi Rafał,

in principle fine with me - but I guess all restrictions will be in the
form { : true } so I'd rather make it an array.

Also since a restriction implies something not possible, I'd drop the
"no_" prefix too. So in the end it would look like:

{
  "channel": 1,
  "mhz": 2412,
  "restricted": false,
  "active": false,
  "restrictions": [
"ht40minus",
"80mhz"
  }
}


~ Jo

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev


Re: [LEDE-DEV] [PATCH rpcd] iwinfo: add info about frequency restrictions

2017-12-12 Thread Rafał Miłecki
On 15 August 2017 at 12:49, Rafał Miłecki  wrote:
> From: Rafał Miłecki 
>
> Example frequency:
> {
> "channel": 1,
> "mhz": 2412,
> "restricted": false,
> "active": false,
> "restrictions": {
> "no_ht40minus": true,
> "no_80mhz": true
> }
> }

Jo, what do you think about this? I think you got some comments on the
suggested JSON format.

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev