Re: [LEDE-DEV] [openwrt/openwrt] toolchain/binutils: add support for version 2.30

[Arjen de Korte]

Citeren Hauke Mehrtens :


On 03/12/2018 09:48 PM, Arjen de Korte wrote:

Citeren Felix Fietkau :


On 2018-03-12 21:02, Arjen de Korte wrote:

Citeren LEDE Commits :


nbd pushed a commit to openwrt/openwrt.git, branch master:
https://git.lede-project.org/e28551b103f4999b36d3725a23b59f507830f48a

commit e28551b103f4999b36d3725a23b59f507830f48a
Author: Felix Fietkau 
AuthorDate: Thu Mar 8 11:21:58 2018 +0100

    toolchain/binutils: add support for version 2.30

    Signed-off-by: Felix Fietkau 


This doesn't fly. The 'binutils-2.30.tar.bz2' archive bundles *.rej
files:

 binutils-2.30/ld/ChangeLog.rej
 binutils-2.30/ld/ldlang.c.rej

which causes fatal build errors

 Aborting.  Reject files found.

Oops.

Forgot to push another change that I had to address this. Fixed now.


Slight uncomfortable feeling remains why these broken patches made it
into the binutils archive in the first place. Is there something missing
which really should have been included, or are these the remnants of
patches that have been superseded?


Hi Arjen,

Could you please send a mail to the binutils people so they can comment
on this and fix this in their next release.


https://sourceware.org/bugzilla/show_bug.cgi?id=22953


Hauke

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev





___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [openwrt/openwrt] toolchain/binutils: add support for version 2.30

[Hauke Mehrtens]

On 03/12/2018 09:48 PM, Arjen de Korte wrote:
> Citeren Felix Fietkau :
> 
>> On 2018-03-12 21:02, Arjen de Korte wrote:
>>> Citeren LEDE Commits :
>>>
 nbd pushed a commit to openwrt/openwrt.git, branch master:
 https://git.lede-project.org/e28551b103f4999b36d3725a23b59f507830f48a

 commit e28551b103f4999b36d3725a23b59f507830f48a
 Author: Felix Fietkau 
 AuthorDate: Thu Mar 8 11:21:58 2018 +0100

     toolchain/binutils: add support for version 2.30

     Signed-off-by: Felix Fietkau 
>>>
>>> This doesn't fly. The 'binutils-2.30.tar.bz2' archive bundles *.rej
>>> files:
>>>
>>>  binutils-2.30/ld/ChangeLog.rej
>>>  binutils-2.30/ld/ldlang.c.rej
>>>
>>> which causes fatal build errors
>>>
>>>  Aborting.  Reject files found.
>>>
>>> Oops.
>> Forgot to push another change that I had to address this. Fixed now.
> 
> Slight uncomfortable feeling remains why these broken patches made it
> into the binutils archive in the first place. Is there something missing
> which really should have been included, or are these the remnants of
> patches that have been superseded?

Hi Arjen,

Could you please send a mail to the binutils people so they can comment
on this and fix this in their next release.

Hauke

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [openwrt/openwrt] toolchain/binutils: add support for version 2.30

[Arjen de Korte]

Citeren Felix Fietkau :


On 2018-03-12 21:02, Arjen de Korte wrote:

Citeren LEDE Commits :


nbd pushed a commit to openwrt/openwrt.git, branch master:
https://git.lede-project.org/e28551b103f4999b36d3725a23b59f507830f48a

commit e28551b103f4999b36d3725a23b59f507830f48a
Author: Felix Fietkau 
AuthorDate: Thu Mar 8 11:21:58 2018 +0100

toolchain/binutils: add support for version 2.30

Signed-off-by: Felix Fietkau 


This doesn't fly. The 'binutils-2.30.tar.bz2' archive bundles *.rej files:

 binutils-2.30/ld/ChangeLog.rej
 binutils-2.30/ld/ldlang.c.rej

which causes fatal build errors

 Aborting.  Reject files found.

Oops.

Forgot to push another change that I had to address this. Fixed now.


Slight uncomfortable feeling remains why these broken patches made it  
into the binutils archive in the first place. Is there something  
missing which really should have been included, or are these the  
remnants of patches that have been superseded?




___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [openwrt/openwrt] toolchain/binutils: add support for version 2.30

[Felix Fietkau]

On 2018-03-12 21:02, Arjen de Korte wrote:
> Citeren LEDE Commits :
> 
>> nbd pushed a commit to openwrt/openwrt.git, branch master:
>> https://git.lede-project.org/e28551b103f4999b36d3725a23b59f507830f48a
>>
>> commit e28551b103f4999b36d3725a23b59f507830f48a
>> Author: Felix Fietkau 
>> AuthorDate: Thu Mar 8 11:21:58 2018 +0100
>>
>> toolchain/binutils: add support for version 2.30
>>
>> Signed-off-by: Felix Fietkau 
> 
> This doesn't fly. The 'binutils-2.30.tar.bz2' archive bundles *.rej files:
> 
>  binutils-2.30/ld/ChangeLog.rej
>  binutils-2.30/ld/ldlang.c.rej
> 
> which causes fatal build errors
> 
>  Aborting.  Reject files found.
> 
> Oops.
Forgot to push another change that I had to address this. Fixed now.

Thanks,

- Felix

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [openwrt/openwrt] toolchain/binutils: add support for version 2.30

[Arjen de Korte]

Citeren LEDE Commits :


nbd pushed a commit to openwrt/openwrt.git, branch master:
https://git.lede-project.org/e28551b103f4999b36d3725a23b59f507830f48a

commit e28551b103f4999b36d3725a23b59f507830f48a
Author: Felix Fietkau 
AuthorDate: Thu Mar 8 11:21:58 2018 +0100

toolchain/binutils: add support for version 2.30

Signed-off-by: Felix Fietkau 


This doesn't fly. The 'binutils-2.30.tar.bz2' archive bundles *.rej files:

binutils-2.30/ld/ChangeLog.rej
binutils-2.30/ld/ldlang.c.rej

which causes fatal build errors

Aborting.  Reject files found.

Oops.


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev