Re: [Ledger-smb-devel] Preparing for the 1.4 release: triaging open bugs

2014-05-17 Thread Erik Huelsmann
Hi All, Well, just finished triaging all bugs; you can find them here: https://sourceforge.net/p/ledger-smb/bugs/search/?q=%21status%3Aclosed-rejected+%26%26+%21status%3Aclosed-invalid+%26%26+%21status%3Aclosed-later+%26%26+%21status%3Aclosed-duplicate+%26%26+%21status%3Aclosed-out-of-date+%26%26+

[Ledger-smb-devel] Pull request for 1.4 branch

2014-05-17 Thread Erik Huelsmann
Hi all, After the discussion about the deprecated Error module, I've created a pull request to merge the removal of the error module from master to 1.4: https://github.com/ledgersmb/LedgerSMB/pull/56 However, since I don't want to destabilize, please review before merging (and please delete the s

Re: [Ledger-smb-devel] Error.pm deprecated

2014-05-17 Thread Chris Travers
On Sat, May 17, 2014 at 8:59 AM, wrote: > In that file I see stuff like: > $payment->error("Invalid Payment Amount Option"); > > So i am guessing $payment has an error object? Anywhere pm $payment is > used will depend on Error.pm > Not really. This calls essentially a version of the old SL::Fo

Re: [Ledger-smb-devel] Error.pm deprecated

2014-05-17 Thread turtle
In that file I see stuff like: $payment->error("Invalid Payment Amount Option"); So i am guessing $payment has an error object? Anywhere pm $payment is used will depend on Error.pm What is the plan for good old Form.pm? I never had a problem with $form->error or whatever. Cheers turtle > greppi

Re: [Ledger-smb-devel] Error.pm deprecated

2014-05-17 Thread herman vierendeels
grepping code with 'use.*Error' i only see it in ./LedgerSMB/Scripts/payment.pm:use Error; 2014-05-17 5:49 GMT+02:00 : >> Hi All, >>I've added some debug generation to the error handling, but it's >> conflicting with Error.pm on occasion which is annoying. Looking at >> Error.pm, it has been

Re: [Ledger-smb-devel] Preparing for the 1.4 release: triaging open bugs

2014-05-17 Thread Pongrácz István
Hi, This seems a good one. To help you and others, I explain my main workflows: heavy usage of parts, sometimes services and assemblies sales offer (pdf) -> sales order (pdf) -> shipping (pdf) -> sales invoice (pdf) - heavily customized xetex templates (from xdemo), utf-8 purchase order (pd