Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-11 Thread Leho Kraav
On 11.07.2015 18:04, Erik Huelsmann wrote: > > Hmm. But isn't WordPress just one example of a project that uses PHP5? > Aren't there lots of other projects that use different PHP5 code > formatting rules (if any)? Maybe you didn't mean to say what I think you > did, but like with PHP5, there are lo

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-11 Thread Erik Huelsmann
Hi Leho, On Sat, Jul 11, 2015 at 12:28 PM, Leho Kraav wrote: > On 06.07.2015 13:04, Erik Huelsmann wrote: > > Hi all, > > > > I'm going through our code quite randomly at the moment while > > investigating the multi-currency changes. > > > > What stands out at me is that we have: > > > > * dif

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-11 Thread Erik Huelsmann
On Mon, Jul 6, 2015 at 5:54 PM, Chris Bennett wrote: > On Mon, Jul 06, 2015 at 12:04:59PM +0200, Erik Huelsmann wrote: > > Hi all, > > > > I'm going through our code quite randomly at the moment while > investigating > > the multi-currency changes. > > > > What stands out at me is that we have: >

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-11 Thread Leho Kraav
On 06.07.2015 13:04, Erik Huelsmann wrote: > Hi all, > > I'm going through our code quite randomly at the moment while > investigating the multi-currency changes. > > What stands out at me is that we have: > > * different indenting methods (tabs vs spaces) > * different intenting styles (2, 3,

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-11 Thread Erik Huelsmann
Hi Michael, On Mon, Jul 6, 2015 at 4:49 PM, Michael Richardson wrote: > > Erik Huelsmann wrote: > > I'm sorry, but it's starting to disturb me (quite a bit). So, here's > my > > proposal: > > > * We remove all tabs from the code base in one huge commit (except > for > > Makefile

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Chris Travers
On Mon, Jul 6, 2015 at 8:54 AM, Chris Bennett wrote: > On Mon, Jul 06, 2015 at 12:04:59PM +0200, Erik Huelsmann wrote: > > Hi all, > > > > I'm going through our code quite randomly at the moment while > investigating > > the multi-currency changes. > > > > What stands out at me is that we have: >

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Chris Bennett
On Mon, Jul 06, 2015 at 12:04:59PM +0200, Erik Huelsmann wrote: > Hi all, > > I'm going through our code quite randomly at the moment while investigating > the multi-currency changes. > > What stands out at me is that we have: > > * different indenting methods (tabs vs spaces) > * different in

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Michael Richardson
Erik Huelsmann wrote: > I'm sorry, but it's starting to disturb me (quite a bit). So, here's my > proposal: > * We remove all tabs from the code base in one huge commit (except for > Makefile) Yes, and nuke trailing whitespace too. > * From there on, we watch out not to add

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Erik Huelsmann
Hi Chris, I've re-organized the page documenting our Perl coding requirements: http://ledgersmb.org/topic/perl-coding-guidelines Feel free to further edit as you see fit. Regards, Erik. On Mon, Jul 6, 2015 at 1:26 PM, Chris Travers wrote: > Two brief comments > > On Mon, Jul 6, 2015 at

Re: [Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Chris Travers
Two brief comments On Mon, Jul 6, 2015 at 3:04 AM, Erik Huelsmann wrote: > Hi all, > > I'm going through our code quite randomly at the moment while > investigating the multi-currency changes. > > What stands out at me is that we have: > > * different indenting methods (tabs vs spaces) > *

[Ledger-smb-devel] Code formatting discussion/proposal

2015-07-06 Thread Erik Huelsmann
Hi all, I'm going through our code quite randomly at the moment while investigating the multi-currency changes. What stands out at me is that we have: * different indenting methods (tabs vs spaces) * different intenting styles (2, 3, 4+ spaces) * different widths: 80 on most files, but I've