Re: [Ledger-smb-devel] Enabling/using Perl 5.10+

2017-05-14 Thread R. Ransbottom
On Sun, May 14, 2017 at 11:09:31AM +0200, Chris Travers wrote: > On Sun, May 14, 2017 at 3:23 AM, R. Ransbottom wrote: > IIRC, given/when is deprecated again :-P That supports either argument. > Yeah, my experience is a lot of features don't need to be turned on which > can lead to accidental

Re: [Ledger-smb-devel] Enabling/using Perl 5.10+

2017-05-14 Thread Chris Travers
On Sun, May 14, 2017 at 3:23 AM, R. Ransbottom wrote: > On Fri, May 12, 2017 at 10:13:53PM +0200, Erik Huelsmann wrote: > > Hi Rob, > > > > Personally, I am not set on any particular version number. And that > ... > > > > ... that statement [use v5.14;] also means that we will > automatically >

Re: [Ledger-smb-devel] Enabling/using Perl 5.10+

2017-05-13 Thread R. Ransbottom
On Fri, May 12, 2017 at 10:13:53PM +0200, Erik Huelsmann wrote: > Hi Rob, > > Personally, I am not set on any particular version number. And that ... > > > ... that statement [use v5.14;] also means that we will automatically > > > * use strict; > > > * availability of the functions say() and st

Re: [Ledger-smb-devel] Enabling/using Perl 5.10+ functions: say(), state(), given/switch and "'use strict' by default"

2017-05-12 Thread Erik Huelsmann
Hi Rob, > > In the comments to his PR ( > > https://github.com/ledgersmb/LedgerSMB/pull/2695#issuecomment-300053021 > ), > > Rob suggests we should start using > > > use v5.14; > > Personally, I am not set on any particular version number. And that > would be most important as it would effect u

Re: [Ledger-smb-devel] Enabling/using Perl 5.10+ functions: say(), state(), given/switch and "'use strict' by default"

2017-05-10 Thread R. Ransbottom
On Wed, May 10, 2017 at 05:24:24PM +0200, Erik Huelsmann wrote: > Hi all, > > In the comments to his PR ( > https://github.com/ledgersmb/LedgerSMB/pull/2695#issuecomment-300053021), > Rob suggests we should start using > use v5.14; Personally, I am not set on any particular version number. And

[Ledger-smb-devel] Enabling/using Perl 5.10+ functions: say(), state(), given/switch and "'use strict' by default"

2017-05-10 Thread Erik Huelsmann
Hi all, In the comments to his PR ( https://github.com/ledgersmb/LedgerSMB/pull/2695#issuecomment-300053021), Rob suggests we should start using use v5.14; in our code, as we defined that our minimal Perl version is 5.14 as of 1.6. While our cpanfile indeed should include that statement, I'm le