Re: [Ledger-smb-devel] partsvendor, entity_id and vendor_id

2010-03-16 Thread Chris Travers
On Mon, Mar 15, 2010 at 10:02 PM, Ian Goodacre wrote: > On Mon, 2010-03-15 at 08:15 -0800, Chris Travers wrote: >> I thought I committed a fix to that in svn last night :-) >> > > I see it now. > > I have posted another couple of patches to the tracker that fix two more > joins on partsvendor. > >

Re: [Ledger-smb-devel] partsvendor, entity_id and vendor_id

2010-03-15 Thread Ian Goodacre
On Mon, 2010-03-15 at 08:15 -0800, Chris Travers wrote: > I thought I committed a fix to that in svn last night :-) > I see it now. I have posted another couple of patches to the tracker that fix two more joins on partsvendor. Sub price_matrix_query in LedgerSMB/PriceMatrix.pm has several refe

Re: [Ledger-smb-devel] partsvendor, entity_id and vendor_id

2010-03-15 Thread Chris Travers
On Mon, Mar 15, 2010 at 1:23 AM, Ian Goodacre wrote: > Hi Chris, > > Initial visual review is promising. I'll retest the problems I had and > let you know... > > I think a misplaced colon in sql/modules/Roles.sql: > > CREATE ROLE "lsmb___users_manage" > WITH INHERIT NOLOGIN; > IN ROLE "lsmb___cont

Re: [Ledger-smb-devel] partsvendor, entity_id and vendor_id

2010-03-15 Thread Ian Goodacre
Hi Chris, Initial visual review is promising. I'll retest the problems I had and let you know... I think a misplaced colon in sql/modules/Roles.sql: CREATE ROLE "lsmb___users_manage" WITH INHERIT NOLOGIN; IN ROLE "lsmb___contact_read" Regards, Ian Goodacre On Sat, 2010-03-13 at 22:58 -0800, C

Re: [Ledger-smb-devel] partsvendor, entity_id and vendor_id

2010-03-13 Thread Luke
Chris I think you were going to look at a duedate problem in one (some?) of the AP forms of 1.2. Were you able to investigate that? Just trying to keep it on the burner somewhere--by its nature it is not a critical bug, obviously. If you don't think you will get to it any time soon, I may tak

Re: [Ledger-smb-devel] partsvendor, entity_id and vendor_id

2010-03-13 Thread Chris Travers
On Thu, Mar 11, 2010 at 9:27 PM, Ian Goodacre wrote: > On Thu, 2010-03-11 at 12:49 -0800, Chris Travers wrote: >> If it's ok with you... > > It certainly is. And thanks for the prompt attention. > I have committed my fixes here. Feel free to review and suggest changes. Best Wishes, Chris Travers

Re: [Ledger-smb-devel] partsvendor, entity_id and vendor_id

2010-03-11 Thread Ian Goodacre
On Thu, 2010-03-11 at 12:49 -0800, Chris Travers wrote: > If it's ok with you... It certainly is. And thanks for the prompt attention. Regards, Ian Goodacre -- Download IntelĀ® Parallel Studio Eval Try the new software t

Re: [Ledger-smb-devel] partsvendor, entity_id and vendor_id

2010-03-11 Thread Chris Travers
I am looking at getting this straightened out this week/weekend. This will probably include renaming columns as appropriate. If it's ok with you, I would like to take the first crack at this just because I have a pretty good idea of exactly where these tables are hit. Best Wishes, Chris Travers

[Ledger-smb-devel] partsvendor, entity_id and vendor_id

2010-03-11 Thread Ian Goodacre
I encountered an error entering a purchase order with a new part: DBD::Pg::st execute failed: ERROR: column "vendor_id" of relation "partsvendor" does not exist Rather than vendor_id, the partsvendor relation has an entity_id column but, despite what one might guess from the name, this is not a