Re: [Ledger-smb-users] ledgersmb.spec in version 1.4.20

2015-12-28 Thread David Godfrey
Hi John, That is the answer I was hoping to hear. Spaces in paths and filenames are *EVIL* :-) Doesn't excuse our script breaking when there are spaces though. Regards David G On 29/12/15 05:39, John Locke wrote: Hi,

Re: [Ledger-smb-users] ledgersmb.spec in version 1.4.20

2015-12-28 Thread John Locke
Hi, On 12/28/2015 09:20 AM, Erik Huelsmann wrote: On Tue, Dec 8, 2015 at 7:48 AM, David Godfrey > wrote: On 07/12/15 22:39, Khalil Foundy wrote: Hi David I just run a quick find command and found 3 files with spaces in there names. These are dojo

Re: [Ledger-smb-users] ledgersmb.spec in version 1.4.20

2015-12-28 Thread Erik Huelsmann
Hi Khalil, What's your result so far? Could you share the process you went through building the RPMs? Would you be interested in helping us get a package build in place which creates packages for every patch release in the 1.4 (and soon 1.5) series? Kindest regards, Erik. On Tue, Dec 8, 2015

Re: [Ledger-smb-users] ledgersmb.spec in version 1.4.20

2015-12-08 Thread Khalil Foundy
Hi David and ErikI created a patch file for chmod only. I will wait for  Erik to see what's the purpose of the symlink and if it has to be rewritten or simply removed. The patch is attached bellow. Regards. Khalil FOUNDY Le mardi 8 décembre 2015 1h48, David Godfrey a écrit : Hi Khali

Re: [Ledger-smb-users] ledgersmb.spec in version 1.4.20

2015-12-07 Thread David Godfrey
Hi Khalil, I have specifically cc'd Erik in on this email, hopefully he can clarify the intention behind the dojo symlink. As for the filenames with spaces in them, I agree that we should fix the chmod to work regardless, but at the same time I know that find has

Re: [Ledger-smb-users] ledgersmb.spec in version 1.4.20

2015-12-07 Thread Khalil Foundy
Hi DavidI just run a quick find command and found 3 files with spaces in there names. These are dojo demos files, so they might not be important after all. Here they are:UI/lib/dojo/dojox/data/demos/geography/United\ States\ of\ America UI/lib/dojo/dojox/data/demos/geography/Commonwealth\ of\ Aus

Re: [Ledger-smb-users] ledgersmb.spec in version 1.4.20

2015-12-04 Thread David G
Hi Khalil, Others will comment on the changes as well, although I think the chmod change looks fine. The symlink (ln -s) on the other hand can not be removed. It is (as of 1.4) an essential part of the project as dojo is used to provide User Interface featur

Re: [Ledger-smb-users] ledgersmb.spec in version 1.4.20

2015-12-04 Thread David Godfrey
Hi Khalil, Others will comment on the changes as well, although I think the chmod change looks fine. The symlink (ln -s) on the other hand can not be removed. It is (as of 1.4) an essential part of the project as dojo is used to provide User Interface featur

[Ledger-smb-users] ledgersmb.spec in version 1.4.20

2015-12-04 Thread Khalil Foundy
I don't know if this has been discussed here before or not. I haven't red this mailing list for a while and I have never generated an RPM package for ledgersmb before today. So bare with me please.Anyway, I found a bug in ledgersmb and here it is. First the two chmod fail when they encounter fil