Re: #350: Themes are ready for serious testing

2017-03-10 Thread lewis
I have exactly the same myLeoSettings.leo file on 2 PC's both running commit = 51b3d984000e. The selected theme is 'base dark theme'. On Vista PC with Python 3.5.2, PyQt version 5.6.0 installed, the theme is dark all over as expected. However on win10 PC with Python 3.6.0, PyQt version 5.8.0

Re: Menu clarity - Open Leo File

2017-03-10 Thread lewis
The same principle can be applied to *some* parts of the Help menu but each case should be considered on it's merits. so the Help menu would change from: Help> About Leo Open Home Page Open Table of Contents Open Users Guide Open Text Tutorials Open

Re: Proposed refactoring of @theme nodes in leoSettings.leo

2017-03-10 Thread Edward K. Ream
On Friday, March 10, 2017 at 4:26:41 AM UTC-6, Edward K. Ream wrote: > > I am about to refactor Leo's the @theme trees in leoSettings.leo into an > unchanging *base *part, and a few *overrides *for each theme. Themes will > be defined by their overrides. > This project is now complete. The

Re: Proposed refactoring of @theme nodes in leoSettings.leo

2017-03-10 Thread Edward K. Ream
On Fri, Mar 10, 2017 at 8:06 AM, Terry Brown wrote: > > Sure you have to restart Leo if you swap out leoSettings.leo, but a > branch is still a convenient container for a set of related changes, > not sure I follow the above. > ​Well, the work is done. It was

Re: Proposed refactoring of @theme nodes in leoSettings.leo

2017-03-10 Thread Terry Brown
On Fri, 10 Mar 2017 02:26:41 -0800 (PST) "Edward K. Ream" wrote: > Note to Terry. You need not be concerned about this. The proposal > does not affect existing users of themes directly, except to clarify > the differences between themes. > > If there is a problem, we could

Re: Proposed refactoring of @theme nodes in leoSettings.leo

2017-03-10 Thread Edward K. Ream
​​On Fri, Mar 10, 2017 at 4:26 AM, Edward K. Ream wrote: I am about to refactor Leo's the @theme trees in leoSettings.leo into an > unchanging *base *part, and a few *overrides *for each theme. Themes will > be defined by their overrides. > ​Done at d6ac525. After a few

Re: Proposed refactoring of @theme nodes in leoSettings.leo

2017-03-10 Thread lewis
*The question is, what to do with the existing incomprehensible themes?* The only themes which I found fully useable were leo_dark theme 1 and leo_dark theme 2. For me I'm OK with keeping my own copy until the new scheme is proven. I'll be pleased to test out the new @theme base dark, and

Re: #350: Themes are ready for serious testing

2017-03-10 Thread Edward K. Ream
On Fri, Mar 10, 2017 at 4:24 AM, lewis wrote: > Running 'windows ekr dark theme' if I select a menu bar item, the text > displayed is not readable unless I place cursor over it. e.g. Help> about > Leo > the text is a very light grey on an even lighter background >

Re: Another small glitch (recurring icon problem)

2017-03-10 Thread Edward K. Ream
On Fri, Mar 10, 2017 at 5:45 AM, tscv11 wrote: > Okay, thank you Sirs. > > I am happy to report (sort of): > > My icons have gone ka-flooey again (and I haven't used Leo since posting > about the problem). > ​Sounds like a windows registry problem to me. Or malware. Edward

Re: Proposed refactoring of @theme nodes in leoSettings.leo

2017-03-10 Thread Edward K. Ream
On Friday, March 10, 2017 at 4:26:41 AM UTC-6, Edward K. Ream wrote: I am about to refactor Leo's the @theme trees in leoSettings.leo into an > unchanging *base *part, and a few *overrides *for each theme. Themes will > be defined by their overrides. > After several hours of work, I am

Re: Another small glitch (recurring icon problem)

2017-03-10 Thread tscv11
Okay, thank you Sirs. I am happy to report (sort of): My icons have gone ka-flooey again (and I haven't used Leo since posting about the problem). So, in other words, it's *not* Leo causing the icon problem. Actually I *am* happy, because I was so desperate that I was studying 'org-mode',

Proposed refactoring of @theme nodes in leoSettings.leo

2017-03-10 Thread Edward K. Ream
Note to Terry. You need not be concerned about this. The proposal does not affect existing users of themes directly, except to clarify the differences between themes. If there is a problem, we could revert just leoSettings.leo. Moving to a new branch doesn't help because changes to

Re: #350: Themes are ready for serious testing

2017-03-10 Thread lewis
Running 'windows ekr dark theme' if I select a menu bar item, the text displayed is not readable unless I place cursor over it. e.g. Help> about Leo the text is a very light grey on an even lighter background - no contrast is the problem. So from 'windows ekr dark theme' this is the console