Re: launching unit tests

2017-11-15 Thread Terry Brown
On Wed, 15 Nov 2017 08:52:43 -0600 "Edward K. Ream" wrote: > ​Afaik, all tests run regardless of personal settings.  Let me know > if that isn't true for a particular test. Well it's definitely not true for some values of the the @enabled-plugins setting - but of course that's a setting with the

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Wed, Nov 15, 2017 at 8:13 AM, Terry Brown wrote: > On Wed, 15 Nov 2017 08:02:37 -0600 > "Edward K. Ream" wrote: > > > Sounds like this is all fixed now, but I wonder if the failure you > > were seeing implies that you run the unit tests with your personal > > myLeoSettings in effect and if it

Re: launching unit tests

2017-11-15 Thread Terry Brown
On Wed, 15 Nov 2017 08:02:37 -0600 "Edward K. Ream" wrote: > Sounds like this is all fixed now, but I wonder if the failure you > were seeing implies that you run the unit tests with your personal > myLeoSettings in effect and if it would be better to run them without > that? > > ​Terminology: l

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Wed, Nov 15, 2017 at 7:34 AM, Terry Brown wrote: Sounds like this is all fixed now, but I wonder if the failure you were > seeing implies that you run the unit tests with your personal > myLeoSettings in effect and if it would be better to run them without > that? > ​Terminology: let "the set

Re: #417 (Complete reload-settings) is now complete.

2017-11-15 Thread Edward K. Ream
On Tuesday, November 14, 2017 at 10:57:11 AM UTC-6, Edward K. Ream wrote: For full details, see 417 > . The issue starts > with an updated summary. Devs, please take a look. > Recent revs use the reloadSettings pattern in most plugins. The p

Re: launching unit tests

2017-11-15 Thread Terry Brown
On Wed, 15 Nov 2017 06:09:56 -0600 "Edward K. Ream" wrote: > ​Fixed at 2360208.  As you say, there is no need to override the > setting: > >     @bool scripting-at-script-nodes = True > > if it was properly set in myLeoSettings.leo. > > ​Hmm.  This causes @test c.theScriptingController.atScrip

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Wednesday, November 15, 2017 at 6:57:17 AM UTC-6, Edward K. Ream wrote: This uses the new gcm.myLeoSettingsValueOfSetting method. > I've changed the name to valueInMyLeoSettings so that it sounds like it was named by a native speaker of English ;-) Edward -- You received this message becau

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Wed, Nov 15, 2017 at 6:09 AM, Edward K. Ream wrote: ​Rev 0f03006 carefully checks the value of @bool scripting-at-script-nodes in myLeoSettings.leo and restores that value after issuing the security warning. This uses the new gcm.myLeoSettingsValueOfSetting method. As of rev 49c7ade, the un

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Wed, Nov 15, 2017 at 5:47 AM, Edward K. Ream wrote: > On Sun, Nov 12, 2017 at 11:47 AM, Terry Brown > wrote: > > > As you say, enabling @script nodes in unitTest.leo is intended to >> > generate a warning. >> >> Sure, but it could do that without overriding the setting in >> myLeoSettings.leo

Re: launching unit tests

2017-11-15 Thread Edward K. Ream
On Sun, Nov 12, 2017 at 11:47 AM, Terry Brown wrote: > As you say, enabling @script nodes in unitTest.leo is intended to > > generate a warning. > > Sure, but it could do that without overriding the setting in > myLeoSettings.leo. Currently it seems that setting it True in > myLeoSettings.leo an