Re: Devs: please run unit tests, pylint and pyflakes more often

2017-11-16 Thread Edward K. Ream
On Thursday, November 16, 2017 at 10:51:25 AM UTC-6, Edward K. Ream wrote: A few notes about reinstalling Anaconda, copied from a recent issue: The following worked to upgrade Anaconda for me, and now the qtconsole works for 2 and 3: conda2 update --all # python 2 conda update --all # python

Re: Devs: please run unit tests, pylint and pyflakes more often

2017-11-16 Thread Terry Brown
On Thu, 16 Nov 2017 12:07:51 -0600 "Edward K. Ream" wrote: > ​You will quickly wonder how you ever lived without it. It is, by > far, the best python tool available. I use pyflakes, just didn't recall the Leo setting. It seems mostly to save you from running code that's

Re: Devs: please run unit tests, pylint and pyflakes more often

2017-11-16 Thread Edward K. Ream
On Thu, Nov 16, 2017 at 11:54 AM, Terry Brown wrote: > It would also be good to run pylint -a before all commits. > > I'll give pylint a try, although my impression in the past is that it > whines more than it helps. The changes I see in Leo source to > accommodate it

Devs: please run unit tests, pylint and pyflakes more often

2017-11-16 Thread Edward K. Ream
I've put a lot of work into making running unit tests faster and more convenient. Please run them before all commits. Terry, your concerns about environmental concerns are valid, but until #577 Create a new TestCase subclass for reformatting unit tests

4d01ec92: Fixed a hangnail involving unit tests

2017-11-16 Thread Edward K. Ream
The checkin log: QQQ Fixed an irritating hangnail in the unit tests by fixing a bug in LM.computeWorkbookFileName. LM.computeWorkbookFileName now returns None only if: 1. The workbook does not exist. 2. We are unit testing or in batch mode. Previously, the method returned None

Re: launching unit tests

2017-11-16 Thread Edward K. Ream
On Wed, Nov 15, 2017 at 10:51 AM, Terry Brown wrote: ​​ > for example a test of paragraph rejustification might be easier to > write if you didn't have to account for different user preferences on > text width - that sort of thing. > ​I agree​. Happily, there is a