Re: Most of the GlobalConfigManager is gone!

found another one the getbool below should be getString in leoCommands.py base = c.config.getBool('relative-path-base-directory') Félix On Friday, June 24, 2022 at 11:48:47 PM UTC-4 tbp1...@gmail.com wrote: > The Nav tab is my friend : ) > > On Friday, June 24, 2022 at 10:39:54 PM UTC-4 Edwar

Re: Most of the GlobalConfigManager is gone!

The Nav tab is my friend : ) On Friday, June 24, 2022 at 10:39:54 PM UTC-4 Edward K. Ream wrote: > On Fri, Jun 24, 2022 at 4:51 PM tbp1...@gmail.com > wrote: > >> This actually occurs in two places. >> > > Thanks. I missed one of the places the first time! > > Edward > -- You received this m

Re: Most of the GlobalConfigManager is gone!

the context_menus that can be a property of g.app.config is not previously defined (at least as 'none') on GlobalConfigManager, and is 'tacked on' unceremoniously in the doPopup method. (in leoConfig.js) Félix On Friday, June 24, 2022 at 10:39:54 PM UTC-4 Edward K. Ream wrote: > On Fri, Jun 2

Re: Most of the GlobalConfigManager is gone!

On Fri, Jun 24, 2022 at 4:51 PM tbp1...@gmail.com wrote: > This actually occurs in two places. > Thanks. I missed one of the places the first time! Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop

Re: Most of the GlobalConfigManager is gone!

On Fri, Jun 24, 2022 at 4:50 PM Félix wrote: > Continuing testing those changes, the little annoying "saving leoPyRef.leo > changes the whole file by a lot" buglet came back. I did notice the large diff, but there may have been quite a few "real" diffs recently. I suppose I should investigate

Re: Most of the GlobalConfigManager is gone!

This actually occurs in two places. On Friday, June 24, 2022 at 5:29:11 PM UTC-4 Félix wrote: > oh, just posted under the closed pull request but since i discovered this > thread exists on the forum i'll post it here instead: > > in leoGlobals, in the getBaseDirectory method, this should be a g

Re: Most of the GlobalConfigManager is gone!

Continuing testing those changes, the little annoying "saving leoPyRef.leo changes the whole file by a lot" buglet came back. Félix On Friday, June 24, 2022 at 5:29:11 PM UTC-4 Félix wrote: > oh, just posted under the closed pull request but since i discovered this > thread exists on the forum

Re: Most of the GlobalConfigManager is gone!

oh, just posted under the closed pull request but since i discovered this thread exists on the forum i'll post it here instead: in leoGlobals, in the getBaseDirectory method, this should be a getString, not a getBool *base = c.config.getBool('relative-path-base-directory')* Félix On Friday, J

Most of the GlobalConfigManager is gone!

PR #2692 contains a grand simplification of Leo's config code! The GCM no longer sets ivars or specifies defaults. This eliminates a lot of code and data. More importantly, the GCM is no longer involved in policy questions. Rather than usin