Re: Another small Q: selecting test and text endings

OK, a fix is proposed in PR 2700 . It wasn't an off-by-one. It was a missing bit of logic. I needed to restrict the movement to the end of the last line to the case where the cursor was already on the last line when the Down key is pressed.

Re: Another small Q: selecting test and text endings

Hmm, this is not quite working as I want. If you place the cursor in the left-hand column of a line above the last line, and Shift-Down to the last line, the cursor jumps to the end of the last line. It should go to the start of the last line. This seems different from what I thought I had w

Re: Another small Q: selecting test and text endings

@Edward has merged the PR. On Tuesday, June 28, 2022 at 1:12:03 PM UTC-4 Edward K. Ream wrote: > On Tue, Jun 28, 2022 at 11:33 AM Jacob MacDonald > wrote: > > In the tbp directory, you need to run `git checkout tbp-leo-general` and >> then should see the new code. >> > > Thanks, Jacob. That w

Re: Another small Q: selecting test and text endings

On Tue, Jun 28, 2022 at 11:33 AM Jacob MacDonald wrote: In the tbp directory, you need to run `git checkout tbp-leo-general` and > then should see the new code. > Thanks, Jacob. That worked. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" gro

Re: Another small Q: selecting test and text endings

Edward K. Ream wrote: >> - In that page, I copied the "Code" link, whose contents is: >> https://github.com/tbpassin/leo-editor.git > Something strange is happening. I'll continue to investigate. The instructions GitHub gives you to clone don't change based on which branch you're viewing. In the

Re: Another small Q: selecting test and text endings

On Tue, Jun 28, 2022 at 7:43 AM tbp1...@gmail.com wrote: > After I pushed my change to Github, Github recognized that I had made a > commit and offered to create a PR, which I accepted. So at that time > Github knew there had been a commit. I also see that the changes are in my > Github leo-edi

Re: Another small Q: selecting test and text endings

On Tuesday, June 28, 2022 at 2:11:43 AM UTC-4 Edward K. Ream wrote: > On Monday, June 27, 2022 at 1:42:26 PM UTC-5 tbp1...@gmail.com wrote: > >> PR 2698 handles >> this (when merged). >> > > I'm having trouble testing the code. Maybe I'm not us

Re: Another small Q: selecting test and text endings

After I pushed my change to Github, Github recognized that I had made a commit and offered to create a PR, which I accepted. So at that time Github knew there had been a commit. I also see that the changes are in my Github leo-editor repo, starting at line 1796 in qt_text.py. The branch is no