Re: Heh. I changed a gnx in the big PR by mistake

On Thursday, July 6, 2023 at 7:39:06 PM UTC-5 Edward K. Ream wrote: PR #3430 Sent too early by mistake. I meant to say that PR 3430 needs more testing. Edward -- You received this message because you are subscribed to the Google Groups "

Re: Heh. I changed a gnx in the big PR by mistake

On Thu, Jul 6, 2023 at 7:02 PM Thomas Passin wrote: > : ) > Congratulations on another excellent collaboration. We have, yet again, accomplished what neither would have done alone. PR #3430 Edward -- You received this message because you

Re: Heh. I changed a gnx in the big PR by mistake

: ) On Thursday, July 6, 2023 at 1:44:36 PM UTC-4 Edward K. Ream wrote: > On Thu, Jul 6, 2023 at 11:58 AM Thomas Passin wrote: > > Say you (Edward, I imagine) move a subtree that contains Terry's nodes to >> the Attic. If you forget and just do a cut-and-paste, suddenly they become >> your nod

Re: Heh. I changed a gnx in the big PR by mistake

On Thu, Jul 6, 2023 at 11:58 AM Thomas Passin wrote: Say you (Edward, I imagine) move a subtree that contains Terry's nodes to > the Attic. If you forget and just do a cut-and-paste, suddenly they become > your nodes. Or maybe just the head of the subtree becomes your node, I > don't even know.

Re: Heh. I changed a gnx in the big PR by mistake

On Thursday, July 6, 2023 at 12:31:55 PM UTC-4 Edward K. Ream wrote: On Thursday, July 6, 2023 at 11:11:51 AM UTC-5 Thomas wrote: Reminding people (including devs) to "be careful" isn't enough. It's not about being careful. It's about not needlessly cutting/pasting nodes. Devs must not cut/p

Re: Heh. I changed a gnx in the big PR by mistake

On Thursday, July 6, 2023 at 11:04:18 AM UTC-5 Edward K. Ream wrote: The diffs for PR #3215 show that the gnx changed for p.get_GNX, renamed. - #@+node:tbrown.20111010104549.26758: *4* p.get_UNL + #@+node:ekr.20230628174317.1: *5* p.get

Re: Heh. I changed a gnx in the big PR by mistake

On Thursday, July 6, 2023 at 11:11:51 AM UTC-5 Thomas wrote: Reminding people (including devs) to "be careful" isn't enough. It's not about being careful. It's about not needlessly cutting/pasting nodes. Devs must not cut/paste nodes if they intend to issue a PR that changes those nodes. Dev

Re: Heh. I changed a gnx in the big PR by mistake

See, it even happens to Edward. Let's make things so that it won't happen to anyone. Reminding people (including devs) to "be careful" isn't enough. On Thursday, July 6, 2023 at 12:04:18 PM UTC-4 Edward K. Ream wrote: > I'm glad we've had the conversation about cut-node/paste-node. It reminded

Heh. I changed a gnx in the big PR by mistake

I'm glad we've had the conversation about cut-node/paste-node. It reminded me of something that has been bothering me subconsciously. The diffs for PR #3215 show that the gnx changed for p.get_GNX, renamed. - #@+node:tbrown.20111010104